ed5c2f5fd1
The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Crt Mori <cmo@melexis.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Marek Behún <kabel@kernel.org> # for leds-turris-omnia Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for surface3_power Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013 Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for media/* + staging/media/* Acked-by: Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # for versaclock5 Reviewed-by: Ajay Gupta <ajayg@nvidia.com> # for ucsi_ccg Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio Acked-by: Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860 Acked-by: Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b Reviewed-by: Jean Delvare <jdelvare@suse.de> # for hwmon, i2c-core and i2c/muxes Acked-by: Corey Minyard <cminyard@mvista.com> # for IPMI Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power Acked-by: Krzysztof Hałasa <khalasa@piap.pl> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
73 lines
1.8 KiB
C
73 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* I2C access driver for TI TPS65912x PMICs
|
|
*
|
|
* Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com/
|
|
* Andrew F. Davis <afd@ti.com>
|
|
*
|
|
* Based on the TPS65218 driver and the previous TPS65912 driver by
|
|
* Margarita Olaya Cabrera <magi@slimlogic.co.uk>
|
|
*/
|
|
|
|
#include <linux/i2c.h>
|
|
#include <linux/module.h>
|
|
#include <linux/regmap.h>
|
|
|
|
#include <linux/mfd/tps65912.h>
|
|
|
|
static const struct of_device_id tps65912_i2c_of_match_table[] = {
|
|
{ .compatible = "ti,tps65912", },
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, tps65912_i2c_of_match_table);
|
|
|
|
static int tps65912_i2c_probe(struct i2c_client *client,
|
|
const struct i2c_device_id *ids)
|
|
{
|
|
struct tps65912 *tps;
|
|
|
|
tps = devm_kzalloc(&client->dev, sizeof(*tps), GFP_KERNEL);
|
|
if (!tps)
|
|
return -ENOMEM;
|
|
|
|
i2c_set_clientdata(client, tps);
|
|
tps->dev = &client->dev;
|
|
tps->irq = client->irq;
|
|
|
|
tps->regmap = devm_regmap_init_i2c(client, &tps65912_regmap_config);
|
|
if (IS_ERR(tps->regmap)) {
|
|
dev_err(tps->dev, "Failed to initialize register map\n");
|
|
return PTR_ERR(tps->regmap);
|
|
}
|
|
|
|
return tps65912_device_init(tps);
|
|
}
|
|
|
|
static void tps65912_i2c_remove(struct i2c_client *client)
|
|
{
|
|
struct tps65912 *tps = i2c_get_clientdata(client);
|
|
|
|
tps65912_device_exit(tps);
|
|
}
|
|
|
|
static const struct i2c_device_id tps65912_i2c_id_table[] = {
|
|
{ "tps65912", 0 },
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, tps65912_i2c_id_table);
|
|
|
|
static struct i2c_driver tps65912_i2c_driver = {
|
|
.driver = {
|
|
.name = "tps65912",
|
|
.of_match_table = tps65912_i2c_of_match_table,
|
|
},
|
|
.probe = tps65912_i2c_probe,
|
|
.remove = tps65912_i2c_remove,
|
|
.id_table = tps65912_i2c_id_table,
|
|
};
|
|
module_i2c_driver(tps65912_i2c_driver);
|
|
|
|
MODULE_AUTHOR("Andrew F. Davis <afd@ti.com>");
|
|
MODULE_DESCRIPTION("TPS65912x I2C Interface Driver");
|
|
MODULE_LICENSE("GPL v2");
|