81e7b165c4
sound/soc/codecs/lpass-macro-common.c:28 lpass_macro_pds_init() warn: passing zero to 'PTR_ERR'
sound/soc/codecs/lpass-macro-common.c:38 lpass_macro_pds_init() warn: passing zero to 'PTR_ERR'
sound/soc/codecs/lpass-macro-common.c:54 lpass_macro_pds_init() warn: passing zero to 'ERR_PTR'
dev_pm_domain_attach_by_name() may return NULL, set 'ret' as
-ENODATA to fix this warning.
Fixes: 1a8ee4cf84 ("ASoC: codecs: Fix error handling in power domain init and exit handlers")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20220516120909.36356-1-yuehaibing@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
71 lines
1.7 KiB
C
71 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
// Copyright (c) 2022, The Linux Foundation. All rights reserved.
|
|
|
|
#include <linux/export.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pm_domain.h>
|
|
#include <linux/pm_runtime.h>
|
|
|
|
#include "lpass-macro-common.h"
|
|
|
|
struct lpass_macro *lpass_macro_pds_init(struct device *dev)
|
|
{
|
|
struct lpass_macro *l_pds;
|
|
int ret;
|
|
|
|
if (!of_find_property(dev->of_node, "power-domains", NULL))
|
|
return NULL;
|
|
|
|
l_pds = devm_kzalloc(dev, sizeof(*l_pds), GFP_KERNEL);
|
|
if (!l_pds)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
l_pds->macro_pd = dev_pm_domain_attach_by_name(dev, "macro");
|
|
if (IS_ERR_OR_NULL(l_pds->macro_pd)) {
|
|
ret = l_pds->macro_pd ? PTR_ERR(l_pds->macro_pd) : -ENODATA;
|
|
goto macro_err;
|
|
}
|
|
|
|
ret = pm_runtime_resume_and_get(l_pds->macro_pd);
|
|
if (ret < 0)
|
|
goto macro_sync_err;
|
|
|
|
l_pds->dcodec_pd = dev_pm_domain_attach_by_name(dev, "dcodec");
|
|
if (IS_ERR_OR_NULL(l_pds->dcodec_pd)) {
|
|
ret = l_pds->dcodec_pd ? PTR_ERR(l_pds->dcodec_pd) : -ENODATA;
|
|
goto dcodec_err;
|
|
}
|
|
|
|
ret = pm_runtime_resume_and_get(l_pds->dcodec_pd);
|
|
if (ret < 0)
|
|
goto dcodec_sync_err;
|
|
return l_pds;
|
|
|
|
dcodec_sync_err:
|
|
dev_pm_domain_detach(l_pds->dcodec_pd, false);
|
|
dcodec_err:
|
|
pm_runtime_put(l_pds->macro_pd);
|
|
macro_sync_err:
|
|
dev_pm_domain_detach(l_pds->macro_pd, false);
|
|
macro_err:
|
|
return ERR_PTR(ret);
|
|
}
|
|
EXPORT_SYMBOL_GPL(lpass_macro_pds_init);
|
|
|
|
void lpass_macro_pds_exit(struct lpass_macro *pds)
|
|
{
|
|
if (pds) {
|
|
pm_runtime_put(pds->macro_pd);
|
|
dev_pm_domain_detach(pds->macro_pd, false);
|
|
pm_runtime_put(pds->dcodec_pd);
|
|
dev_pm_domain_detach(pds->dcodec_pd, false);
|
|
}
|
|
}
|
|
EXPORT_SYMBOL_GPL(lpass_macro_pds_exit);
|
|
|
|
MODULE_DESCRIPTION("Common macro driver");
|
|
MODULE_LICENSE("GPL");
|