a0386bba70
The value returned by an spi driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Jérôme Pouiller <jerome.pouiller@silabs.com> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Acked-by: Claudius Heine <ch@denx.de> Acked-by: Stefan Schmidt <stefan@datenfreihafen.org> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-by: Ulf Hansson <ulf.hansson@linaro.org> # For MMC Acked-by: Marcus Folkesson <marcus.folkesson@gmail.com> Acked-by: Łukasz Stelmach <l.stelmach@samsung.com> Acked-by: Lee Jones <lee.jones@linaro.org> Link: https://lore.kernel.org/r/20220123175201.34839-6-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
61 lines
1.3 KiB
C
61 lines
1.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* PCM3168A codec spi driver
|
|
*
|
|
* Copyright (C) 2015 Imagination Technologies Ltd.
|
|
*
|
|
* Author: Damien Horsley <Damien.Horsley@imgtec.com>
|
|
*/
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/module.h>
|
|
#include <linux/spi/spi.h>
|
|
|
|
#include <sound/soc.h>
|
|
|
|
#include "pcm3168a.h"
|
|
|
|
static int pcm3168a_spi_probe(struct spi_device *spi)
|
|
{
|
|
struct regmap *regmap;
|
|
|
|
regmap = devm_regmap_init_spi(spi, &pcm3168a_regmap);
|
|
if (IS_ERR(regmap))
|
|
return PTR_ERR(regmap);
|
|
|
|
return pcm3168a_probe(&spi->dev, regmap);
|
|
}
|
|
|
|
static void pcm3168a_spi_remove(struct spi_device *spi)
|
|
{
|
|
pcm3168a_remove(&spi->dev);
|
|
}
|
|
|
|
static const struct spi_device_id pcm3168a_spi_id[] = {
|
|
{ "pcm3168a", },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(spi, pcm3168a_spi_id);
|
|
|
|
static const struct of_device_id pcm3168a_of_match[] = {
|
|
{ .compatible = "ti,pcm3168a", },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, pcm3168a_of_match);
|
|
|
|
static struct spi_driver pcm3168a_spi_driver = {
|
|
.probe = pcm3168a_spi_probe,
|
|
.remove = pcm3168a_spi_remove,
|
|
.id_table = pcm3168a_spi_id,
|
|
.driver = {
|
|
.name = "pcm3168a",
|
|
.of_match_table = pcm3168a_of_match,
|
|
.pm = &pcm3168a_pm_ops,
|
|
},
|
|
};
|
|
module_spi_driver(pcm3168a_spi_driver);
|
|
|
|
MODULE_DESCRIPTION("PCM3168A SPI codec driver");
|
|
MODULE_AUTHOR("Damien Horsley <Damien.Horsley@imgtec.com>");
|
|
MODULE_LICENSE("GPL v2");
|