Michal Hocko f37a96914d memcg, kmem: fix reference count handling on the error path ...

mem_cgroup_css_online calls mem_cgroup_put if memcg_init_kmem fails.
This is not correct because only memcg_propagate_kmem takes an
additional reference while mem_cgroup_sockets_init is allowed to fail as
well (although no current implementation fails) but it doesn't take any
reference.  This all suggests that it should be memcg_propagate_kmem
that should clean up after itself so this patch moves mem_cgroup_put
over there.

Unfortunately this is not that easy (as pointed out by Li Zefan) because
memcg_kmem_mark_dead marks the group dead (KMEM_ACCOUNTED_DEAD) if it is
marked active (KMEM_ACCOUNTED_ACTIVE) which is the case even if
memcg_propagate_kmem fails so the additional reference is dropped in
that case in kmem_cgroup_destroy which means that the reference would be
dropped two times.

The easiest way then would be to simply remove mem_cgrroup_put from
mem_cgroup_css_online and rely on kmem_cgroup_destroy doing the right
thing.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
Signed-off-by: Li Zefan <lizefan@huawei.com>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Glauber Costa <glommer@openvz.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: <stable@vger.kernel.org>	[3.8]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2013-07-09 10:33:24 -07:00

..

backing-dev.c

drivers: avoid format string in dev_set_name

2013-07-03 16:07:41 -07:00

balloon_compaction.c

mm: introduce a common interface for balloon pages mobility

2012-12-11 17:22:26 -08:00

bootmem.c

mm: kill free_all_bootmem_node()

2013-07-03 16:07:39 -07:00

bounce.c

Merge branch 'for-3.10/core' of git://git.kernel.dk/linux-block

2013-05-08 10:13:35 -07:00

cleancache.c

mm: cleancache: clean up cleancache_enabled

2013-04-30 17:04:01 -07:00

compaction.c

mm: add & use zone_end_pfn() and zone_spans_pfn()

2013-02-23 17:50:20 -08:00

debug-pagealloc.c

mm, x86: Remove debug_pagealloc_enabled

2011-12-06 09:24:07 +01:00

dmapool.c

dmapool: make DMAPOOL_DEBUG detect corruption of free marker

2012-12-11 17:22:24 -08:00

fadvise.c

teach SYSCALL_DEFINE<n> how to deal with long long/unsigned long long

2013-03-03 22:46:22 -05:00

failslab.c

switch debugfs to umode_t

2012-01-03 22:54:56 -05:00

filemap_xip.c

lift sb_start_write() out of ->write()

2013-04-09 14:12:56 -04:00

filemap.c

mm: remove unused VM_<READfoo> macros and expand other in-place

2013-07-09 10:33:23 -07:00

fremap.c

Revert "mm: introduce VM_POPULATE flag to better deal with racy userspace programs"

2013-03-28 17:45:51 -07:00

frontswap.c

frontswap: fix incorrect zeroing and allocation size for frontswap_map

2013-06-12 16:29:46 -07:00

highmem.c

Some nice cleanups, and even a patch my wife did as a "live" demo for

2012-12-20 08:37:05 -08:00

huge_memory.c

Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc

2013-07-04 10:29:23 -07:00

hugetlb_cgroup.c

mm/hugetlb: create hugetlb cgroup file in hugetlb_init

2012-12-18 15:02:15 -08:00

hugetlb.c

mm: correctly update zone->managed_pages

2013-07-03 16:07:33 -07:00

hwpoison-inject.c

memcg: rename config variables

2012-07-31 18:42:43 -07:00

init-mm.c

atomic: use <linux/atomic.h>

2011-07-26 16:49:47 -07:00

internal.h

mm: remove unused __put_page()

2013-07-09 10:33:22 -07:00

interval_tree.c

mm: add CONFIG_DEBUG_VM_RB build option

2012-10-09 16:22:42 +09:00

Kconfig

mm: soft-dirty bits for user memory changes tracking

2013-07-03 16:07:26 -07:00

Kconfig.debug

mm: more intensive memory corruption debugging

2012-01-10 16:30:42 -08:00

kmemcheck.c

kmemcheck: Fix build errors due to missing slab.h

2010-03-30 22:02:32 +09:00

kmemleak-test.c

kmemleak: remove memset by using kzalloc

2011-01-27 18:31:51 +00:00

kmemleak.c

hlist: drop the node parameter from iterators

2013-02-27 19:10:24 -08:00

ksm.c

ksm: fix m68k build: only NUMA needs pfn_to_nid

2013-03-08 15:05:34 -08:00

maccess.c

mm: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

madvise.c

mm: madvise: complete input validation before taking lock

2013-04-29 15:54:37 -07:00

Makefile

memcg: add memory.pressure_level events

2013-04-29 15:54:38 -07:00

memblock.c

mm/memblock.c: fix wrong comment in __next_free_mem_range()

2013-07-09 10:33:23 -07:00

memcontrol.c

memcg, kmem: fix reference count handling on the error path

2013-07-09 10:33:24 -07:00

memory_hotplug.c

mm/memory_hotplug.c: fix a comment typo in register_page_bootmem_info_node()

2013-07-09 10:33:23 -07:00

memory-failure.c

mm/memory-failure.c: fix memory leak in successful soft offlining

2013-07-03 16:07:31 -07:00

memory.c

mm: remove unused VM_<READfoo> macros and expand other in-place

2013-07-09 10:33:23 -07:00

mempolicy.c

mm/mempolicy.c: fix sp_node_init() argument ordering

2013-03-08 15:05:34 -08:00

mempool.c

mempool: add @gfp_mask to mempool_create_node()

2012-06-25 11:53:47 +02:00

migrate.c

mm: migration: add migrate_entry_wait_huge()

2013-06-12 16:29:46 -07:00

mincore.c

swap: make each swap partition have one address_space

2013-02-23 17:50:17 -08:00

mlock.c

Revert "mm: introduce VM_POPULATE flag to better deal with racy userspace programs"

2013-03-28 17:45:51 -07:00

mm_init.c

mm: tune vm_committed_as percpu_counter batching size

2013-07-03 16:07:32 -07:00

mmap.c

mmap: allow MAP_HUGETLB for hugetlbfs files v2

2013-07-09 10:33:24 -07:00

mmu_context.c

mm: remove old aio use_mm() comment

2013-05-07 18:38:27 -07:00

mmu_notifier.c

treewide: relase -> release

2013-06-28 14:34:33 +02:00

mmzone.c

mm: rename page struct field helpers

2013-02-23 17:50:18 -08:00

mprotect.c

mm/mprotect.c: coding-style cleanups

2012-12-18 15:02:15 -08:00

mremap.c

mm: mremap: validate input before taking lock

2013-07-09 10:33:20 -07:00

msync.c

sanitize vfs_fsync calling conventions

2010-05-21 18:31:21 -04:00

nobootmem.c

mm: concentrate modification of totalram_pages into the mm core

2013-07-03 16:07:33 -07:00

nommu.c

mm: kill global variable num_physpages

2013-07-03 16:07:38 -07:00

oom_kill.c

memcg, oom: provide more precise dump info while memcg oom happening

2013-02-23 17:50:08 -08:00

page_alloc.c

mm/page_alloc.c: remove unlikely() from the current_order test

2013-07-09 10:33:22 -07:00

page_cgroup.c

memcontrol: use N_MEMORY instead N_HIGH_MEMORY

2012-12-12 17:38:32 -08:00

page_io.c

mm: remove compressed copy from zram in-memory

2013-07-03 16:07:26 -07:00

page_isolation.c

mm: fix zone_watermark_ok_safe() accounting of isolated pages

2013-01-04 16:11:46 -08:00

page-writeback.c

mm: make snapshotting pages for stable writes a per-bio operation

2013-04-29 15:54:33 -07:00

pagewalk.c

mm/pagewalk.c: walk_page_range should avoid VM_PFNMAP areas

2013-05-24 16:22:53 -07:00

percpu-km.c

percpu: clear memory allocated with the km allocator

2010-10-02 10:28:42 +03:00

percpu-vm.c

mm: fix kernel-doc warnings

2012-06-20 14:39:36 -07:00

percpu.c

mm, percpu: Make sure percpu_alloc early parameter has an argument

2012-12-02 06:23:04 -08:00

pgtable-generic.c

mm/THP: add pmd args to pgtable deposit and withdraw APIs

2013-06-20 16:55:07 +10:00

process_vm_access.c

Fix: compat_rw_copy_check_uvector() misuse in aio, readv, writev, and security keys

2013-03-12 11:05:45 -07:00

quicklist.c

mm: delete various needless include <linux/module.h>

2011-10-31 09:20:11 -04:00

readahead.c

mm: change invalidatepage prototype to accept length

2013-05-21 23:17:23 -04:00

rmap.c

mm: remove unused VM_<READfoo> macros and expand other in-place

2013-07-09 10:33:23 -07:00

shmem.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security

2013-07-03 14:04:58 -07:00

slab_common.c

slab: prevent warnings when allocating with __GFP_NOWARN

2013-06-13 10:01:58 +03:00

slab.c

Merge branch 'slab/for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux

2013-05-07 08:42:20 -07:00

slab.h

slab: Common definition for kmem_cache_node

2013-02-01 12:32:09 +02:00

slob.c

mm: rename page struct field helpers

2013-02-23 17:50:18 -08:00

slub.c

Merge branch 'slab/for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux

2013-05-07 08:42:20 -07:00

sparse-vmemmap.c

sparse-vmemmap: specify vmemmap population range in bytes

2013-04-29 15:54:35 -07:00

sparse.c

mm/sparse.c: put clear_hwpoisoned_pages within CONFIG_MEMORY_HOTREMOVE

2013-07-09 10:33:22 -07:00

swap_state.c

swap: avoid read_swap_cache_async() race to deadlock while waiting on discard I/O completion

2013-06-12 16:29:45 -07:00

swap.c

mm: remove lru parameter from __lru_cache_add and lru_cache_add_lru

2013-07-03 16:07:31 -07:00

swapfile.c

swap: discard while swapping only if SWAP_FLAG_DISCARD_PAGES

2013-07-03 16:07:32 -07:00

truncate.c

mm: teach truncate_inode_pages_range() to handle non page aligned ranges

2013-05-27 23:32:35 -04:00

util.c

swap: make each swap partition have one address_space

2013-02-23 17:50:17 -08:00

vmalloc.c

mm/vmalloc.c: fix an overflow bug in alloc_vmap_area()

2013-07-09 10:33:23 -07:00

vmpressure.c

memcg: add memory.pressure_level events

2013-04-29 15:54:38 -07:00

vmscan.c

mm: vmscan: do not scale writeback pages when deciding whether to set ZONE_WRITEBACK

2013-07-09 10:33:23 -07:00

vmstat.c

mm/vmstat: add note on safety of drain_zonestat

2013-04-29 15:54:38 -07:00