iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Paulo Alcantara (SUSE) f93743a333 cifs: Fix memory allocation in __smb2_handle_cancelled_cmd() 
commit 0a5a98863c9debc02387b3d23c46d187756f5e2b upstream.

__smb2_handle_cancelled_cmd() is called under a spin lock held in
cifs_mid_q_entry_release(), so make its memory allocation GFP_ATOMIC.

This issue was observed when running xfstests generic/028:

[ 1722.589204] CIFS VFS: \\192.168.30.26 Cancelling wait for mid 72064 cmd: 5
[ 1722.590687] CIFS VFS: \\192.168.30.26 Cancelling wait for mid 72065 cmd: 17
[ 1722.593529] CIFS VFS: \\192.168.30.26 Cancelling wait for mid 72066 cmd: 6
[ 1723.039014] BUG: sleeping function called from invalid context at mm/slab.h:565
[ 1723.040710] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 30877, name: cifsd
[ 1723.045098] CPU: 3 PID: 30877 Comm: cifsd Not tainted 5.5.0-rc4+ #313
[ 1723.046256] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.12.0-59-gc9ba527-rebuilt.opensuse.org 04/01/2014
[ 1723.048221] Call Trace:
[ 1723.048689]  dump_stack+0x97/0xe0
[ 1723.049268]  ___might_sleep.cold+0xd1/0xe1
[ 1723.050069]  kmem_cache_alloc_trace+0x204/0x2b0
[ 1723.051051]  __smb2_handle_cancelled_cmd+0x40/0x140 [cifs]
[ 1723.052137]  smb2_handle_cancelled_mid+0xf6/0x120 [cifs]
[ 1723.053247]  cifs_mid_q_entry_release+0x44d/0x630 [cifs]
[ 1723.054351]  ? cifs_reconnect+0x26a/0x1620 [cifs]
[ 1723.055325]  cifs_demultiplex_thread+0xad4/0x14a0 [cifs]
[ 1723.056458]  ? cifs_handle_standard+0x2c0/0x2c0 [cifs]
[ 1723.057365]  ? kvm_sched_clock_read+0x14/0x30
[ 1723.058197]  ? sched_clock+0x5/0x10
[ 1723.058838]  ? sched_clock_cpu+0x18/0x110
[ 1723.059629]  ? lockdep_hardirqs_on+0x17d/0x250
[ 1723.060456]  kthread+0x1ab/0x200
[ 1723.061149]  ? cifs_handle_standard+0x2c0/0x2c0 [cifs]
[ 1723.062078]  ? kthread_create_on_node+0xd0/0xd0
[ 1723.062897]  ret_from_fork+0x3a/0x50

Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Fixes: 9150c3adbf24 ("CIFS: Close open handle after interrupted close")
Cc: Stable <stable@vger.kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-02-01 09:37:04 +00:00
..
9p
9p: avoid attaching writeback_fid on mmap with type PRIVATE
2019-10-11 18:21:13 +02:00
adfs
fs/adfs: super: fix use-after-free bug
2019-08-06 19:06:49 +02:00
affs
affs: fix a memory leak in affs_remount
2020-01-27 14:51:21 +01:00
afs
afs: Fix characters allowed into cell names
2020-01-29 16:43:18 +01:00
autofs
autofs: fix a leak in autofs_expire_indirect()
2019-12-13 08:51:01 +01:00
befs
…
bfs
bfs: add sanity check at bfs_fill_super()
2018-12-01 09:37:27 +01:00
btrfs
btrfs: use correct count in btrfs_file_write_iter()
2020-01-27 14:51:12 +01:00
cachefiles
fscache, cachefiles: remove redundant variable 'cache'
2018-12-17 09:24:40 +01:00
ceph
ceph: fix "ceph.dir.rctime" vxattr value
2020-01-27 14:51:00 +01:00
cifs
cifs: Fix memory allocation in __smb2_handle_cancelled_cmd()
2020-02-01 09:37:04 +00:00
coda
coda: add error handling for fget
2019-08-06 19:06:51 +02:00
configfs
configfs: fix a deadlock in configfs_symlink()
2019-11-12 19:20:47 +01:00
cramfs
Cramfs: fix abad comparison when wrap-arounds occur
2018-11-13 11:08:55 -08:00
crypto
fscrypt: clean up some BUG_ON()s in block encryption/decryption
2019-07-26 09:14:02 +02:00
debugfs
debugfs: fix use-after-free on symlink traversal
2019-05-08 07:21:48 +02:00
devpts
fs/devpts: always delete dcache dentry-s in dput()
2019-03-23 20:09:59 +01:00
dlm
dlm: fix invalid cluster name warning
2019-12-13 08:52:23 +01:00
ecryptfs
ecryptfs_lookup_interpose(): lower_dentry->d_parent is not stable either
2019-11-20 18:45:18 +01:00
efivarfs
efivars: Call guid_parse() against guid_t type of variable
2018-07-22 14:13:44 +02:00
efs
…
exofs
exofs_mount(): fix leaks on failure exits
2019-12-05 09:20:32 +01:00
exportfs
exportfs: fix 'passing zero to ERR_PTR()' warning
2020-01-27 14:50:02 +01:00
ext2
ext2: check err when partial != NULL
2019-12-17 20:35:18 +01:00
ext4
ext4: set error return correctly when ext4_htree_store_dirent fails
2020-01-27 14:51:03 +01:00
f2fs
f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()
2020-01-27 14:51:13 +01:00
fat
fat: work around race with userspace's read via blockdev while mounting
2019-10-07 18:57:14 +02:00
freevxfs
…
fscache
fscache: fix race between enablement and dropping of object
2018-12-17 09:24:40 +01:00
fuse
fuse: verify attributes
2019-12-13 08:52:36 +01:00
gfs2
gfs2: fix glock reference problem in gfs2_trans_remove_revoke
2019-12-17 20:35:55 +01:00
hfs
fs/hfs/extent.c: fix array out of bounds read of array extent
2019-12-01 09:17:10 +01:00
hfsplus
hfsplus: update timestamps on truncate()
2019-12-01 09:17:09 +01:00
hostfs
vfs: discard ATTR_ATTR_FLAG
2018-08-17 16:20:28 -07:00
hpfs
hpfs: remove unnecessary checks on the value of r when assigning error code
2018-08-25 12:42:33 -07:00
hugetlbfs
hugetlb: use same fault hash key for shared and private mappings
2019-05-22 07:37:40 +02:00
isofs
isofs: reject hardware sector size > 2048 bytes
2018-08-21 11:37:41 +02:00
jbd2
jbd2: Fix statistics for the number of logged blocks
2020-01-04 19:12:48 +01:00
jffs2
jffs2: fix use-after-free on symlink traversal
2019-05-08 07:21:48 +02:00
jfs
jfs: fix bogus variable self-initialization
2020-01-27 14:50:33 +01:00
kernfs
kernfs: fix ino wrap-around detection
2019-12-13 08:52:43 +01:00
lockd
lockd: fix decoding of TEST results
2019-12-13 08:51:59 +01:00
minix
…
nfs
NFS: Don't interrupt file writeout due to fatal errors
2020-01-27 14:50:41 +01:00
nfs_common
…
nfsd
nfsd4: fix up replay_matches_cache()
2020-01-09 10:19:03 +01:00
nilfs2
nilfs2: convert to SPDX license tags
2018-09-04 16:45:02 -07:00
nls
…
notify
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:17:20 +01:00
ntfs
ntfs: mft: remove VLA usage
2018-08-17 16:20:27 -07:00
ocfs2
ocfs2: call journal flush to mark journal as empty after journal recovery when mount
2020-01-17 19:47:17 +01:00
omfs
…
openpromfs
…
orangefs
orangefs: rate limit the client not running info message
2019-11-24 08:20:57 +01:00
overlayfs
ovl: relax WARN_ON() on rename to self
2019-12-17 20:34:51 +01:00
proc
mm, thp, proc: report THP eligibility for each vma
2019-12-17 20:35:45 +01:00
pstore
pstore/ram: Write new dumps to start of recycled zones
2020-01-09 10:19:00 +01:00
qnx4
…
qnx6
…
quota
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:17:20 +01:00
ramfs
…
reiserfs
reiserfs: fix handling of -EOPNOTSUPP in reiserfs_for_each_xattr
2020-01-23 08:21:38 +01:00
romfs
…
squashfs
Squashfs: Compute expected length from inode size rather than block length
2018-08-02 09:34:02 -07:00
sysfs
Driver core patches for 4.19-rc1
2018-08-18 11:44:53 -07:00
sysv
sysv: return 'err' instead of 0 in __sysv_write_inode
2018-12-17 09:24:30 +01:00
tracefs
tracefs: Annotate tracefs_ops with __ro_after_init
2018-07-31 11:32:44 -04:00
ubifs
ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps
2020-01-09 10:19:09 +01:00
udf
udf: Fix crash during mount
2019-11-20 18:46:04 +01:00
ufs
ufs: fix braino in ufs_get_inode_gid() for solaris UFS flavour
2019-05-25 18:23:46 +02:00
xfs
xfs: Sanity check flags of Q_XQUOTARM call
2020-01-27 14:49:51 +01:00
aio.c
Fix aio_poll() races
2019-05-02 09:58:59 +02:00
anon_inodes.c
anon_inode_getfile(): switch to alloc_file_pseudo()
2018-07-12 10:04:27 -04:00
attr.c
…
bad_inode.c
get rid of 'opened' argument of ->atomic_open() - part 3
2018-07-12 10:04:20 -04:00
binfmt_aout.c
…
binfmt_elf_fdpic.c
…
binfmt_elf.c
binfmt_elf: Do not move brk for INTERP-less ET_EXEC
2019-10-05 13:10:06 +02:00
binfmt_em86.c
…
binfmt_flat.c
fs/binfmt_flat.c: make load_flat_shared_library() work
2019-07-03 13:14:44 +02:00
binfmt_misc.c
…
binfmt_script.c
exec: load_script: Do not exec truncated interpreter path
2019-11-06 13:05:37 +01:00
block_dev.c
bdev: Refresh bdev size for disks without partitioning
2020-01-09 10:19:07 +01:00
buffer.c
fs: fix guard_bio_eod to check for real EOD errors
2019-04-05 22:33:00 +02:00
char_dev.c
chardev: Avoid potential use-after-free in 'chrdev_open()'
2020-01-14 20:06:57 +01:00
compat_binfmt_elf.c
…
compat_ioctl.c
fix compat handling of FICLONERANGE, FIDEDUPERANGE and FS_IOC_FIEMAP
2020-01-09 10:19:07 +01:00
compat.c
…
coredump.c
…
d_path.c
…
dax.c
dax: dax_layout_busy_page() should not unmap cow pages
2019-08-16 10:12:52 +02:00
dcache.c
dcache: sort the freeing-without-RCU-delay mess for good.
2019-05-25 18:23:26 +02:00
dcookies.c
…
direct-io.c
direct-io: allow direct writes to empty inodes
2019-03-05 17:58:50 +01:00
drop_caches.c
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:17:20 +01:00
eventfd.c
…
eventpoll.c
fs/epoll: drop ovflist branch prediction
2019-02-12 19:47:19 +01:00
exec.c
sched/fair: Don't free p->numa_faults with concurrent readers
2019-08-04 09:30:56 +02:00
fcntl.c
signal: Don't send signals to tasks that don't exist
2018-08-15 23:03:20 -05:00
fhandle.c
…
file_table.c
overlayfs update for 4.19
2018-08-21 18:19:09 -07:00
file.c
fs/file.c: initialize init_files.resize_wait
2019-04-05 22:32:59 +02:00
filesystems.c
…
fs_pin.c
…
fs_struct.c
…
fs-writeback.c
cgroup,writeback: don't switch wbs immediately on dead wbs if the memcg is dead
2019-11-12 19:21:20 +01:00
inode.c
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:17:20 +01:00
internal.h
acct_on(): don't mess with freeze protection
2019-05-31 06:46:05 -07:00
ioctl.c
vfs: fix FIGETBSZ ioctl on an overlayfs file
2018-11-21 09:19:14 +01:00
iomap.c
iomap: partially revert 4721a601099 (simulated directio short read on EFAULT)
2019-12-13 08:52:56 +01:00
Kconfig
…
Kconfig.binfmt
kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt
2018-08-02 08:06:55 +09:00
libfs.c
Fix the locking in dcache_readdir() and friends
2019-10-17 13:45:35 -07:00
locks.c
locks: print unsigned ino in /proc/locks
2020-01-09 10:19:00 +01:00
Makefile
…
mbcache.c
…
mount.h
…
mpage.c
mpage: mpage_readpages() should submit IO as read-ahead
2018-08-17 16:20:29 -07:00
namei.c
do_last(): fetch directory ->i_mode and ->i_uid before it's too late
2020-01-29 16:43:21 +01:00
namespace.c
mnt: fix __detach_mounts infinite loop
2018-11-21 09:19:22 +01:00
no-block.c
…
nsfs.c
dcache: sort the freeing-without-RCU-delay mess for good.
2019-05-25 18:23:26 +02:00
open.c
access: avoid the RCU grace period for the temporary subjective credentials
2019-07-31 07:27:11 +02:00
pipe.c
fs: prevent page refcount overflow in pipe_buf_get
2019-05-04 09:20:11 +02:00
pnode.c
…
pnode.h
…
posix_acl.c
…
proc_namespace.c
…
read_write.c
vfs: avoid problematic remapping requests into partial EOF block
2019-12-01 09:17:04 +01:00
readdir.c
filldir[64]: remove WARN_ON_ONCE() for bad directory entries
2020-01-04 19:13:26 +01:00
select.c
…
seq_file.c
seq_file: fix problem when seeking mid-record
2019-08-25 10:47:43 +02:00
signalfd.c
…
splice.c
splice: only read in as much information as there is pipe buffer space
2019-12-17 20:35:43 +01:00
stack.c
…
stat.c
…
statfs.c
vfs: Fix EOVERFLOW testing in put_compat_statfs64
2019-10-11 18:21:39 +02:00
super.c
Merge branch 'ida-4.19' of git://git.infradead.org/users/willy/linux-dax
2018-08-26 11:48:42 -07:00
sync.c
…
timerfd.c
Merge branch 'work.aio' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-08-13 20:56:23 -07:00
userfaultfd.c
userfaultfd: require CAP_SYS_PTRACE for UFFD_FEATURE_EVENT_FORK
2020-01-04 19:13:18 +01:00
utimes.c
…
xattr.c
sysfs: Do not return POSIX ACL xattrs via listxattr
2018-09-18 07:30:48 -04:00