iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/scsi
History
Giridhar Malavali f3e0269517 scsi: qla2xxx: Avoid PCI IRQ affinity mapping when multiqueue is not supported 
This patch fixes warning seen when BLK-MQ is enabled and hardware does not
support MQ. This will result into driver requesting MSIx vectors which are
equal or less than pre_desc via PCI IRQ Affinity infrastructure.

    [   19.746300] qla2xxx [0000:00:00.0]-0005: : QLogic Fibre Channel HBA Driver: 10.00.00.12-k.
    [   19.746599] qla2xxx [0000:02:00.0]-001d: : Found an ISP2432 irq 18 iobase 0x(____ptrval____).
    [   20.203186] ------------[ cut here ]------------
    [   20.203306] WARNING: CPU: 8 PID: 268 at drivers/pci/msi.c:1273 pci_irq_get_affinity+0xf4/0x120
    [   20.203481] Modules linked in: tg3 ptp qla2xxx(+) pps_core sg libphy scsi_transport_fc flash loop autofs4
    [   20.203700] CPU: 8 PID: 268 Comm: systemd-udevd Not tainted 5.0.0-rc5-00358-gdf3865f #113
    [   20.203830] Call Trace:
    [   20.203933]  [0000000000461bb0] __warn+0xb0/0xe0
    [   20.204090]  [00000000006c8f34] pci_irq_get_affinity+0xf4/0x120
    [   20.204219]  [000000000068c764] blk_mq_pci_map_queues+0x24/0x120
    [   20.204396]  [00000000007162f4] scsi_map_queues+0x14/0x40
    [   20.204626]  [0000000000673654] blk_mq_update_queue_map+0x94/0xe0
    [   20.204698]  [0000000000676ce0] blk_mq_alloc_tag_set+0x120/0x300
    [   20.204869]  [000000000071077c] scsi_add_host_with_dma+0x7c/0x300
    [   20.205419]  [00000000100ead54] qla2x00_probe_one+0x19d4/0x2640 [qla2xxx]
    [   20.205621]  [00000000006b3c88] pci_device_probe+0xc8/0x160
    [   20.205697]  [0000000000701c0c] really_probe+0x1ac/0x2e0
    [   20.205770]  [0000000000701f90] driver_probe_device+0x50/0x100
    [   20.205843]  [0000000000702134] __driver_attach+0xf4/0x120
    [   20.205913]  [0000000000700644] bus_for_each_dev+0x44/0x80
    [   20.206081]  [0000000000700c98] bus_add_driver+0x198/0x220
    [   20.206300]  [0000000000702950] driver_register+0x70/0x120
    [   20.206582]  [0000000010248224] qla2x00_module_init+0x224/0x284 [qla2xxx]
    [   20.206857] ---[ end trace b1de7a3f79fab2c2 ]---

The fix is to check if the hardware does not have Multi Queue capabiltiy,
use pci_alloc_irq_vectors() call instead of pci_alloc_irq_affinity().

Fixes: f664a3cc17b7d ("scsi: kill off the legacy IO path")
Cc: stable@vger.kernel.org #4.19
Signed-off-by: Giridhar Malavali <gmalavali@marvell.com>
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2019-02-19 18:58:38 -05:00
..
aacraid
scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template
2019-02-08 17:33:00 -05:00
aic7xxx
scsi: remove unneeded header search paths
2019-01-29 01:22:21 -05:00
aic94xx
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
arcmsr
scsi: arcmsr: Update driver version to v1.40.00.10-20190116
2019-01-22 21:38:21 -05:00
arm
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
be2iscsi
scsi: introduce a max_segment_size host_template parameters
2018-12-18 23:13:12 -05:00
bfa
scsi: bfa: no need to check return value of debugfs_create functions
2019-01-29 00:40:40 -05:00
bnx2fc
SCSI misc on 20181224
2018-12-28 14:48:06 -08:00
bnx2i
scsi: bnx2i: fix indentation issue, remove a tab
2019-01-08 22:31:36 -05:00
csiostor
scsi: csiostor: Remove set but not used variable 'pln'
2019-02-01 18:19:56 -05:00
cxgbi
scsi: remove bidirectional command support
2019-02-05 21:29:21 -05:00
cxlflash
scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template
2019-02-08 17:33:00 -05:00
device_handler
scsi: return blk_status_t from device handler ->prep_fn
2018-11-09 19:17:14 -07:00
dpt
…
esas2r
scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template
2019-02-08 17:33:00 -05:00
fcoe
scsi: fcoe: remove unneeded fcoe_ctlr_destroy_store export
2019-01-29 00:30:50 -05:00
fnic
scsi: fnic: Remove set but not used variable 'vdev'
2019-01-29 01:16:09 -05:00
hisi_sas
scsi: hisi_sas: Do some more tidy-up
2019-02-08 18:08:22 -05:00
ibmvscsi
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
ibmvscsi_tgt
scsi: target/core: Remove the write_pending_status() callback function
2019-02-04 21:23:59 -05:00
isci
scsi: isci: request: mark expected switch fall-through
2018-12-20 20:03:56 -05:00
libfc
scsi: libfc: fc_rport: Mark expected switch fall-through
2018-11-28 21:47:30 -05:00
libsas
scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template
2019-02-08 17:33:00 -05:00
lpfc
scsi: lpfc: Remove set but not used variable 'phys_id'
2019-02-19 18:58:34 -05:00
megaraid
scsi: megaraid_sas: driver version update
2019-02-12 22:20:41 -05:00
mpt3sas
scsi: mpt3sas: Update driver version to 27.102.00.00
2019-02-04 22:52:21 -05:00
mvsas
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
pcmcia
scsi: pcmcia: nsp_cs: Remove unnecessary parentheses
2019-01-29 01:28:49 -05:00
pm8001
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
qedf
scsi: stop setting up request->special
2019-02-05 21:29:49 -05:00
qedi
scsi: stop setting up request->special
2019-02-05 21:29:49 -05:00
qla2xxx
scsi: qla2xxx: Avoid PCI IRQ affinity mapping when multiqueue is not supported
2019-02-19 18:58:38 -05:00
qla4xxx
scsi: qla4xxx: ql4_os: mark expected switch fall-through
2019-01-11 21:05:03 -05:00
smartpqi
scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template
2019-02-08 17:33:00 -05:00
snic
scsi: snic: no need to check return value of debugfs_create functions
2019-01-29 00:40:54 -05:00
sym53c8xx_2
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
ufs
scsi: ufs: Add HI3670 SoC UFS driver support
2019-02-19 18:58:34 -05:00
.gitignore
…
3w-9xxx.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
3w-9xxx.h
…
3w-sas.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
3w-sas.h
…
3w-xxxx.c
scsi: 3w-xxxx: fix indentation issue, add missing tab
2018-12-19 21:54:07 -05:00
3w-xxxx.h
scsi: 3w-xxx: fully convert to the generic DMA API
2018-10-17 21:58:51 -04:00
53c700_d.h_shipped
…
53c700.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
53c700.h
scsi: 53c700: Fix spelling of 'NEGOTIATION'
2018-08-30 07:27:22 -04:00
53c700.scr
…
a100u2w.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
a100u2w.h
…
a2091.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
a2091.h
…
a3000.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
a3000.h
…
a4000t.c
…
advansys.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
aha152x.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
aha152x.h
…
aha1542.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
aha1542.h
…
aha1740.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
aha1740.h
scsi: core: remove Scsi_Cmnd typedef
2018-06-19 22:02:25 -04:00
am53c974.c
scsi: esp_scsi: move dma mapping into the core code
2018-10-15 23:00:38 -04:00
atari_scsi.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
atp870u.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
atp870u.h
…
BusLogic.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
BusLogic.h
…
bvme6000_scsi.c
…
ch.c
scsi: core: check for equality of result byte values
2018-06-26 12:27:06 -04:00
constants.c
…
dc395x.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
dc395x.h
…
dmx3191d.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
dpt_i2o.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
dpti.h
scsi: dpt_i2o: stop using scsi_unregister
2018-03-15 00:25:37 -04:00
esp_scsi.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
esp_scsi.h
scsi: esp_scsi: De-duplicate PIO routines
2018-10-17 21:38:20 -04:00
FlashPoint.c
scsi: FlashPoint: Remove unnecessary parentheses
2018-09-25 20:45:53 -04:00
g_NCR5380.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
gdth_ioctl.h
scsi: gdth: remove dead code under #ifdef GDTH_IOCTL_PROC
2019-01-08 21:58:35 -05:00
gdth_proc.c
scsi: gdth: use generic DMA API
2019-01-08 21:58:35 -05:00
gdth_proc.h
scsi: gdth: remove gdth_{alloc,free}_ioctl
2019-01-08 21:57:42 -05:00
gdth.c
scsi: gdth: use generic DMA API
2019-01-08 21:58:35 -05:00
gdth.h
scsi: gdth: remove ISA and EISA support
2019-01-08 21:58:35 -05:00
gvp11.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
gvp11.h
…
hosts.c
SCSI misc on 20181224
2018-12-28 14:48:06 -08:00
hpsa_cmd.h
…
hpsa.c
scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template
2019-02-08 17:33:00 -05:00
hpsa.h
scsi: hpsa: correct enclosure sas address
2018-07-10 22:25:03 -04:00
hptiop.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
hptiop.h
…
imm.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
imm.h
…
initio.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
initio.h
…
ipr.c
scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template
2019-02-08 17:33:00 -05:00
ipr.h
scsi: ipr: System hung while dlpar adding primary ipr adapter back
2018-09-21 12:35:39 -04:00
ips.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
ips.h
scsi: ips: properly handle 64-bit DMA
2018-11-06 21:31:28 -05:00
iscsi_boot_sysfs.c
…
iscsi_tcp.c
scsi: remove bidirectional command support
2019-02-05 21:29:21 -05:00
iscsi_tcp.h
…
jazz_esp.c
scsi: esp_scsi: move dma mapping into the core code
2018-10-15 23:00:38 -04:00
Kconfig
scsi: remove the SCSI OSD library
2019-02-05 21:28:52 -05:00
lasi700.c
…
libiscsi_tcp.c
scsi: remove bidirectional command support
2019-02-05 21:29:21 -05:00
libiscsi.c
scsi: libiscsi: Use scsi_[gs]et_resid() where appropriate
2019-02-12 11:13:41 -05:00
mac53c94.c
scsi: mac53c94: remove DISABLE_CLUSTERING
2018-12-18 23:13:12 -05:00
mac53c94.h
…
mac_esp.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
mac_scsi.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
Makefile
scsi: remove the SCSI OSD library
2019-02-05 21:28:52 -05:00
megaraid.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
megaraid.h
scsi: core: remove Scsi_Cmnd typedef
2018-06-19 22:02:25 -04:00
mesh.c
scsi: mesh: remove DISABLE_CLUSTERING
2018-12-18 23:13:12 -05:00
mesh.h
…
mvme16x_scsi.c
…
mvme147.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
mvme147.h
…
mvumi.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
mvumi.h
…
myrb.c
SCSI misc on 20181224
2018-12-28 14:48:06 -08:00
myrb.h
scsi: myrb: Add Mylex RAID controller (block interface)
2018-10-17 21:06:49 -04:00
myrs.c
scsi: myrs: remove the dma_boundary_limit
2018-12-19 21:43:30 -05:00
myrs.h
scsi: myrs: Add Mylex RAID controller (SCSI interface)
2018-10-17 21:07:54 -04:00
ncr53c8xx.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
ncr53c8xx.h
…
NCR5380.c
scsi: NCR5380: Return false instead of NULL
2018-11-05 22:47:38 -05:00
NCR5380.h
scsi: NCR5380: Have NCR5380_select() return a bool
2018-09-28 02:17:51 -04:00
nsp32_debug.c
scsi: core: remove Scsi_Cmnd typedef
2018-06-19 22:02:25 -04:00
nsp32_io.h
…
nsp32.c
scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry
2019-01-29 01:26:57 -05:00
nsp32.h
…
osst_detect.h
…
osst_options.h
…
osst.c
block: remove __blk_put_request()
2018-11-07 13:42:32 -07:00
osst.h
…
pmcraid.c
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
pmcraid.h
scsi: pmcraid: Use sgl_alloc_order() and sgl_free_order()
2018-02-13 21:49:15 -05:00
ppa.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
ppa.h
…
ps3rom.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
qla1280.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
qla1280.h
…
qlogicfas408.c
…
qlogicfas408.h
…
qlogicfas.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
qlogicpti.c
scsi: qlogicpti: Use of_node_name_eq for node name comparisons
2019-02-13 22:07:03 -05:00
qlogicpti.h
scsi: qlogicpti: Use of_node_name_eq for node name comparisons
2019-02-13 22:07:03 -05:00
raid_class.c
scsi: raid_attrs: fix unused variable warning
2018-08-30 07:21:04 -04:00
script_asm.pl
…
scsi_common.c
scsi: core: doc. fixes to scsi_common.c
2017-12-11 21:39:39 -05:00
scsi_debug.c
scsi: scsi_debug: Implement support for write protect
2019-02-12 11:15:44 -05:00
scsi_debugfs.c
scsi: devinfo: use const_ilog2 for array indices
2018-04-20 19:14:28 -04:00
scsi_debugfs.h
…
scsi_devinfo.c
scsi: devinfo: BLIST_RETRY_ASC_C1 for Fujitsu ETERNUS
2018-04-20 19:14:36 -04:00
scsi_dh.c
scsi: scsi_dh: replace too broad "TP9" string with the exact models
2018-04-18 19:34:08 -04:00
scsi_error.c
scsi: remove bidirectional command support
2019-02-05 21:29:21 -05:00
scsi_ioctl.c
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
scsi_lib_dma.c
…
scsi_lib.c
scsi: core: Move resid from scsi_data_buffer to scsi_cmnd
2019-02-12 11:13:41 -05:00
scsi_logging.c
…
scsi_logging.h
…
scsi_netlink.c
…
scsi_pm.c
block: Move power management code into a new source file
2018-09-26 15:11:28 -06:00
scsi_priv.h
scsi: kill off the legacy IO path
2018-11-07 13:42:32 -07:00
scsi_proc.c
…
scsi_sas_internal.h
…
scsi_scan.c
scsi: kill off the legacy IO path
2018-11-07 13:42:32 -07:00
scsi_sysctl.c
…
scsi_sysfs.c
scsi: kill off the legacy IO path
2018-11-07 13:42:32 -07:00
scsi_trace.c
…
scsi_transport_api.h
…
scsi_transport_fc.c
bsg: convert to use blk-mq
2018-11-07 13:42:32 -07:00
scsi_transport_iscsi.c
SCSI misc on 20181224
2018-12-28 14:48:06 -08:00
scsi_transport_sas.c
scsi: bsg-lib: handle bidi requests without block layer help
2019-02-05 21:27:40 -05:00
scsi_transport_spi.c
scsi: core: check for equality of result byte values
2018-06-26 12:27:06 -04:00
scsi_transport_srp.c
for-4.18/block-20180603
2018-06-04 07:58:06 -07:00
scsi.c
scsi: kill off the legacy IO path
2018-11-07 13:42:32 -07:00
scsi.h
scsi: core: remove Scsi_Cmnd typedef
2018-06-19 22:02:25 -04:00
scsicam.c
…
sd_dif.c
block: move dif_prepare/dif_complete functions to block layer
2018-07-30 08:27:02 -06:00
sd_zbc.c
scsi: return blk_status_t from scsi_init_io and ->init_command
2018-11-09 19:17:14 -07:00
sd.c
scsi: sd: Remove superfluous residual assignments
2019-02-12 11:13:41 -05:00
sd.h
scsi: sd: Fix typo in sd_first_printk()
2019-02-12 22:33:00 -05:00
sense_codes.h
…
ses.c
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
sg.c
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
sgiwd93.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
sim710.c
…
sni_53c710.c
…
sr_ioctl.c
block: Switch struct packet_command to use struct scsi_sense_hdr
2018-08-02 15:22:13 -06:00
sr_vendor.c
…
sr.c
scsi: stop setting up request->special
2019-02-05 21:29:49 -05:00
sr.h
…
st_options.h
…
st.c
scsi: st: mark expected switch fall-throughs
2019-01-11 21:41:24 -05:00
st.h
…
stex.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
storvsc_drv.c
SCSI misc on 20181224
2018-12-28 14:48:06 -08:00
sun3_scsi_vme.c
…
sun3_scsi.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
sun3x_esp.c
scsi: esp_scsi: move dma mapping into the core code
2018-10-15 23:00:38 -04:00
sun_esp.c
scsi: sun_esp: Use of_node_name_eq for node name comparisons
2018-12-07 21:56:06 -05:00
virtio_scsi.c
scsi: remove bidirectional command support
2019-02-05 21:29:21 -05:00
vmw_pvscsi.c
SCSI misc on 20181224
2018-12-28 14:48:06 -08:00
vmw_pvscsi.h
…
wd33c93.c
…
wd33c93.h
…
wd719x.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
wd719x.h
scsi: wd719x: use per-command private data
2018-11-15 14:27:08 -05:00
xen-scsifront.c
scsi: xen-scsifront: remove DISABLE_CLUSTERING
2018-12-18 23:13:12 -05:00
zalon.c
…
zorro7xx.c
…
zorro_esp.c
scsi: esp_scsi: De-duplicate PIO routines
2018-10-17 21:38:20 -04:00