iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
f418bfabea43325f306276226f64ebc7de1b7d56
linux/net/sched
History
Eric Dumazet 9bb363ba01 net_sched: add __rcu annotation to netdev->qdisc 
commit 5891cd5ec4 upstream.

syzbot found a data-race [1] which lead me to add __rcu
annotations to netdev->qdisc, and proper accessors
to get LOCKDEP support.

[1]
BUG: KCSAN: data-race in dev_activate / qdisc_lookup_rcu

write to 0xffff888168ad6410 of 8 bytes by task 13559 on cpu 1:
 attach_default_qdiscs net/sched/sch_generic.c:1167 [inline]
 dev_activate+0x2ed/0x8f0 net/sched/sch_generic.c:1221
 __dev_open+0x2e9/0x3a0 net/core/dev.c:1416
 __dev_change_flags+0x167/0x3f0 net/core/dev.c:8139
 rtnl_configure_link+0xc2/0x150 net/core/rtnetlink.c:3150
 __rtnl_newlink net/core/rtnetlink.c:3489 [inline]
 rtnl_newlink+0xf4d/0x13e0 net/core/rtnetlink.c:3529
 rtnetlink_rcv_msg+0x745/0x7e0 net/core/rtnetlink.c:5594
 netlink_rcv_skb+0x14e/0x250 net/netlink/af_netlink.c:2494
 rtnetlink_rcv+0x18/0x20 net/core/rtnetlink.c:5612
 netlink_unicast_kernel net/netlink/af_netlink.c:1317 [inline]
 netlink_unicast+0x602/0x6d0 net/netlink/af_netlink.c:1343
 netlink_sendmsg+0x728/0x850 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:705 [inline]
 sock_sendmsg net/socket.c:725 [inline]
 ____sys_sendmsg+0x39a/0x510 net/socket.c:2413
 ___sys_sendmsg net/socket.c:2467 [inline]
 __sys_sendmsg+0x195/0x230 net/socket.c:2496
 __do_sys_sendmsg net/socket.c:2505 [inline]
 __se_sys_sendmsg net/socket.c:2503 [inline]
 __x64_sys_sendmsg+0x42/0x50 net/socket.c:2503
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae

read to 0xffff888168ad6410 of 8 bytes by task 13560 on cpu 0:
 qdisc_lookup_rcu+0x30/0x2e0 net/sched/sch_api.c:323
 __tcf_qdisc_find+0x74/0x3a0 net/sched/cls_api.c:1050
 tc_del_tfilter+0x1c7/0x1350 net/sched/cls_api.c:2211
 rtnetlink_rcv_msg+0x5ba/0x7e0 net/core/rtnetlink.c:5585
 netlink_rcv_skb+0x14e/0x250 net/netlink/af_netlink.c:2494
 rtnetlink_rcv+0x18/0x20 net/core/rtnetlink.c:5612
 netlink_unicast_kernel net/netlink/af_netlink.c:1317 [inline]
 netlink_unicast+0x602/0x6d0 net/netlink/af_netlink.c:1343
 netlink_sendmsg+0x728/0x850 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:705 [inline]
 sock_sendmsg net/socket.c:725 [inline]
 ____sys_sendmsg+0x39a/0x510 net/socket.c:2413
 ___sys_sendmsg net/socket.c:2467 [inline]
 __sys_sendmsg+0x195/0x230 net/socket.c:2496
 __do_sys_sendmsg net/socket.c:2505 [inline]
 __se_sys_sendmsg net/socket.c:2503 [inline]
 __x64_sys_sendmsg+0x42/0x50 net/socket.c:2503
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae

value changed: 0xffffffff85dee080 -> 0xffff88815d96ec00

Reported by Kernel Concurrency Sanitizer on:
CPU: 0 PID: 13560 Comm: syz-executor.2 Not tainted 5.17.0-rc3-syzkaller-00116-gf1baf68e1383-dirty #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011

Fixes: 470502de5b ("net: sched: unlock rules update API")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Vlad Buslov <vladbu@mellanox.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-02-23 12:03:12 +01:00
..
act_api.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_bpf.c
bpf: Refactor BPF_PROG_RUN into a function
2021-08-17 00:45:07 +02:00
act_connmark.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_csum.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_ct.c
net: openvswitch: Fix ct_state nat flags for conns arriving from tc
2022-01-27 11:04:02 +01:00
act_ctinfo.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_gact.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_gate.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_ife.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_ipt.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_meta_mark.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbprio.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_mirred.c
net: sched: act_mirred: drop dst for the direction from egress to ingress
2021-11-25 09:48:38 +01:00
act_mpls.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_nat.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_pedit.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_police.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_sample.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_simple.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_skbedit.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_skbmod.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_tunnel_key.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
act_vlan.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_api.c
net_sched: add __rcu annotation to netdev->qdisc
2022-02-23 12:03:12 +01:00
cls_basic.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_bpf.c
bpf: Refactor BPF_PROG_RUN into a function
2021-08-17 00:45:07 +02:00
cls_cgroup.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_flow.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_flower.c
net/sched: flow_dissector: Fix matching on zone id for invalid conns
2022-01-27 11:04:02 +01:00
cls_fw.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_matchall.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_route.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_rsvp6.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_rsvp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_rsvp.h
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_tcindex.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_u32.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
em_canid.c
net: sched: kerneldoc fixes
2020-07-13 17:20:40 -07:00
em_cmp.c
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
em_ipset.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_ipt.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_meta.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_nbyte.c
net: sched: Return the correct errno code
2021-02-06 11:15:28 -08:00
em_text.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
em_u32.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
ematch.c
net: sched: Fix spelling mistakes
2021-05-31 22:44:56 -07:00
Kconfig
net: sched: incorrect Kconfig dependencies on Netfilter modules
2020-12-09 15:49:29 -08:00
Makefile
net/sched: sch_frag: add generic packet fragment support.
2020-11-27 14:36:02 -08:00
sch_api.c
net_sched: add __rcu annotation to netdev->qdisc
2022-02-23 12:03:12 +01:00
sch_atm.c
net/sched: store the last executed chain also for clsact egress
2021-07-29 22:17:37 +01:00
sch_blackhole.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_cake.c
sch_cake: do not call cake_destroy() from cake_init()
2021-12-22 09:32:40 +01:00
sch_cbq.c
net: sched: Fix qdisc_rate_table refcount leak when get tcf_block failed
2021-08-30 20:29:03 -07:00
sch_cbs.c
net: don't include ethtool.h from netdevice.h
2020-11-23 17:27:04 -08:00
sch_choke.c
net: sched: validate stab values
2021-03-10 15:47:52 -08:00
sch_codel.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_drr.c
net/sched: store the last executed chain also for clsact egress
2021-07-29 22:17:37 +01:00
sch_dsmark.c
net/sched: store the last executed chain also for clsact egress
2021-07-29 22:17:37 +01:00
sch_etf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_ets.c
net/sched: sch_ets: don't remove idle classes from the round-robin list
2021-12-22 09:32:41 +01:00
sch_fifo.c
net_sched: fix NULL deref in fifo_set_limit()
2021-10-01 14:59:10 -07:00
sch_fq_codel.c
fq_codel: reject silly quantum parameters
2021-09-04 10:49:46 +01:00
sch_fq_pie.c
net/sched: fq_pie: prevent dismantle issue
2021-12-14 10:57:10 +01:00
sch_fq.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_frag.c
net/sched: Extend qdisc control block with tc control block
2022-01-05 12:42:33 +01:00
sch_generic.c
net_sched: add __rcu annotation to netdev->qdisc
2022-02-23 12:03:12 +01:00
sch_gred.c
net: sched: Fix spelling mistakes
2021-05-31 22:44:56 -07:00
sch_hfsc.c
net/sched: store the last executed chain also for clsact egress
2021-07-29 22:17:37 +01:00
sch_hhf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_htb.c
sch_htb: Fail on unsupported parameters when offload is requested
2022-02-01 17:27:13 +01:00
sch_ingress.c
net: sched: Pass ingress block to tcf_classify_ingress
2020-02-19 17:49:48 -08:00
sch_mq.c
net: sched: update default qdisc visibility after Tx queue cnt changes
2021-11-18 19:16:10 +01:00
sch_mqprio.c
net: sched: update default qdisc visibility after Tx queue cnt changes
2021-11-18 19:16:10 +01:00
sch_multiq.c
net/sched: store the last executed chain also for clsact egress
2021-07-29 22:17:37 +01:00
sch_netem.c
netem: fix zero division in tabledist
2020-10-29 11:45:47 -07:00
sch_pie.c
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
sch_plug.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_prio.c
net/sched: store the last executed chain also for clsact egress
2021-07-29 22:17:37 +01:00
sch_qfq.c
sch_qfq: prevent shift-out-of-bounds in qfq_init_qdisc
2022-01-11 15:35:14 +01:00
sch_red.c
net: sched: validate stab values
2021-03-10 15:47:52 -08:00
sch_sfb.c
net/sched: store the last executed chain also for clsact egress
2021-07-29 22:17:37 +01:00
sch_sfq.c
net/sched: store the last executed chain also for clsact egress
2021-07-29 22:17:37 +01:00
sch_skbprio.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_taprio.c
net/sched: sch_taprio: fix undefined behavior in ktime_mono_to_any
2021-11-18 19:17:12 +01:00
sch_tbf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_teql.c
net: sched: sch_teql: fix null-pointer dereference
2021-04-08 14:14:42 -07:00