iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Chao Yu f41ee8b91c f2fs: fix to do sanity check on curseg->alloc_type 
As Wenqing Liu reported in bugzilla:

https://bugzilla.kernel.org/show_bug.cgi?id=215657

- Overview
UBSAN: array-index-out-of-bounds in fs/f2fs/segment.c:3460:2 when mount and operate a corrupted image

- Reproduce
tested on kernel 5.17-rc4, 5.17-rc6

1. mkdir test_crash
2. cd test_crash
3. unzip tmp2.zip
4. mkdir mnt
5. ./single_test.sh f2fs 2

- Kernel dump
[   46.434454] loop0: detected capacity change from 0 to 131072
[   46.529839] F2FS-fs (loop0): Mounted with checkpoint version = 7548c2d9
[   46.738319] ================================================================================
[   46.738412] UBSAN: array-index-out-of-bounds in fs/f2fs/segment.c:3460:2
[   46.738475] index 231 is out of range for type 'unsigned int [2]'
[   46.738539] CPU: 2 PID: 939 Comm: umount Not tainted 5.17.0-rc6 #1
[   46.738547] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-1ubuntu1.1 04/01/2014
[   46.738551] Call Trace:
[   46.738556]  <TASK>
[   46.738563]  dump_stack_lvl+0x47/0x5c
[   46.738581]  ubsan_epilogue+0x5/0x50
[   46.738592]  __ubsan_handle_out_of_bounds+0x68/0x80
[   46.738604]  f2fs_allocate_data_block+0xdff/0xe60 [f2fs]
[   46.738819]  do_write_page+0xef/0x210 [f2fs]
[   46.738934]  f2fs_do_write_node_page+0x3f/0x80 [f2fs]
[   46.739038]  __write_node_page+0x2b7/0x920 [f2fs]
[   46.739162]  f2fs_sync_node_pages+0x943/0xb00 [f2fs]
[   46.739293]  f2fs_write_checkpoint+0x7bb/0x1030 [f2fs]
[   46.739405]  kill_f2fs_super+0x125/0x150 [f2fs]
[   46.739507]  deactivate_locked_super+0x60/0xc0
[   46.739517]  deactivate_super+0x70/0xb0
[   46.739524]  cleanup_mnt+0x11a/0x200
[   46.739532]  __cleanup_mnt+0x16/0x20
[   46.739538]  task_work_run+0x67/0xa0
[   46.739547]  exit_to_user_mode_prepare+0x18c/0x1a0
[   46.739559]  syscall_exit_to_user_mode+0x26/0x40
[   46.739568]  do_syscall_64+0x46/0xb0
[   46.739584]  entry_SYSCALL_64_after_hwframe+0x44/0xae

The root cause is we missed to do sanity check on curseg->alloc_type,
result in out-of-bound accessing on sbi->block_count[] array, fix it.

Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
2022-03-03 18:19:41 -08:00
..
9p
9p-for-5.17-rc1: fixes, split 9p_net_fd, new reviewer
2022-01-16 07:36:49 +02:00
adfs
fs/adfs: remove unneeded variable make code cleaner
2022-01-20 08:52:55 +02:00
affs
affs: use bdev_nr_sectors instead of open coding it
2021-10-18 14:43:22 -06:00
afs
proc: remove PDE_DATA() completely
2022-01-22 08:33:37 +02:00
autofs
autofs: fix wait name hash calculation in autofs_wait()
2021-10-20 21:09:02 -04:00
befs
isystem: ship and use stdarg.h
2021-08-19 09:02:55 +09:00
bfs
mm: require ->set_page_dirty to be explicitly wired up
2021-06-29 10:53:48 -07:00
btrfs
mm: remove cleancache
2022-01-22 08:33:38 +02:00
cachefiles
cachefiles: Check that the backing filesystem supports tmpfiles
2022-01-21 21:36:28 +00:00
ceph
fscache fixes
2022-01-22 10:59:32 +02:00
cifs
cifs: update internal module number
2022-01-19 23:14:34 -06:00
coda
coda: bump module version to 7.2
2021-11-09 10:02:51 -08:00
configfs
configfs: fix a race in configfs_lookup()
2021-08-25 07:58:49 +02:00
cramfs
cramfs: use bdev_nr_bytes instead of open coding it
2021-10-18 14:43:22 -06:00
crypto
fscrypt: improve a few comments
2021-10-25 19:11:50 -07:00
debugfs
debugfs: lockdown: Allow reading debugfs files that are not world readable
2022-01-06 15:47:41 +01:00
devpts
…
dlm
driver core changes for 5.17-rc1
2022-01-12 11:11:34 -08:00
ecryptfs
fs: add is_idmapped_mnt() helper
2021-12-03 18:44:06 +01:00
efivarfs
…
efs
…
erofs
dax + libnvdimm for v5.17
2022-01-12 15:46:11 -08:00
exfat
exfat: fix missing REQ_SYNC in exfat_update_bhs()
2022-01-10 11:00:04 +09:00
exportfs
…
ext2
fsdax: shift partition offset handling into the file systems
2021-12-04 08:58:54 -08:00
ext4
mm: remove cleancache
2022-01-22 08:33:38 +02:00
f2fs
f2fs: fix to do sanity check on curseg->alloc_type
2022-03-03 18:19:41 -08:00
fat
FAT: use io_schedule_timeout() instead of congestion_wait()
2022-01-20 08:52:54 +02:00
freevxfs
…
fscache
fscache: Fix the volume collision wait condition
2022-01-21 21:36:28 +00:00
fuse
virtio,vdpa,qemu_fw_cfg: features, cleanups, fixes
2022-01-18 10:05:48 +02:00
gfs2
driver core changes for 5.17-rc1
2022-01-12 11:11:34 -08:00
hfs
Merge branch 'akpm' (patches from Andrew)
2021-11-09 10:11:53 -08:00
hfsplus
hfsplus: use struct_group_attr() for memcpy() region
2022-01-20 08:52:54 +02:00
hostfs
hostfs: Fix writeback of dirty pages
2021-12-21 21:44:27 +01:00
hpfs
treewide: Replace open-coded flex arrays in unions
2021-10-18 12:28:53 -07:00
hugetlbfs
hugetlbfs: fix off-by-one error in hugetlb_vmdelete_list()
2022-01-15 16:30:30 +02:00
iomap
dax + libnvdimm for v5.17
2022-01-12 15:46:11 -08:00
isofs
isofs: Fix out of bound access for corrupted isofs image
2021-10-19 12:51:02 +02:00
jbd2
proc: remove PDE_DATA() completely
2022-01-22 08:33:37 +02:00
jffs2
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
jfs
Just one JFS patch
2021-11-03 09:23:25 -07:00
kernfs
kernfs: prevent early freeing of root node
2021-12-03 14:36:21 +01:00
ksmbd
23 ksmbd server fixes
2022-01-20 13:39:13 +02:00
lockd
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
minix
mm: require ->set_page_dirty to be explicitly wired up
2021-06-29 10:53:48 -07:00
netfs
netfs: Make ops->init_rreq() optional
2022-01-21 21:36:28 +00:00
nfs
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
nfs_common
nfs: Fix kerneldoc warning shown up by W=1
2021-10-04 22:02:17 +01:00
nfsd
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
nilfs2
Merge branch 'akpm' (patches from Andrew)
2022-01-20 10:41:01 +02:00
nls
…
notify
inotify: simplify subdirectory registration with register_sysctl()
2022-01-22 08:33:35 +02:00
ntfs
fs/ntfs/attrib.c: fix one kernel-doc comment
2022-01-15 16:30:24 +02:00
ntfs3
mm: remove cleancache
2022-01-22 08:33:38 +02:00
ocfs2
bitmap patches for 5.17-rc1
2022-01-23 06:20:44 +02:00
omfs
mm: require ->set_page_dirty to be explicitly wired up
2021-06-29 10:53:48 -07:00
openpromfs
…
orangefs
orangefs: Fix the size of a memory allocation in orangefs_bufmap_alloc()
2021-12-31 14:37:43 -05:00
overlayfs
fs: add is_idmapped_mnt() helper
2021-12-03 18:44:06 +01:00
proc
proc: remove PDE_DATA() completely
2022-01-22 08:33:37 +02:00
pstore
pstore update for v5.17-rc1
2022-01-10 11:48:37 -08:00
qnx4
qnx4: work around gcc false positive warning bug
2021-09-21 08:36:48 -07:00
qnx6
…
quota
\n
2021-11-06 16:40:48 -07:00
ramfs
Merge branch 'akpm' (patches from Andrew)
2021-11-09 10:11:53 -08:00
reiserfs
reiserfs: don't use congestion_wait()
2021-11-18 11:52:22 +01:00
romfs
…
smbfs_common
smb3: add new defines from protocol specification
2022-01-18 16:50:47 -06:00
squashfs
squashfs: provide backing_dev_info in order to disable read-ahead
2022-01-15 16:30:24 +02:00
sysfs
fs/sysfs/dir.c: replace S_IRWXU|S_IRUGO|S_IXUGO with 0755 sysfs_create_dir_ns()
2021-10-05 16:35:05 +02:00
sysv
sysv: use BUILD_BUG_ON instead of runtime check
2021-11-09 10:02:52 -08:00
tracefs
Tracing updates for 5.17:
2022-01-16 10:15:32 +02:00
ubifs
ubifs: read-only if LEB may always be taken in ubifs_garbage_collect
2021-12-23 22:30:38 +01:00
udf
udf: Fix error handling in udf_new_inode()
2021-12-15 13:08:34 +01:00
ufs
isystem: ship and use stdarg.h
2021-08-19 09:02:55 +09:00
unicode
unicode: fix .gitignore for generated utfdata file
2022-01-17 07:26:43 +02:00
vboxsf
vboxfs: fix broken legacy mount signature checking
2021-09-27 11:26:21 -07:00
verity
fs-verity: fix signed integer overflow with i_size near S64_MAX
2021-09-22 10:56:34 -07:00
xfs
New code for 5.17:
2022-01-22 11:04:27 +02:00
zonefs
zonefs: add MODULE_ALIAS_FS
2021-12-17 16:56:35 +09:00
aio.c
aio: move aio sysctl to aio.c
2022-01-22 08:33:34 +02:00
anon_inodes.c
fs: add anon_inode_getfile_secure() similar to anon_inode_getfd_secure()
2021-09-19 22:35:37 -04:00
attr.c
fs: handle circular mappings correctly
2021-11-17 09:26:09 +01:00
bad_inode.c
vfs: add rcu argument to ->get_acl() callback
2021-08-18 22:08:24 +02:00
binfmt_aout.c
binfmt: a.out: Fix bogus semicolon
2021-09-05 10:15:05 -07:00
binfmt_elf_fdpic.c
coredump: Limit coredumps to a single thread group
2021-10-08 12:06:02 -05:00
binfmt_elf.c
fs/binfmt_elf: use PT_LOAD p_align values for static PIE
2022-01-20 08:52:54 +02:00
binfmt_flat.c
binfmt: remove in-tree usage of MAP_EXECUTABLE
2021-06-29 10:53:50 -07:00
binfmt_misc.c
fs: move binfmt_misc sysctl to its own file
2022-01-22 08:33:35 +02:00
binfmt_script.c
…
buffer.c
fs/buffer: Convert __block_write_begin_int() to take a folio
2021-12-16 15:49:51 -05:00
char_dev.c
…
compat_binfmt_elf.c
…
coredump.c
fs/coredump: move coredump sysctls into its own file
2022-01-22 08:33:36 +02:00
d_path.c
d_path: fix Kernel doc validator complaining
2021-11-06 13:30:32 -07:00
dax.c
dax: remove the copy_from_iter and copy_to_iter methods
2021-12-18 08:04:53 -08:00
dcache.c
fs: move dcache sysctls to its own file
2022-01-22 08:33:36 +02:00
direct-io.c
fs: get rid of the res2 iocb->ki_complete argument
2021-10-25 10:36:24 -06:00
drop_caches.c
fs: drop_caches: fix skipping over shadow cache inodes
2021-09-03 09:58:10 -07:00
eventfd.c
eventfd: Export eventfd_wake_count to modules
2021-09-06 07:20:56 -04:00
eventpoll.c
eventpoll: simplify sysctl declaration with register_sysctl()
2022-01-22 08:33:35 +02:00
exec.c
fs/coredump: move coredump sysctls into its own file
2022-01-22 08:33:36 +02:00
fcntl.c
Merge branch 'akpm' (patches from Andrew)
2021-09-03 10:08:28 -07:00
fhandle.c
…
file_table.c
fs: move fs stat sysctls to file_table.c
2022-01-22 08:33:36 +02:00
file.c
fget: clarify and improve __fget_files() implementation
2021-12-13 10:55:30 -08:00
filesystems.c
fs: simplify get_filesystem_list / get_all_fs_names
2021-08-23 01:25:40 -04:00
fs_context.c
vfs: fs_context: fix up param length parsing in legacy_parse_param
2022-01-18 09:23:19 +02:00
fs_parser.c
fs_parse: allow parameter value to be empty
2021-12-09 14:09:36 -05:00
fs_pin.c
…
fs_struct.c
…
fs_types.c
…
fs-writeback.c
fscache rewrite
2022-01-12 13:45:12 -08:00
fsopen.c
…
init.c
…
inode.c
fs: move inode sysctls to its own file
2022-01-22 08:33:35 +02:00
internal.h
fs/buffer: Convert __block_write_begin_int() to take a folio
2021-12-16 15:49:51 -05:00
io_uring.c
io_uring: perform poll removal even if async work removal is successful
2022-01-18 19:28:43 -07:00
io-wq.c
io_uring-5.17-2022-01-21
2022-01-21 16:07:21 +02:00
io-wq.h
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
ioctl.c
fs/ioctl: remove unnecessary __user annotation
2022-01-15 16:30:25 +02:00
Kconfig
cachefiles: Introduce rewritten driver
2022-01-07 13:40:39 +00:00
Kconfig.binfmt
binfmt: remove support for em86 (alpha only)
2021-07-25 22:33:03 -07:00
kernel_read_file.c
vfs: check fd has read access in kernel_read_file_from_fd()
2021-10-18 20:22:03 -10:00
libfs.c
libfs: Support RENAME_EXCHANGE in simple_rename()
2021-11-03 15:43:08 +01:00
locks.c
fs: move locking sysctls where they are used
2022-01-22 08:33:36 +02:00
Makefile
fs: move namespace sysctls and declare fs base directory
2022-01-22 08:33:36 +02:00
mbcache.c
…
mount.h
…
mpage.c
mm: remove cleancache
2022-01-22 08:33:38 +02:00
namei.c
fs: move namei sysctls to its own file
2022-01-22 08:33:36 +02:00
namespace.c
fs: move namespace sysctls and declare fs base directory
2022-01-22 08:33:36 +02:00
no-block.c
…
nsfs.c
…
open.c
fs: support mapped mounts of mapped filesystems
2021-12-05 10:28:57 +01:00
pipe.c
fs: move pipe sysctls to is own file
2022-01-22 08:33:36 +02:00
pnode.c
…
pnode.h
…
posix_acl.c
fs: support mapped mounts of mapped filesystems
2021-12-05 10:28:57 +01:00
proc_namespace.c
fs: add is_idmapped_mnt() helper
2021-12-03 18:44:06 +01:00
read_write.c
fs: remove leftover comments from mandatory locking removal
2021-10-26 12:20:50 -04:00
readdir.c
…
remap_range.c
fs: Convert vfs_dedupe_file_range_compare to folios
2022-01-08 00:28:41 -05:00
select.c
select: Fix indefinitely sleeping task in poll_schedule_timeout()
2022-01-11 09:03:05 -08:00
seq_file.c
seq_file: move seq_escape() to a header
2021-11-09 10:02:52 -08:00
signalfd.c
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
splice.c
…
stack.c
…
stat.c
fs: add generic helper for filling statx attribute flags
2021-08-17 11:47:43 +02:00
statfs.c
…
super.c
mm: remove cleancache
2022-01-22 08:33:38 +02:00
sync.c
block: simplify the block device syncing code
2021-10-22 08:36:55 -06:00
sysctls.c
fs: move namespace sysctls and declare fs base directory
2022-01-22 08:33:36 +02:00
timerfd.c
timerfd: Provide timerfd_resume()
2021-08-10 17:57:22 +02:00
userfaultfd.c
mm: move anon_vma declarations to linux/mm_inline.h
2022-01-15 16:30:27 +02:00
utimes.c
…
xattr.c
…