Guangguan Wang
f5146e3ef0
net/smc: use smc_lgr_list.lock to protect smc_lgr_list.list iterate in smcr_port_add ...
While doing smcr_port_add, there maybe linkgroup add into or delete
from smc_lgr_list.list at the same time, which may result kernel crash.
So, use smc_lgr_list.lock to protect smc_lgr_list.list iterate in
smcr_port_add.
The crash calltrace show below:
BUG: kernel NULL pointer dereference, address: 0000000000000000
PGD 0 P4D 0
Oops: 0000 [#1 ] SMP NOPTI
CPU: 0 PID: 559726 Comm: kworker/0:92 Kdump: loaded Tainted: G
Hardware name: Alibaba Cloud Alibaba Cloud ECS, BIOS 449e491 04/01/2014
Workqueue: events smc_ib_port_event_work [smc]
RIP: 0010:smcr_port_add+0xa6/0xf0 [smc]
RSP: 0000:ffffa5a2c8f67de0 EFLAGS: 00010297
RAX: 0000000000000001 RBX: ffff9935e0650000 RCX: 0000000000000000
RDX: 0000000000000010 RSI: ffff9935e0654290 RDI: ffff9935c8560000
RBP: 0000000000000000 R08: 0000000000000000 R09: ffff9934c0401918
R10: 0000000000000000 R11: ffffffffb4a5c278 R12: ffff99364029aae4
R13: ffff99364029aa00 R14: 00000000ffffffed R15: ffff99364029ab08
FS: 0000000000000000(0000) GS:ffff994380600000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 0000000f06a10003 CR4: 0000000002770ef0
PKRU: 55555554
Call Trace:
smc_ib_port_event_work+0x18f/0x380 [smc]
process_one_work+0x19b/0x340
worker_thread+0x30/0x370
? process_one_work+0x340/0x340
kthread+0x114/0x130
? __kthread_cancel_work+0x50/0x50
ret_from_fork+0x1f/0x30
Fixes: 1f90a05d9ff9 ("net/smc: add smcr_port_add() and smcr_link_up() processing")
Signed-off-by: Guangguan Wang <guangguan.wang@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2023-09-10 19:31:42 +01:00
2023-08-09 15:32:43 -07:00
2023-08-18 12:44:56 -07:00
2023-06-24 15:50:13 -07:00
2023-06-24 15:50:13 -07:00
2023-08-15 15:26:17 -07:00
2023-08-24 10:51:39 -07:00
2023-09-01 09:38:00 -07:00
2023-08-30 08:36:17 +02:00
2023-05-31 13:06:57 +02:00
2023-08-29 17:39:15 -07:00
2023-06-24 15:50:13 -07:00
2023-09-01 07:27:33 +01:00
2023-08-24 11:24:37 +02:00
2023-09-07 18:33:07 -07:00
2023-08-01 21:07:46 -07:00
2023-08-29 07:44:56 +02:00
2023-08-28 08:02:24 -07:00
2023-08-09 13:08:09 -07:00
2023-08-15 15:01:03 -07:00
2023-09-01 07:25:14 +01:00
2023-07-31 20:11:47 -07:00
2023-08-29 17:39:15 -07:00
2023-09-08 08:02:17 +01:00
2023-09-07 18:33:07 -07:00
2023-09-05 10:12:03 +02:00
2023-08-18 12:44:56 -07:00
2023-08-16 11:09:16 +01:00
2023-08-09 15:34:28 -07:00
2023-08-25 18:35:09 -07:00
2023-06-24 15:41:46 -07:00
2023-06-24 15:50:13 -07:00
2023-08-15 15:26:18 -07:00
2023-09-07 18:33:07 -07:00
2023-08-15 14:54:44 -07:00
2023-09-07 18:33:07 -07:00
2023-08-02 12:28:22 -07:00
2023-08-15 15:01:03 -07:00
2023-08-28 06:58:46 +01:00
2023-09-01 09:38:00 -07:00
2023-06-10 00:11:41 -07:00
2023-08-18 12:44:56 -07:00
2023-08-10 14:10:53 -07:00
2023-06-24 15:50:13 -07:00
2023-07-17 09:02:30 +01:00
2023-08-29 17:39:15 -07:00
2023-06-24 15:50:13 -07:00
2023-06-28 16:43:10 -07:00
2023-09-05 08:54:12 +02:00
2023-09-07 18:33:07 -07:00
2023-09-10 19:31:42 +01:00
2023-08-31 15:36:41 -07:00
2023-07-21 08:54:03 +01:00
2023-08-29 14:25:26 -07:00
2023-08-27 17:17:42 -07:00
2023-09-07 18:33:07 -07:00
2023-07-31 14:41:08 -07:00
2023-08-22 21:40:40 +02:00
2023-06-24 15:50:13 -07:00
2023-08-31 13:21:11 +02:00
2023-08-29 17:39:15 -07:00
2023-07-19 10:07:27 -07:00
2023-09-07 18:33:07 -07:00
2023-08-15 15:26:17 -07:00
f5146e3ef0