drm bridges added by meson_encoder_hdmi_init and meson_encoder_cvbs_init were not manually removed at module unload time, which caused dangling references to freed memory to remain linked in the global bridge_list. When loading the driver modules back in, the same functions would again call drm_bridge_add, and when traversing the global bridge_list, would end up peeking into freed memory. Once again KASAN revealed the problem: [ +0.000095] ============================================================= [ +0.000008] BUG: KASAN: use-after-free in __list_add_valid+0x9c/0x120 [ +0.000018] Read of size 8 at addr ffff00003da291f0 by task modprobe/2483 [ +0.000018] CPU: 3 PID: 2483 Comm: modprobe Tainted: G C O 5.19.0-rc6-lrmbkasan+ #1 [ +0.000011] Hardware name: Hardkernel ODROID-N2Plus (DT) [ +0.000008] Call trace: [ +0.000006] dump_backtrace+0x1ec/0x280 [ +0.000012] show_stack+0x24/0x80 [ +0.000008] dump_stack_lvl+0x98/0xd4 [ +0.000011] print_address_description.constprop.0+0x80/0x520 [ +0.000011] print_report+0x128/0x260 [ +0.000008] kasan_report+0xb8/0xfc [ +0.000008] __asan_report_load8_noabort+0x3c/0x50 [ +0.000009] __list_add_valid+0x9c/0x120 [ +0.000009] drm_bridge_add+0x6c/0x104 [drm] [ +0.000165] dw_hdmi_probe+0x1900/0x2360 [dw_hdmi] [ +0.000022] meson_dw_hdmi_bind+0x520/0x814 [meson_dw_hdmi] [ +0.000014] component_bind+0x174/0x520 [ +0.000012] component_bind_all+0x1a8/0x38c [ +0.000010] meson_drv_bind_master+0x5e8/0xb74 [meson_drm] [ +0.000032] meson_drv_bind+0x20/0x2c [meson_drm] [ +0.000027] try_to_bring_up_aggregate_device+0x19c/0x390 [ +0.000010] component_master_add_with_match+0x1c8/0x284 [ +0.000009] meson_drv_probe+0x274/0x280 [meson_drm] [ +0.000026] platform_probe+0xd0/0x220 [ +0.000009] really_probe+0x3ac/0xa80 [ +0.000009] __driver_probe_device+0x1f8/0x400 [ +0.000009] driver_probe_device+0x68/0x1b0 [ +0.000009] __driver_attach+0x20c/0x480 [ +0.000008] bus_for_each_dev+0x114/0x1b0 [ +0.000009] driver_attach+0x48/0x64 [ +0.000008] bus_add_driver+0x390/0x564 [ +0.000009] driver_register+0x1a8/0x3e4 [ +0.000009] __platform_driver_register+0x6c/0x94 [ +0.000008] meson_drm_platform_driver_init+0x3c/0x1000 [meson_drm] [ +0.000027] do_one_initcall+0xc4/0x2b0 [ +0.000011] do_init_module+0x154/0x570 [ +0.000011] load_module+0x1a78/0x1ea4 [ +0.000008] __do_sys_init_module+0x184/0x1cc [ +0.000009] __arm64_sys_init_module+0x78/0xb0 [ +0.000009] invoke_syscall+0x74/0x260 [ +0.000009] el0_svc_common.constprop.0+0xcc/0x260 [ +0.000008] do_el0_svc+0x50/0x70 [ +0.000007] el0_svc+0x68/0x1a0 [ +0.000012] el0t_64_sync_handler+0x11c/0x150 [ +0.000008] el0t_64_sync+0x18c/0x190 [ +0.000016] Allocated by task 879: [ +0.000008] kasan_save_stack+0x2c/0x5c [ +0.000011] __kasan_kmalloc+0x90/0xd0 [ +0.000007] __kmalloc+0x278/0x4a0 [ +0.000011] mpi_resize+0x13c/0x1d0 [ +0.000011] mpi_powm+0xd24/0x1570 [ +0.000009] rsa_enc+0x1a4/0x30c [ +0.000009] pkcs1pad_verify+0x3f0/0x580 [ +0.000009] public_key_verify_signature+0x7a8/0xba4 [ +0.000010] public_key_verify_signature_2+0x40/0x60 [ +0.000008] verify_signature+0xb4/0x114 [ +0.000008] pkcs7_validate_trust_one.constprop.0+0x3b8/0x574 [ +0.000009] pkcs7_validate_trust+0xb8/0x15c [ +0.000008] verify_pkcs7_message_sig+0xec/0x1b0 [ +0.000012] verify_pkcs7_signature+0x78/0xac [ +0.000007] mod_verify_sig+0x110/0x190 [ +0.000009] module_sig_check+0x114/0x1e0 [ +0.000009] load_module+0xa0/0x1ea4 [ +0.000008] __do_sys_init_module+0x184/0x1cc [ +0.000008] __arm64_sys_init_module+0x78/0xb0 [ +0.000008] invoke_syscall+0x74/0x260 [ +0.000009] el0_svc_common.constprop.0+0x1a8/0x260 [ +0.000008] do_el0_svc+0x50/0x70 [ +0.000007] el0_svc+0x68/0x1a0 [ +0.000009] el0t_64_sync_handler+0x11c/0x150 [ +0.000009] el0t_64_sync+0x18c/0x190 [ +0.000013] Freed by task 2422: [ +0.000008] kasan_save_stack+0x2c/0x5c [ +0.000009] kasan_set_track+0x2c/0x40 [ +0.000007] kasan_set_free_info+0x28/0x50 [ +0.000009] ____kasan_slab_free+0x128/0x1d4 [ +0.000008] __kasan_slab_free+0x18/0x24 [ +0.000007] slab_free_freelist_hook+0x108/0x230 [ +0.000010] kfree+0x110/0x35c [ +0.000008] release_nodes+0xf0/0x16c [ +0.000009] devres_release_group+0x180/0x270 [ +0.000008] take_down_aggregate_device+0xcc/0x160 [ +0.000010] component_del+0x18c/0x360 [ +0.000009] meson_dw_hdmi_remove+0x28/0x40 [meson_dw_hdmi] [ +0.000013] platform_remove+0x64/0xb0 [ +0.000008] device_remove+0xb8/0x154 [ +0.000009] device_release_driver_internal+0x398/0x5b0 [ +0.000009] driver_detach+0xac/0x1b0 [ +0.000009] bus_remove_driver+0x158/0x29c [ +0.000008] driver_unregister+0x70/0xb0 [ +0.000009] platform_driver_unregister+0x20/0x2c [ +0.000007] meson_dw_hdmi_platform_driver_exit+0x1c/0x30 [meson_dw_hdmi] [ +0.000012] __do_sys_delete_module+0x288/0x400 [ +0.000009] __arm64_sys_delete_module+0x5c/0x80 [ +0.000009] invoke_syscall+0x74/0x260 [ +0.000008] el0_svc_common.constprop.0+0xcc/0x260 [ +0.000008] do_el0_svc+0x50/0x70 [ +0.000007] el0_svc+0x68/0x1a0 [ +0.000008] el0t_64_sync_handler+0x11c/0x150 [ +0.000009] el0t_64_sync+0x18c/0x190 [ +0.000013] The buggy address belongs to the object at ffff00003da29000 which belongs to the cache kmalloc-1k of size 1024 [ +0.000008] The buggy address is located 496 bytes inside of 1024-byte region [ffff00003da29000, ffff00003da29400) [ +0.000015] The buggy address belongs to the physical page: [ +0.000009] page:fffffc0000f68a00 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x3da28 [ +0.000012] head:fffffc0000f68a00 order:3 compound_mapcount:0 compound_pincount:0 [ +0.000009] flags: 0xffff00000010200(slab|head|node=0|zone=0|lastcpupid=0xffff) [ +0.000019] raw: 0ffff00000010200 fffffc0000eb5c08 fffffc0000d96608 ffff000000002a80 [ +0.000008] raw: 0000000000000000 00000000000a000a 00000001ffffffff 0000000000000000 [ +0.000008] page dumped because: kasan: bad access detected [ +0.000011] Memory state around the buggy address: [ +0.000009] ffff00003da29080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ +0.000007] ffff00003da29100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ +0.000007] >ffff00003da29180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ +0.000007] ^ [ +0.000008] ffff00003da29200: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ +0.000006] ffff00003da29280: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ +0.000007] ================================================================== Fix by keeping track of which encoders were initialised in the meson_drm structure and manually removing their bridges at aggregate driver's unbind time. Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20220920222842.1053234-1-adrian.larumbe@collabora.com
476 lines
14 KiB
C
476 lines
14 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Copyright (C) 2016 BayLibre, SAS
|
|
* Author: Neil Armstrong <narmstrong@baylibre.com>
|
|
* Copyright (C) 2015 Amlogic, Inc. All rights reserved.
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/component.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of_device.h>
|
|
#include <linux/of_graph.h>
|
|
#include <linux/regulator/consumer.h>
|
|
#include <linux/reset.h>
|
|
|
|
#include <media/cec-notifier.h>
|
|
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_bridge.h>
|
|
#include <drm/drm_bridge_connector.h>
|
|
#include <drm/drm_device.h>
|
|
#include <drm/drm_edid.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
#include <drm/drm_simple_kms_helper.h>
|
|
|
|
#include <linux/media-bus-format.h>
|
|
#include <linux/videodev2.h>
|
|
|
|
#include "meson_drv.h"
|
|
#include "meson_registers.h"
|
|
#include "meson_vclk.h"
|
|
#include "meson_venc.h"
|
|
#include "meson_encoder_hdmi.h"
|
|
|
|
struct meson_encoder_hdmi {
|
|
struct drm_encoder encoder;
|
|
struct drm_bridge bridge;
|
|
struct drm_bridge *next_bridge;
|
|
struct drm_connector *connector;
|
|
struct meson_drm *priv;
|
|
unsigned long output_bus_fmt;
|
|
struct cec_notifier *cec_notifier;
|
|
};
|
|
|
|
#define bridge_to_meson_encoder_hdmi(x) \
|
|
container_of(x, struct meson_encoder_hdmi, bridge)
|
|
|
|
static int meson_encoder_hdmi_attach(struct drm_bridge *bridge,
|
|
enum drm_bridge_attach_flags flags)
|
|
{
|
|
struct meson_encoder_hdmi *encoder_hdmi = bridge_to_meson_encoder_hdmi(bridge);
|
|
|
|
return drm_bridge_attach(bridge->encoder, encoder_hdmi->next_bridge,
|
|
&encoder_hdmi->bridge, flags);
|
|
}
|
|
|
|
static void meson_encoder_hdmi_detach(struct drm_bridge *bridge)
|
|
{
|
|
struct meson_encoder_hdmi *encoder_hdmi = bridge_to_meson_encoder_hdmi(bridge);
|
|
|
|
cec_notifier_conn_unregister(encoder_hdmi->cec_notifier);
|
|
encoder_hdmi->cec_notifier = NULL;
|
|
}
|
|
|
|
static void meson_encoder_hdmi_set_vclk(struct meson_encoder_hdmi *encoder_hdmi,
|
|
const struct drm_display_mode *mode)
|
|
{
|
|
struct meson_drm *priv = encoder_hdmi->priv;
|
|
int vic = drm_match_cea_mode(mode);
|
|
unsigned int phy_freq;
|
|
unsigned int vclk_freq;
|
|
unsigned int venc_freq;
|
|
unsigned int hdmi_freq;
|
|
|
|
vclk_freq = mode->clock;
|
|
|
|
/* For 420, pixel clock is half unlike venc clock */
|
|
if (encoder_hdmi->output_bus_fmt == MEDIA_BUS_FMT_UYYVYY8_0_5X24)
|
|
vclk_freq /= 2;
|
|
|
|
/* TMDS clock is pixel_clock * 10 */
|
|
phy_freq = vclk_freq * 10;
|
|
|
|
if (!vic) {
|
|
meson_vclk_setup(priv, MESON_VCLK_TARGET_DMT, phy_freq,
|
|
vclk_freq, vclk_freq, vclk_freq, false);
|
|
return;
|
|
}
|
|
|
|
/* 480i/576i needs global pixel doubling */
|
|
if (mode->flags & DRM_MODE_FLAG_DBLCLK)
|
|
vclk_freq *= 2;
|
|
|
|
venc_freq = vclk_freq;
|
|
hdmi_freq = vclk_freq;
|
|
|
|
/* VENC double pixels for 1080i, 720p and YUV420 modes */
|
|
if (meson_venc_hdmi_venc_repeat(vic) ||
|
|
encoder_hdmi->output_bus_fmt == MEDIA_BUS_FMT_UYYVYY8_0_5X24)
|
|
venc_freq *= 2;
|
|
|
|
vclk_freq = max(venc_freq, hdmi_freq);
|
|
|
|
if (mode->flags & DRM_MODE_FLAG_DBLCLK)
|
|
venc_freq /= 2;
|
|
|
|
dev_dbg(priv->dev, "vclk:%d phy=%d venc=%d hdmi=%d enci=%d\n",
|
|
phy_freq, vclk_freq, venc_freq, hdmi_freq,
|
|
priv->venc.hdmi_use_enci);
|
|
|
|
meson_vclk_setup(priv, MESON_VCLK_TARGET_HDMI, phy_freq, vclk_freq,
|
|
venc_freq, hdmi_freq, priv->venc.hdmi_use_enci);
|
|
}
|
|
|
|
static enum drm_mode_status meson_encoder_hdmi_mode_valid(struct drm_bridge *bridge,
|
|
const struct drm_display_info *display_info,
|
|
const struct drm_display_mode *mode)
|
|
{
|
|
struct meson_encoder_hdmi *encoder_hdmi = bridge_to_meson_encoder_hdmi(bridge);
|
|
struct meson_drm *priv = encoder_hdmi->priv;
|
|
bool is_hdmi2_sink = display_info->hdmi.scdc.supported;
|
|
unsigned int phy_freq;
|
|
unsigned int vclk_freq;
|
|
unsigned int venc_freq;
|
|
unsigned int hdmi_freq;
|
|
int vic = drm_match_cea_mode(mode);
|
|
enum drm_mode_status status;
|
|
|
|
dev_dbg(priv->dev, "Modeline " DRM_MODE_FMT "\n", DRM_MODE_ARG(mode));
|
|
|
|
/* If sink does not support 540MHz, reject the non-420 HDMI2 modes */
|
|
if (display_info->max_tmds_clock &&
|
|
mode->clock > display_info->max_tmds_clock &&
|
|
!drm_mode_is_420_only(display_info, mode) &&
|
|
!drm_mode_is_420_also(display_info, mode))
|
|
return MODE_BAD;
|
|
|
|
/* Check against non-VIC supported modes */
|
|
if (!vic) {
|
|
status = meson_venc_hdmi_supported_mode(mode);
|
|
if (status != MODE_OK)
|
|
return status;
|
|
|
|
return meson_vclk_dmt_supported_freq(priv, mode->clock);
|
|
/* Check against supported VIC modes */
|
|
} else if (!meson_venc_hdmi_supported_vic(vic))
|
|
return MODE_BAD;
|
|
|
|
vclk_freq = mode->clock;
|
|
|
|
/* For 420, pixel clock is half unlike venc clock */
|
|
if (drm_mode_is_420_only(display_info, mode) ||
|
|
(!is_hdmi2_sink &&
|
|
drm_mode_is_420_also(display_info, mode)))
|
|
vclk_freq /= 2;
|
|
|
|
/* TMDS clock is pixel_clock * 10 */
|
|
phy_freq = vclk_freq * 10;
|
|
|
|
/* 480i/576i needs global pixel doubling */
|
|
if (mode->flags & DRM_MODE_FLAG_DBLCLK)
|
|
vclk_freq *= 2;
|
|
|
|
venc_freq = vclk_freq;
|
|
hdmi_freq = vclk_freq;
|
|
|
|
/* VENC double pixels for 1080i, 720p and YUV420 modes */
|
|
if (meson_venc_hdmi_venc_repeat(vic) ||
|
|
drm_mode_is_420_only(display_info, mode) ||
|
|
(!is_hdmi2_sink &&
|
|
drm_mode_is_420_also(display_info, mode)))
|
|
venc_freq *= 2;
|
|
|
|
vclk_freq = max(venc_freq, hdmi_freq);
|
|
|
|
if (mode->flags & DRM_MODE_FLAG_DBLCLK)
|
|
venc_freq /= 2;
|
|
|
|
dev_dbg(priv->dev, "%s: vclk:%d phy=%d venc=%d hdmi=%d\n",
|
|
__func__, phy_freq, vclk_freq, venc_freq, hdmi_freq);
|
|
|
|
return meson_vclk_vic_supported_freq(priv, phy_freq, vclk_freq);
|
|
}
|
|
|
|
static void meson_encoder_hdmi_atomic_enable(struct drm_bridge *bridge,
|
|
struct drm_bridge_state *bridge_state)
|
|
{
|
|
struct meson_encoder_hdmi *encoder_hdmi = bridge_to_meson_encoder_hdmi(bridge);
|
|
struct drm_atomic_state *state = bridge_state->base.state;
|
|
unsigned int ycrcb_map = VPU_HDMI_OUTPUT_CBYCR;
|
|
struct meson_drm *priv = encoder_hdmi->priv;
|
|
struct drm_connector_state *conn_state;
|
|
const struct drm_display_mode *mode;
|
|
struct drm_crtc_state *crtc_state;
|
|
struct drm_connector *connector;
|
|
bool yuv420_mode = false;
|
|
int vic;
|
|
|
|
connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder);
|
|
if (WARN_ON(!connector))
|
|
return;
|
|
|
|
conn_state = drm_atomic_get_new_connector_state(state, connector);
|
|
if (WARN_ON(!conn_state))
|
|
return;
|
|
|
|
crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc);
|
|
if (WARN_ON(!crtc_state))
|
|
return;
|
|
|
|
mode = &crtc_state->adjusted_mode;
|
|
|
|
vic = drm_match_cea_mode(mode);
|
|
|
|
dev_dbg(priv->dev, "\"%s\" vic %d\n", mode->name, vic);
|
|
|
|
if (encoder_hdmi->output_bus_fmt == MEDIA_BUS_FMT_UYYVYY8_0_5X24) {
|
|
ycrcb_map = VPU_HDMI_OUTPUT_CRYCB;
|
|
yuv420_mode = true;
|
|
} else if (encoder_hdmi->output_bus_fmt == MEDIA_BUS_FMT_UYVY8_1X16)
|
|
ycrcb_map = VPU_HDMI_OUTPUT_CRYCB;
|
|
|
|
/* VENC + VENC-DVI Mode setup */
|
|
meson_venc_hdmi_mode_set(priv, vic, ycrcb_map, yuv420_mode, mode);
|
|
|
|
/* VCLK Set clock */
|
|
meson_encoder_hdmi_set_vclk(encoder_hdmi, mode);
|
|
|
|
if (encoder_hdmi->output_bus_fmt == MEDIA_BUS_FMT_UYYVYY8_0_5X24)
|
|
/* Setup YUV420 to HDMI-TX, no 10bit diphering */
|
|
writel_relaxed(2 | (2 << 2),
|
|
priv->io_base + _REG(VPU_HDMI_FMT_CTRL));
|
|
else if (encoder_hdmi->output_bus_fmt == MEDIA_BUS_FMT_UYVY8_1X16)
|
|
/* Setup YUV422 to HDMI-TX, no 10bit diphering */
|
|
writel_relaxed(1 | (2 << 2),
|
|
priv->io_base + _REG(VPU_HDMI_FMT_CTRL));
|
|
else
|
|
/* Setup YUV444 to HDMI-TX, no 10bit diphering */
|
|
writel_relaxed(0, priv->io_base + _REG(VPU_HDMI_FMT_CTRL));
|
|
|
|
dev_dbg(priv->dev, "%s\n", priv->venc.hdmi_use_enci ? "VENCI" : "VENCP");
|
|
|
|
if (priv->venc.hdmi_use_enci)
|
|
writel_relaxed(1, priv->io_base + _REG(ENCI_VIDEO_EN));
|
|
else
|
|
writel_relaxed(1, priv->io_base + _REG(ENCP_VIDEO_EN));
|
|
}
|
|
|
|
static void meson_encoder_hdmi_atomic_disable(struct drm_bridge *bridge,
|
|
struct drm_bridge_state *bridge_state)
|
|
{
|
|
struct meson_encoder_hdmi *encoder_hdmi = bridge_to_meson_encoder_hdmi(bridge);
|
|
struct meson_drm *priv = encoder_hdmi->priv;
|
|
|
|
writel_bits_relaxed(0x3, 0,
|
|
priv->io_base + _REG(VPU_HDMI_SETTING));
|
|
|
|
writel_relaxed(0, priv->io_base + _REG(ENCI_VIDEO_EN));
|
|
writel_relaxed(0, priv->io_base + _REG(ENCP_VIDEO_EN));
|
|
}
|
|
|
|
static const u32 meson_encoder_hdmi_out_bus_fmts[] = {
|
|
MEDIA_BUS_FMT_YUV8_1X24,
|
|
MEDIA_BUS_FMT_UYVY8_1X16,
|
|
MEDIA_BUS_FMT_UYYVYY8_0_5X24,
|
|
};
|
|
|
|
static u32 *
|
|
meson_encoder_hdmi_get_inp_bus_fmts(struct drm_bridge *bridge,
|
|
struct drm_bridge_state *bridge_state,
|
|
struct drm_crtc_state *crtc_state,
|
|
struct drm_connector_state *conn_state,
|
|
u32 output_fmt,
|
|
unsigned int *num_input_fmts)
|
|
{
|
|
u32 *input_fmts = NULL;
|
|
int i;
|
|
|
|
*num_input_fmts = 0;
|
|
|
|
for (i = 0 ; i < ARRAY_SIZE(meson_encoder_hdmi_out_bus_fmts) ; ++i) {
|
|
if (output_fmt == meson_encoder_hdmi_out_bus_fmts[i]) {
|
|
*num_input_fmts = 1;
|
|
input_fmts = kcalloc(*num_input_fmts,
|
|
sizeof(*input_fmts),
|
|
GFP_KERNEL);
|
|
if (!input_fmts)
|
|
return NULL;
|
|
|
|
input_fmts[0] = output_fmt;
|
|
|
|
break;
|
|
}
|
|
}
|
|
|
|
return input_fmts;
|
|
}
|
|
|
|
static int meson_encoder_hdmi_atomic_check(struct drm_bridge *bridge,
|
|
struct drm_bridge_state *bridge_state,
|
|
struct drm_crtc_state *crtc_state,
|
|
struct drm_connector_state *conn_state)
|
|
{
|
|
struct meson_encoder_hdmi *encoder_hdmi = bridge_to_meson_encoder_hdmi(bridge);
|
|
struct drm_connector_state *old_conn_state =
|
|
drm_atomic_get_old_connector_state(conn_state->state, conn_state->connector);
|
|
struct meson_drm *priv = encoder_hdmi->priv;
|
|
|
|
encoder_hdmi->output_bus_fmt = bridge_state->output_bus_cfg.format;
|
|
|
|
dev_dbg(priv->dev, "output_bus_fmt %lx\n", encoder_hdmi->output_bus_fmt);
|
|
|
|
if (!drm_connector_atomic_hdr_metadata_equal(old_conn_state, conn_state))
|
|
crtc_state->mode_changed = true;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void meson_encoder_hdmi_hpd_notify(struct drm_bridge *bridge,
|
|
enum drm_connector_status status)
|
|
{
|
|
struct meson_encoder_hdmi *encoder_hdmi = bridge_to_meson_encoder_hdmi(bridge);
|
|
struct edid *edid;
|
|
|
|
if (!encoder_hdmi->cec_notifier)
|
|
return;
|
|
|
|
if (status == connector_status_connected) {
|
|
edid = drm_bridge_get_edid(encoder_hdmi->next_bridge, encoder_hdmi->connector);
|
|
if (!edid)
|
|
return;
|
|
|
|
cec_notifier_set_phys_addr_from_edid(encoder_hdmi->cec_notifier, edid);
|
|
} else
|
|
cec_notifier_phys_addr_invalidate(encoder_hdmi->cec_notifier);
|
|
}
|
|
|
|
static const struct drm_bridge_funcs meson_encoder_hdmi_bridge_funcs = {
|
|
.attach = meson_encoder_hdmi_attach,
|
|
.detach = meson_encoder_hdmi_detach,
|
|
.mode_valid = meson_encoder_hdmi_mode_valid,
|
|
.hpd_notify = meson_encoder_hdmi_hpd_notify,
|
|
.atomic_enable = meson_encoder_hdmi_atomic_enable,
|
|
.atomic_disable = meson_encoder_hdmi_atomic_disable,
|
|
.atomic_get_input_bus_fmts = meson_encoder_hdmi_get_inp_bus_fmts,
|
|
.atomic_check = meson_encoder_hdmi_atomic_check,
|
|
.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
|
|
.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
|
|
.atomic_reset = drm_atomic_helper_bridge_reset,
|
|
};
|
|
|
|
int meson_encoder_hdmi_init(struct meson_drm *priv)
|
|
{
|
|
struct meson_encoder_hdmi *meson_encoder_hdmi;
|
|
struct platform_device *pdev;
|
|
struct device_node *remote;
|
|
int ret;
|
|
|
|
meson_encoder_hdmi = devm_kzalloc(priv->dev, sizeof(*meson_encoder_hdmi), GFP_KERNEL);
|
|
if (!meson_encoder_hdmi)
|
|
return -ENOMEM;
|
|
|
|
/* HDMI Transceiver Bridge */
|
|
remote = of_graph_get_remote_node(priv->dev->of_node, 1, 0);
|
|
if (!remote) {
|
|
dev_err(priv->dev, "HDMI transceiver device is disabled");
|
|
return 0;
|
|
}
|
|
|
|
meson_encoder_hdmi->next_bridge = of_drm_find_bridge(remote);
|
|
if (!meson_encoder_hdmi->next_bridge) {
|
|
dev_err(priv->dev, "Failed to find HDMI transceiver bridge\n");
|
|
ret = -EPROBE_DEFER;
|
|
goto err_put_node;
|
|
}
|
|
|
|
/* HDMI Encoder Bridge */
|
|
meson_encoder_hdmi->bridge.funcs = &meson_encoder_hdmi_bridge_funcs;
|
|
meson_encoder_hdmi->bridge.of_node = priv->dev->of_node;
|
|
meson_encoder_hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
|
|
meson_encoder_hdmi->bridge.interlace_allowed = true;
|
|
|
|
drm_bridge_add(&meson_encoder_hdmi->bridge);
|
|
|
|
meson_encoder_hdmi->priv = priv;
|
|
|
|
/* Encoder */
|
|
ret = drm_simple_encoder_init(priv->drm, &meson_encoder_hdmi->encoder,
|
|
DRM_MODE_ENCODER_TMDS);
|
|
if (ret) {
|
|
dev_err(priv->dev, "Failed to init HDMI encoder: %d\n", ret);
|
|
goto err_put_node;
|
|
}
|
|
|
|
meson_encoder_hdmi->encoder.possible_crtcs = BIT(0);
|
|
|
|
/* Attach HDMI Encoder Bridge to Encoder */
|
|
ret = drm_bridge_attach(&meson_encoder_hdmi->encoder, &meson_encoder_hdmi->bridge, NULL,
|
|
DRM_BRIDGE_ATTACH_NO_CONNECTOR);
|
|
if (ret) {
|
|
dev_err(priv->dev, "Failed to attach bridge: %d\n", ret);
|
|
goto err_put_node;
|
|
}
|
|
|
|
/* Initialize & attach Bridge Connector */
|
|
meson_encoder_hdmi->connector = drm_bridge_connector_init(priv->drm,
|
|
&meson_encoder_hdmi->encoder);
|
|
if (IS_ERR(meson_encoder_hdmi->connector)) {
|
|
dev_err(priv->dev, "Unable to create HDMI bridge connector\n");
|
|
ret = PTR_ERR(meson_encoder_hdmi->connector);
|
|
goto err_put_node;
|
|
}
|
|
drm_connector_attach_encoder(meson_encoder_hdmi->connector,
|
|
&meson_encoder_hdmi->encoder);
|
|
|
|
/*
|
|
* We should have now in place:
|
|
* encoder->[hdmi encoder bridge]->[dw-hdmi bridge]->[display connector bridge]->[display connector]
|
|
*/
|
|
|
|
/*
|
|
* drm_connector_attach_max_bpc_property() requires the
|
|
* connector to have a state.
|
|
*/
|
|
drm_atomic_helper_connector_reset(meson_encoder_hdmi->connector);
|
|
|
|
if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_GXL) ||
|
|
meson_vpu_is_compatible(priv, VPU_COMPATIBLE_GXM) ||
|
|
meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A))
|
|
drm_connector_attach_hdr_output_metadata_property(meson_encoder_hdmi->connector);
|
|
|
|
drm_connector_attach_max_bpc_property(meson_encoder_hdmi->connector, 8, 8);
|
|
|
|
/* Handle this here until handled by drm_bridge_connector_init() */
|
|
meson_encoder_hdmi->connector->ycbcr_420_allowed = true;
|
|
|
|
pdev = of_find_device_by_node(remote);
|
|
of_node_put(remote);
|
|
if (pdev) {
|
|
struct cec_connector_info conn_info;
|
|
struct cec_notifier *notifier;
|
|
|
|
cec_fill_conn_info_from_drm(&conn_info, meson_encoder_hdmi->connector);
|
|
|
|
notifier = cec_notifier_conn_register(&pdev->dev, NULL, &conn_info);
|
|
if (!notifier) {
|
|
put_device(&pdev->dev);
|
|
return -ENOMEM;
|
|
}
|
|
|
|
meson_encoder_hdmi->cec_notifier = notifier;
|
|
}
|
|
|
|
priv->encoders[MESON_ENC_HDMI] = meson_encoder_hdmi;
|
|
|
|
dev_dbg(priv->dev, "HDMI encoder initialized\n");
|
|
|
|
return 0;
|
|
|
|
err_put_node:
|
|
of_node_put(remote);
|
|
return ret;
|
|
}
|
|
|
|
void meson_encoder_hdmi_remove(struct meson_drm *priv)
|
|
{
|
|
struct meson_encoder_hdmi *meson_encoder_hdmi;
|
|
|
|
if (priv->encoders[MESON_ENC_HDMI]) {
|
|
meson_encoder_hdmi = priv->encoders[MESON_ENC_HDMI];
|
|
drm_bridge_remove(&meson_encoder_hdmi->bridge);
|
|
drm_bridge_remove(meson_encoder_hdmi->next_bridge);
|
|
}
|
|
}
|