Zheng Liu
dda5690def
ext3: fix a BUG when opening a file with O_TMPFILE flag ...
When we try to open a file with O_TMPFILE flag, we will trigger a bug.
The root cause is that in ext4_orphan_add() we check ->i_nlink == 0 and
this check always fails because we set ->i_nlink = 1 in
inode_init_always(). We can use the following program to trigger it:
int main(int argc, char *argv[])
{
int fd;
fd = open(argv[1], O_TMPFILE, 0666);
if (fd < 0) {
perror("open ");
return -1;
}
close(fd);
return 0;
}
The oops message looks like this:
kernel: kernel BUG at fs/ext3/namei.c:1992!
kernel: invalid opcode: 0000 [#1 ] SMP
kernel: Modules linked in: ext4 jbd2 crc16 cpufreq_ondemand ipv6 dm_mirror dm_region_hash dm_log dm_mod parport_pc parport serio_raw sg dcdbas pcspkr i2c_i801 ehci_pci ehci_hcd button acpi_cpufreq mperf e1000e ptp pps_core ttm drm_kms_helper drm hwmon i2c_algo_bit i2c_core ext3 jbd sd_mod ahci libahci libata scsi_mod uhci_hcd
kernel: CPU: 0 PID: 2882 Comm: tst_tmpfile Not tainted 3.11.0-rc1+ #4
kernel: Hardware name: Dell Inc. OptiPlex 780 /0V4W66, BIOS A05 08/11/2010
kernel: task: ffff880112d30050 ti: ffff8801124d4000 task.ti: ffff8801124d4000
kernel: RIP: 0010:[<ffffffffa00db5ae>] [<ffffffffa00db5ae>] ext3_orphan_add+0x6a/0x1eb [ext3]
kernel: RSP: 0018:ffff8801124d5cc8 EFLAGS: 00010202
kernel: RAX: 0000000000000000 RBX: ffff880111510128 RCX: ffff8801114683a0
kernel: RDX: 0000000000000000 RSI: ffff880111510128 RDI: ffff88010fcf65a8
kernel: RBP: ffff8801124d5d18 R08: 0080000000000000 R09: ffffffffa00d3b7f
kernel: R10: ffff8801114683a0 R11: ffff8801032a2558 R12: 0000000000000000
kernel: R13: ffff88010fcf6800 R14: ffff8801032a2558 R15: ffff8801115100d8
kernel: FS: 00007f5d172b5700(0000) GS:ffff880117c00000(0000) knlGS:0000000000000000
kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
kernel: CR2: 00007f5d16df15d0 CR3: 0000000110b1d000 CR4: 00000000000407f0
kernel: Stack:
kernel: 000000000000000c ffff8801048a7dc8 ffff8801114685a8 ffffffffa00b80d7
kernel: ffff8801124d5e38 ffff8801032a2558 ffff88010ce24d68 0000000000000000
kernel: ffff88011146b300 ffff8801124d5d44 ffff8801124d5d78 ffffffffa00db7e1
kernel: Call Trace:
kernel: [<ffffffffa00b80d7>] ? journal_start+0x8c/0xbd [jbd]
kernel: [<ffffffffa00db7e1>] ext3_tmpfile+0xb2/0x13b [ext3]
kernel: [<ffffffff821076f8>] path_openat+0x11f/0x5e7
kernel: [<ffffffff821c86b4>] ? list_del+0x11/0x30
kernel: [<ffffffff82065fa2>] ? __dequeue_entity+0x33/0x38
kernel: [<ffffffff82107cd5>] do_filp_open+0x3f/0x8d
kernel: [<ffffffff82112532>] ? __alloc_fd+0x50/0x102
kernel: [<ffffffff820f9296>] do_sys_open+0x13b/0x1cd
kernel: [<ffffffff820f935c>] SyS_open+0x1e/0x20
kernel: [<ffffffff82398c02>] system_call_fastpath+0x16/0x1b
kernel: Code: 39 c7 0f 85 67 01 00 00 0f b7 03 25 00 f0 00 00 3d 00 40 00 00 74 18 3d 00 80 00 00 74 11 3d 00 a0 00 00 74 0a 83 7b 48 00 74 04 <0f> 0b eb fe 49 8b 85 50 03 00 00 4c 89 f6 48 c7 c7 c0 99 0e a0
kernel: RIP [<ffffffffa00db5ae>] ext3_orphan_add+0x6a/0x1eb [ext3]
kernel: RSP <ffff8801124d5cc8>
Here we couldn't call clear_nlink() directly because in d_tmpfile() we
will call inode_dec_link_count() to decrease ->i_nlink. So this commit
tries to call d_tmpfile() before ext4_orphan_add() to fix this problem.
Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@zeniv.linux.org.uk>
2013-07-20 22:03:20 -04:00
2013-07-11 10:21:23 -07:00
2013-06-29 12:57:36 +04:00
2013-06-29 12:57:36 +04:00
2013-07-03 09:10:19 -07:00
2013-07-05 18:59:33 +04:00
2013-06-29 12:56:55 +04:00
2013-06-29 12:56:33 +04:00
2013-07-19 15:07:26 -04:00
2013-07-03 16:07:31 -07:00
2013-07-09 12:39:10 -07:00
2013-07-11 18:05:41 -05:00
2013-07-05 18:59:33 +04:00
2013-07-14 11:42:26 -07:00
2013-06-29 12:56:46 +04:00
2013-06-03 13:55:02 -07:00
2013-03-07 01:08:55 -08:00
2013-06-26 11:38:02 -05:00
2013-07-11 10:20:18 -07:00
2013-07-14 17:48:35 +04:00
2013-06-29 12:56:31 +04:00
2013-07-02 09:39:34 -07:00
2013-06-29 12:57:05 +04:00
2013-06-29 12:57:10 +04:00
2013-07-20 22:03:20 -04:00
2013-07-20 21:58:38 -04:00
2013-07-08 13:35:48 +04:00
2013-07-09 10:33:25 -07:00
2013-06-29 12:56:53 +04:00
2013-06-19 14:16:47 +01:00
2013-07-03 16:07:35 -07:00
2013-07-03 09:10:19 -07:00
2013-06-29 12:57:36 +04:00
2013-06-29 12:57:36 +04:00
2013-06-29 12:56:59 +04:00
2013-07-04 11:22:55 -07:00
2013-07-03 16:07:41 -07:00
2013-05-07 18:38:27 -07:00
2013-06-29 12:57:36 +04:00
2013-05-21 23:26:36 -04:00
2013-07-01 08:12:41 -04:00
2013-06-29 12:56:47 +04:00
2013-07-11 10:19:34 -07:00
2013-07-17 13:43:55 -07:00
2013-07-02 09:39:34 -07:00
2013-06-29 12:57:35 +04:00
2013-07-09 10:33:25 -07:00
2013-07-17 16:54:46 -04:00
2013-02-13 06:15:14 -08:00
2013-07-17 13:43:55 -07:00
2013-07-05 18:59:33 +04:00
2013-07-09 10:33:20 -07:00
2013-07-02 09:39:34 -07:00
2013-07-03 16:07:25 -07:00
2013-06-29 12:56:37 +04:00
2013-06-29 12:56:32 +04:00
2013-07-18 13:40:18 +02:00
2013-07-04 10:29:23 -07:00
2013-06-29 12:56:38 +04:00
2013-06-29 12:56:39 +04:00
2013-07-04 19:22:55 +02:00
2013-02-26 20:16:07 -08:00
2013-07-02 09:39:34 -07:00
2013-06-29 12:56:29 +04:00
2013-06-29 12:56:28 +04:00
2013-07-16 10:57:36 -07:00
2013-06-29 12:57:36 +04:00
2013-07-05 12:08:47 -07:00
2013-06-29 12:57:12 +04:00
2013-06-29 12:46:47 +04:00
2013-07-13 11:40:24 -07:00
2013-07-03 16:08:06 -07:00
2013-02-26 02:46:11 -05:00
2013-06-29 12:57:04 +04:00
2013-07-10 18:11:34 -07:00
2013-05-02 10:16:16 -07:00
2013-07-10 18:11:34 -07:00
2012-12-17 17:15:23 -08:00
2013-04-29 15:40:23 -04:00
2013-04-30 17:04:03 -07:00
2012-12-20 17:40:19 -08:00
2013-03-23 14:26:34 -07:00
2013-05-08 10:13:35 -07:00
2013-07-11 13:03:24 -07:00
2013-07-03 16:07:29 -07:00
2013-06-29 12:46:44 +04:00
2013-06-29 12:57:05 +04:00
2013-07-03 16:08:02 -07:00
2013-07-03 09:10:19 -07:00
2013-03-03 23:00:23 -05:00
2013-05-08 10:13:35 -07:00
2012-12-17 17:15:27 -08:00
2013-07-03 17:12:13 -07:00
2013-07-03 16:08:03 -07:00
2013-02-22 23:31:31 -05:00
2012-12-20 14:04:11 -08:00
2013-07-13 13:29:10 +04:00
2013-05-01 17:31:42 -04:00
2013-03-03 19:36:31 -08:00
2013-03-01 23:51:07 -05:00
2013-07-09 10:33:22 -07:00
2013-06-29 12:57:11 +04:00
2013-06-29 12:57:34 +04:00
2013-02-22 23:31:31 -05:00
2013-04-17 13:25:09 +01:00
2013-04-30 17:04:04 -07:00
2013-07-14 17:43:25 +04:00
2013-07-08 13:36:42 +04:00
2013-05-01 17:51:54 -07:00
2013-04-09 14:12:52 -04:00
2013-07-13 13:26:37 +04:00
2013-05-04 15:18:53 -04:00
2013-07-20 03:11:32 +04:00
2013-05-07 20:16:25 -07:00
2013-05-31 15:16:33 -04:00
2013-05-01 17:51:54 -07:00
2013-07-03 16:23:27 +04:00
2013-06-29 12:57:05 +04:00
2013-07-10 17:08:27 -07:00
2013-07-08 13:36:41 +04:00
2013-03-03 22:58:46 -05:00
2013-07-03 09:10:19 -07:00
2013-02-26 02:46:08 -05:00
2012-12-20 18:50:07 -05:00
2013-07-20 04:58:58 +04:00
2013-03-03 22:46:22 -05:00
2013-05-29 12:57:34 -07:00
2012-12-20 18:50:08 -05:00
2012-12-20 18:50:11 -05:00
dda5690def