iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Davide Caratti f77bd544a6 net/sched: act_ct: fix wild memory access when clearing fragments 
while testing re-assembly/re-fragmentation using act_ct, it's possible to
observe a crash like the following one:

 KASAN: maybe wild-memory-access in range [0x0001000000000448-0x000100000000044f]
 CPU: 50 PID: 0 Comm: swapper/50 Tainted: G S                5.12.0-rc7+ #424
 Hardware name: Dell Inc. PowerEdge R730/072T6D, BIOS 2.4.3 01/17/2017
 RIP: 0010:inet_frag_rbtree_purge+0x50/0xc0
 Code: 00 fc ff df 48 89 c3 31 ed 48 89 df e8 a9 7a 38 ff 4c 89 fe 48 89 df 49 89 c6 e8 5b 3a 38 ff 48 8d 7b 40 48 89 f8 48 c1 e8 03 <42> 80 3c 20 00 75 59 48 8d bb d0 00 00 00 4c 8b 6b 40 48 89 f8 48
 RSP: 0018:ffff888c31449db8 EFLAGS: 00010203
 RAX: 0000200000000089 RBX: 000100000000040e RCX: ffffffff989eb960
 RDX: 0000000000000140 RSI: ffffffff97cfb977 RDI: 000100000000044e
 RBP: 0000000000000900 R08: 0000000000000000 R09: ffffed1186289350
 R10: 0000000000000003 R11: ffffed1186289350 R12: dffffc0000000000
 R13: 000100000000040e R14: 0000000000000000 R15: ffff888155e02160
 FS:  0000000000000000(0000) GS:ffff888c31440000(0000) knlGS:0000000000000000
 CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 00005600cb70a5b8 CR3: 0000000a2c014005 CR4: 00000000003706e0
 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
 Call Trace:
  <IRQ>
  inet_frag_destroy+0xa9/0x150
  call_timer_fn+0x2d/0x180
  run_timer_softirq+0x4fe/0xe70
  __do_softirq+0x197/0x5a0
  irq_exit_rcu+0x1de/0x200
  sysvec_apic_timer_interrupt+0x6b/0x80
  </IRQ>

when act_ct temporarily stores an IP fragment, restoring the skb qdisc cb
results in putting random data in FRAG_CB(), and this causes those "wild"
memory accesses later, when the rbtree is purged. Never overwrite the skb
cb in case tcf_ct_handle_fragments() returns -EINPROGRESS.

Fixes: ae372cb1750f ("net/sched: act_ct: fix restore the qdisc_skb_cb after defrag")
Fixes: 7baf2429a1a9 ("net/sched: cls_flower add CT_FLAGS_INVALID flag support")
Reported-by: Shuang Li <shuali@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-04-26 13:06:39 -07:00
..
act_api.c
net: sched: fix err handler in tcf_action_init()
2021-04-08 13:47:33 -07:00
act_bpf.c
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
act_connmark.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_csum.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_ct.c
net/sched: act_ct: fix wild memory access when clearing fragments
2021-04-26 13:06:39 -07:00
act_ctinfo.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-10-05 18:40:01 -07:00
act_gact.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_gate.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-10-05 18:40:01 -07:00
act_ife.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_ipt.c
treewide: rename nla_strlcpy to nla_strscpy.
2020-11-16 08:08:54 -08:00
act_meta_mark.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbprio.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_mirred.c
net/sched: sch_frag: add generic packet fragment support.
2020-11-27 14:36:02 -08:00
act_mpls.c
net/sched: act_mpls: ensure LSE is pullable before reading it
2020-12-03 11:13:37 -08:00
act_nat.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_pedit.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_police.c
net/sched: act_police: add support for packet-per-second policing
2021-03-13 14:18:09 -08:00
act_sample.c
psample: Encapsulate packet metadata in a struct
2021-03-14 15:00:43 -07:00
act_simple.c
treewide: rename nla_strlcpy to nla_strscpy.
2020-11-16 08:08:54 -08:00
act_skbedit.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_skbmod.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_tunnel_key.c
net/sched: act_tunnel_key: fix OOB write in case of IPv6 ERSPAN tunnels
2020-10-20 21:10:41 -07:00
act_vlan.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-10-05 18:40:01 -07:00
cls_api.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2021-04-09 20:48:35 -07:00
cls_basic.c
net_sched: fix ops->bind_class() implementations
2020-01-27 10:51:43 +01:00
cls_bpf.c
net_sched: fix ops->bind_class() implementations
2020-01-27 10:51:43 +01:00
cls_cgroup.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_flow.c
Remove uninitialized_var() macro for v5.9-rc1
2020-08-04 13:49:43 -07:00
cls_flower.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2021-03-25 15:31:22 -07:00
cls_fw.c
net_sched: fix ops->bind_class() implementations
2020-01-27 10:51:43 +01:00
cls_matchall.c
net: qos offload add flow status with dropped count
2020-06-19 12:53:30 -07:00
cls_route.c
net_sched: cls_route: remove the right filter from hashtable
2020-03-16 01:59:32 -07:00
cls_rsvp6.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_rsvp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_rsvp.h
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
cls_tcindex.c
net_sched: avoid shift-out-of-bounds in tcindex_set_parms()
2021-01-15 18:11:10 -08:00
cls_u32.c
net/sched: cls_u32: simplify the return expression of u32_reoffload_knode()
2020-12-08 16:22:53 -08:00
em_canid.c
net: sched: kerneldoc fixes
2020-07-13 17:20:40 -07:00
em_cmp.c
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
em_ipset.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_ipt.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_meta.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_nbyte.c
net: sched: Return the correct errno code
2021-02-06 11:15:28 -08:00
em_text.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
em_u32.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
ematch.c
net: sched: kerneldoc fixes
2020-07-13 17:20:40 -07:00
Kconfig
net: sched: incorrect Kconfig dependencies on Netfilter modules
2020-12-09 15:49:29 -08:00
Makefile
net/sched: sch_frag: add generic packet fragment support.
2020-11-27 14:36:02 -08:00
sch_api.c
net: sched: avoid duplicates in classes dump
2021-03-04 14:27:47 -08:00
sch_atm.c
net: sched: Add extack to Qdisc_class_ops.delete
2021-01-22 20:41:29 -08:00
sch_blackhole.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_cake.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
sch_cbq.c
net: sched: Mundane typo fixes
2021-03-24 15:09:11 -07:00
sch_cbs.c
net: don't include ethtool.h from netdevice.h
2020-11-23 17:27:04 -08:00
sch_choke.c
net: sched: validate stab values
2021-03-10 15:47:52 -08:00
sch_codel.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_drr.c
net: sched: Add extack to Qdisc_class_ops.delete
2021-01-22 20:41:29 -08:00
sch_dsmark.c
net: sched: Add extack to Qdisc_class_ops.delete
2021-01-22 20:41:29 -08:00
sch_etf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_ets.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_fifo.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_fq_codel.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-08-05 20:13:21 -07:00
sch_fq_pie.c
net/sched: fq_pie: initialize timer earlier in fq_pie_init()
2020-12-04 14:15:01 -08:00
sch_fq.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_frag.c
net/sched: sch_frag: add generic packet fragment support.
2020-11-27 14:36:02 -08:00
sch_generic.c
net/sched: act_police: add support for packet-per-second policing
2021-03-13 14:18:09 -08:00
sch_gred.c
net: sched: validate stab values
2021-03-10 15:47:52 -08:00
sch_hfsc.c
net: sched: Add extack to Qdisc_class_ops.delete
2021-01-22 20:41:29 -08:00
sch_hhf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_htb.c
sch_htb: fix null pointer dereference on a null new_q
2021-03-30 13:50:03 -07:00
sch_ingress.c
net: sched: Pass ingress block to tcf_classify_ingress
2020-02-19 17:49:48 -08:00
sch_mq.c
net: sched: fix dump qlen for sch_mq/sch_mqprio with NOLOCK subqueues
2019-12-03 11:53:55 -08:00
sch_mqprio.c
mqprio: Fix out-of-bounds access in mqprio_dump
2019-12-06 11:58:45 -08:00
sch_multiq.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_netem.c
netem: fix zero division in tabledist
2020-10-29 11:45:47 -07:00
sch_pie.c
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
sch_plug.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_prio.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_qfq.c
net: sched: Add extack to Qdisc_class_ops.delete
2021-01-22 20:41:29 -08:00
sch_red.c
net: sched: validate stab values
2021-03-10 15:47:52 -08:00
sch_sfb.c
net: sched: Add extack to Qdisc_class_ops.delete
2021-01-22 20:41:29 -08:00
sch_sfq.c
net: sched: validate stab values
2021-03-10 15:47:52 -08:00
sch_skbprio.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_taprio.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2021-04-26 12:00:00 -07:00
sch_tbf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_teql.c
net: sched: sch_teql: fix null-pointer dereference
2021-04-08 14:14:42 -07:00