linux/sound/soc
Dan Carpenter fa9b878ff8
ASoC: SOF: ipc-msg-injector: fix copy in sof_msg_inject_ipc4_dfs_write()
There are two bugs that have to do with when we copy the payload:

	size = simple_write_to_buffer(ipc4_msg->data_ptr,
			      priv->max_msg_size, ppos, buffer,
			      count);

The value of "*ppos" was supposed to be zero but it is
sizeof(ipc4_msg->header_u64) so it will copy the data into the middle of
the "ipc4_msg->data_ptr" buffer instead of to the start.  The second
problem is "buffer" should be "buffer + sizeof(ipc4_msg->header_u64)".

This function is used for fuzz testing so the data is normally random
and this bug likely does not affect anyone very much.

In this context, it's simpler and more appropriate to use copy_from_user()
instead of simple_write_to_buffer() so I have re-written the function.

Fixes: 066c67624d ("ASoC: SOF: ipc-msg-injector: Add support for IPC4 messages")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Ysg1tB2FKLnRMsel@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
2022-07-14 13:26:37 +01:00
..
adi ASoC: adi: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:34 +01:00
amd ASoC: amd: fix Jadeite kconfig warning and build errors 2022-07-13 13:48:55 +01:00
atmel ASoC: atmel: mchp-pdmc: remove space in front of mchp_pdmc_dt_init() 2022-07-11 16:16:12 +01:00
au1x ASoC: au1x: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:39 +01:00
bcm ASoC: bcm: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:21 +01:00
cirrus ASoC: ep93xx: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:20 +01:00
codecs ASoC: mt6359: Fix refcount leak bug 2022-07-13 13:48:56 +01:00
dwc ASoC: dwc: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:35 +01:00
fsl ASoC: fsl_utils: Drop usage of __clk_get_name() 2022-07-11 12:06:29 +01:00
generic ASoc: audio-graph-card2: Fix refcount leak bug in __graph_get_type() 2022-07-13 13:48:54 +01:00
hisilicon ASoC: hisilicon: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:24 +01:00
img ASoC: Refactor non_legacy_dai_naming flag 2022-06-29 16:58:08 +01:00
intel ASoC: Intel: avs: Updates and cleanups 2022-07-11 22:13:49 +01:00
jz4740 ASoC: jz4740-i2s: Refactor DMA channel setup 2022-07-07 12:23:43 +01:00
kirkwood
mediatek ASoC: mediatek: mt8186: Remove condition with no effect 2022-07-11 12:06:28 +01:00
meson ASoC: meson: Remove now redundant non_legacy_dai_naming flag 2022-06-27 13:16:48 +01:00
mxs ASoC: mxs-saif: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:43 +01:00
pxa ASoC: pxa: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:40 +01:00
qcom ASoC: Merge up fixes 2022-07-11 15:51:01 +01:00
rockchip ASoC: Merge up fixes 2022-07-11 15:51:01 +01:00
samsung ASoC: samsung: change neo1973_audio from a global to static 2022-06-30 13:40:29 +01:00
sh ASoC: rsnd: Emit useful error messages in .remove() 2022-07-06 15:20:22 +01:00
sof ASoC: SOF: ipc-msg-injector: fix copy in sof_msg_inject_ipc4_dfs_write() 2022-07-14 13:26:37 +01:00
spear ASoC: spear: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:18 +01:00
sprd
sti ASoC: sti-uniperf: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:29 +01:00
stm ASoC: stm32: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:20 +01:00
sunxi ASoC: Refactor non_legacy_dai_naming flag 2022-06-29 16:58:08 +01:00
tegra ASoC: tegra: tegra20_das: Drop write-only driver data member 2022-07-05 19:54:00 +01:00
ti ASoC: Merge up fixes 2022-07-11 15:51:01 +01:00
uniphier ASoC: uniphier: Remove now redundant non_legacy_dai_naming flag 2022-06-27 13:16:55 +01:00
ux500 ASoC: ux500: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:41 +01:00
xilinx ASoC: xilinx: Suppress second error message about reset failure in .remove() 2022-07-05 16:44:31 +01:00
xtensa ASoC: xtensa: Migrate to new style legacy DAI naming flag 2022-06-27 13:16:33 +01:00
Kconfig ASoC: soc-utils: Add kunit test for snd_soc_tdm_params_to_bclk() 2022-04-05 18:27:56 +01:00
Makefile ASoC: soc-utils: Add kunit test for snd_soc_tdm_params_to_bclk() 2022-04-05 18:27:56 +01:00
soc-ac97.c
soc-acpi.c
soc-card.c ASoC: Introduce 'fixup_controls' card method 2022-06-10 13:32:20 +01:00
soc-component.c ASoC: soc-component: Update handling to component delays 2022-05-16 12:58:41 +01:00
soc-compress.c ASoC: soc-compress: Change the check for codec_dai 2022-03-14 08:29:11 +00:00
soc-core.c ASoC: soc-core.c: share code for snd_soc_of_get_dai_link_cpus/codecs() 2022-06-29 18:10:15 +01:00
soc-dai.c ASoC: soc-dai: Remove set_fmt_new callback 2022-06-06 12:34:21 +01:00
soc-dapm.c ASoC: Merge up fixes 2022-06-27 18:27:03 +01:00
soc-devres.c
soc-generic-dmaengine-pcm.c ASoC: soc-generic-dmaengine-pcm: Use default config when none is given 2022-05-04 15:31:19 +01:00
soc-jack.c ASoC: soc-card: Create jack kcontrol without pins 2022-04-14 17:37:21 +01:00
soc-link.c
soc-ops.c ASoC: ops: Fix integer detection for when max possible values > 1 2022-06-17 18:25:23 +01:00
soc-pcm.c ASoC: soc-pcm: demote warnings on non-atomic BE connection 2022-07-12 13:45:07 +01:00
soc-topology-test.c ASoC: topology: KUnit: Remove now redundant non_legacy_dai_naming flag 2022-06-27 13:16:54 +01:00
soc-topology.c ASoC: Pull in fixes 2022-04-05 10:29:12 +01:00
soc-utils-test.c ASoC: soc-utils: Add kunit test for snd_soc_tdm_params_to_bclk() 2022-04-05 18:27:56 +01:00
soc-utils.c ASoC: soc-utils: Remove now redundant non_legacy_dai_naming flag 2022-06-27 13:16:51 +01:00