iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/ext4
History
Ye Bin fae381a3d7 ext4: init quota for 'old.inode' in 'ext4_rename' 
Syzbot found the following issue:
ext4_parse_param: s_want_extra_isize=128
ext4_inode_info_init: s_want_extra_isize=32
ext4_rename: old.inode=ffff88823869a2c8 old.dir=ffff888238699828 new.inode=ffff88823869d7e8 new.dir=ffff888238699828
__ext4_mark_inode_dirty: inode=ffff888238699828 ea_isize=32 want_ea_size=128
__ext4_mark_inode_dirty: inode=ffff88823869a2c8 ea_isize=32 want_ea_size=128
ext4_xattr_block_set: inode=ffff88823869a2c8
------------[ cut here ]------------
WARNING: CPU: 13 PID: 2234 at fs/ext4/xattr.c:2070 ext4_xattr_block_set.cold+0x22/0x980
Modules linked in:
RIP: 0010:ext4_xattr_block_set.cold+0x22/0x980
RSP: 0018:ffff888227d3f3b0 EFLAGS: 00010202
RAX: 0000000000000001 RBX: ffff88823007a000 RCX: 0000000000000000
RDX: 0000000000000a03 RSI: 0000000000000040 RDI: ffff888230078178
RBP: 0000000000000000 R08: 000000000000002c R09: ffffed1075c7df8e
R10: ffff8883ae3efc6b R11: ffffed1075c7df8d R12: 0000000000000000
R13: ffff88823869a2c8 R14: ffff8881012e0460 R15: dffffc0000000000
FS:  00007f350ac1f740(0000) GS:ffff8883ae200000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f350a6ed6a0 CR3: 0000000237456000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 ? ext4_xattr_set_entry+0x3b7/0x2320
 ? ext4_xattr_block_set+0x0/0x2020
 ? ext4_xattr_set_entry+0x0/0x2320
 ? ext4_xattr_check_entries+0x77/0x310
 ? ext4_xattr_ibody_set+0x23b/0x340
 ext4_xattr_move_to_block+0x594/0x720
 ext4_expand_extra_isize_ea+0x59a/0x10f0
 __ext4_expand_extra_isize+0x278/0x3f0
 __ext4_mark_inode_dirty.cold+0x347/0x410
 ext4_rename+0xed3/0x174f
 vfs_rename+0x13a7/0x2510
 do_renameat2+0x55d/0x920
 __x64_sys_rename+0x7d/0xb0
 do_syscall_64+0x3b/0xa0
 entry_SYSCALL_64_after_hwframe+0x72/0xdc

As 'ext4_rename' will modify 'old.inode' ctime and mark inode dirty,
which may trigger expand 'extra_isize' and allocate block. If inode
didn't init quota will lead to warning.  To solve above issue, init
'old.inode' firstly in 'ext4_rename'.

Reported-by: syzbot+98346927678ac3059c77@syzkaller.appspotmail.com
Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221107015335.2524319-1-yebin@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2022-12-08 21:49:24 -05:00
..
.kunitconfig
ext4: add .kunitconfig fragment to enable ext4-specific tests
2021-02-11 23:16:30 -05:00
acl.c
fs/ext4: fix comments mentioning i_mutex
2022-02-03 10:57:53 -05:00
acl.h
vfs: add rcu argument to ->get_acl() callback
2021-08-18 22:08:24 +02:00
balloc.c
ext4: use ext4_debug() instead of jbd_debug()
2022-08-02 23:52:19 -04:00
bitmap.c
…
block_validity.c
ext4: add ext4_sb_block_valid() refactored out of ext4_inode_block_valid()
2022-02-25 21:34:56 -05:00
crypto.c
ext4: refactor and move ext4_ioctl_get_encryption_pwsalt()
2022-05-21 22:24:24 -04:00
dir.c
ext4: fix spelling errors in comments
2022-05-11 15:19:06 -04:00
ext4_extents.h
ext4: fix sparse warnings
2021-08-30 23:36:50 -04:00
ext4_jbd2.c
ext4: split ext4_journal_start trace for debug
2022-12-01 10:46:54 -05:00
ext4_jbd2.h
ext4: split ext4_journal_start trace for debug
2022-12-01 10:46:54 -05:00
ext4.h
ext4: don't set up encryption key during jbd2 transaction
2022-12-08 21:49:24 -05:00
extents_status.c
ext4: factor out ext4_free_ext_path()
2022-09-30 23:46:54 -04:00
extents_status.h
ext4: fix extent_status trace points
2020-01-25 02:03:03 -05:00
extents.c
fs/ext4: replace ternary operator with min()/max() and min_t()
2022-11-29 16:10:49 -05:00
fast_commit.c
ext4: simplify fast-commit CRC calculation
2022-12-08 21:49:24 -05:00
fast_commit.h
ext4: add missing validation of fast-commit record lengths
2022-12-08 21:49:24 -05:00
file.c
The first two changes that involve files outside of fs/ext4:
2022-10-06 17:45:53 -07:00
fsmap.c
treewide: Change list_sort to use const pointers
2021-04-08 16:04:22 -07:00
fsmap.h
ext4: fsmap: fix the block/inode bitmap comment
2021-06-24 09:48:29 -04:00
fsync.c
block: use an on-stack bio in blkdev_issue_flush
2021-01-27 09:51:48 -07:00
hash.c
unicode: clean up the Kconfig symbol confusion
2022-01-20 19:57:24 -05:00
ialloc.c
ext4: split ext4_journal_start trace for debug
2022-12-01 10:46:54 -05:00
indirect.c
ext4: use ext4_debug() instead of jbd_debug()
2022-08-02 23:52:19 -04:00
inline.c
fs/ext4: replace ternary operator with min()/max() and min_t()
2022-11-29 16:10:49 -05:00
inode-test.c
fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature
2020-12-02 16:07:25 -07:00
inode.c
ext4: fix use-after-free in ext4_orphan_cleanup
2022-12-08 21:49:24 -05:00
ioctl.c
ext4: fix bug_on in __es_tree_search caused by bad boot loader inode
2022-12-08 21:49:23 -05:00
Kconfig
ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it
2021-02-11 23:12:59 -05:00
Makefile
ext4: move ext4 crypto code to its own file crypto.c
2022-05-21 22:24:24 -04:00
mballoc.c
ext4: fixup possible uninitialized variable access in ext4_mb_choose_next_group_cr1()
2022-09-26 13:21:05 -04:00
mballoc.h
ext4: use buckets for cr 1 block scan instead of rbtree
2022-09-21 22:12:03 -04:00
migrate.c
ext4: fix warning in 'ext4_da_release_space'
2022-11-06 01:07:59 -04:00
mmp.c
treewide: use get_random_u32() when possible
2022-10-11 17:42:58 -06:00
move_extent.c
ext4: factor out ext4_free_ext_path()
2022-09-30 23:46:54 -04:00
namei.c
ext4: init quota for 'old.inode' in 'ext4_rename'
2022-12-08 21:49:24 -05:00
orphan.c
ext4: remove trailing newline from ext4_msg() message
2022-12-08 21:49:23 -05:00
page-io.c
ext4: fix incorrect comment in ext4_bio_write_page()
2022-06-16 11:03:16 -04:00
readpage.c
fscrypt: stop using PG_error to track error status
2022-09-06 15:15:56 -07:00
resize.c
ext4: remove redundant variable err
2022-12-01 10:46:54 -05:00
super.c
ext4: don't allow journal inode to have encrypt flag
2022-12-08 21:49:24 -05:00
symlink.c
ext4: fix reading leftover inlined symlinks
2022-08-02 23:37:50 -04:00
sysfs.c
unicode: clean up the Kconfig symbol confusion
2022-01-20 19:57:24 -05:00
truncate.h
ext4: Convert to use mapping->invalidate_lock
2021-07-13 14:29:00 +02:00
verity.c
- Alistair Popple has a series which addresses a race which causes page
2022-10-14 12:28:43 -07:00
xattr_hurd.c
acl: handle idmapped mounts
2021-01-24 14:27:17 +01:00
xattr_security.c
acl: handle idmapped mounts
2021-01-24 14:27:17 +01:00
xattr_trusted.c
acl: handle idmapped mounts
2021-01-24 14:27:17 +01:00
xattr_user.c
acl: handle idmapped mounts
2021-01-24 14:27:17 +01:00
xattr.c
ext4: check the return value of ext4_xattr_inode_dec_ref()
2022-12-01 10:46:54 -05:00
xattr.h
ext4: remove EA inode entry from mbcache on inode eviction
2022-08-02 23:56:25 -04:00