iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/tipc
History
Wang Hai 78f6fac081 tipc: fix memory leak in tipc_topsrv_start() 
[ Upstream commit fa6882c63621821f73cc806f291208e1c6ea6187 ]

kmemleak report a memory leak as follows:

unreferenced object 0xffff88810a596800 (size 512):
  comm "ip", pid 21558, jiffies 4297568990 (age 112.120s)
  hex dump (first 32 bytes):
    00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00  .....N..........
    ff ff ff ff ff ff ff ff 00 83 60 b0 ff ff ff ff  ..........`.....
  backtrace:
    [<0000000022bbe21f>] tipc_topsrv_init_net+0x1f3/0xa70
    [<00000000fe15ddf7>] ops_init+0xa8/0x3c0
    [<00000000138af6f2>] setup_net+0x2de/0x7e0
    [<000000008c6807a3>] copy_net_ns+0x27d/0x530
    [<000000006b21adbd>] create_new_namespaces+0x382/0xa30
    [<00000000bb169746>] unshare_nsproxy_namespaces+0xa1/0x1d0
    [<00000000fe2e42bc>] ksys_unshare+0x39c/0x780
    [<0000000009ba3b19>] __x64_sys_unshare+0x2d/0x40
    [<00000000614ad866>] do_syscall_64+0x56/0xa0
    [<00000000a1b5ca3c>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

'srv' is malloced in tipc_topsrv_start() but not free before
leaving from the error handling cases. We need to free it.

Fixes: 5c45ab24ac77 ("tipc: make struct tipc_server private for server.c")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Link: https://lore.kernel.org/r/20201109140913.47370-1-wanghai38@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-11-18 19:20:33 +01:00
..
addr.c
tipc: initialise addr_trail_end when setting node addresses
2019-08-11 21:40:04 -07:00
addr.h
…
bcast.c
tipc: fix potential hanging after b/rcast changing
2020-01-23 08:22:44 +01:00
bcast.h
tipc: fix a null pointer deref
2019-03-21 09:56:55 -07:00
bearer.c
tipc: add loopback device tracking
2019-08-08 22:11:39 -07:00
bearer.h
tipc: add loopback device tracking
2019-08-08 22:11:39 -07:00
core.c
tipc: fix use-after-free in tipc_bcast_get_mode
2020-11-10 12:37:24 +01:00
core.h
tipc: add back tipc prefix to log messages
2019-11-14 18:03:03 -08:00
diag.c
tipc: switch to rhashtable iterator
2018-08-29 18:04:54 -07:00
discover.c
tipc: fix lockdep warning when reinitilaizing sockets
2018-11-17 22:01:31 -08:00
discover.h
…
eth_media.c
…
group.c
tipc: Fix memory leak in tipc_group_create_member()
2020-09-26 18:03:13 +02:00
group.h
tipc: extend sock diag for group communication
2018-06-30 21:05:42 +09:00
ib_media.c
…
Kconfig
docs: kbuild: convert docs to ReST and rename to *.rst
2019-06-14 14:21:21 -06:00
link.c
tipc: reduce sensitive to retransmit failures
2020-01-26 10:01:00 +01:00
link.h
tipc: fix missing Name entries due to half-failover
2019-05-04 00:59:51 -04:00
Makefile
tipc: enable tracepoints in tipc
2018-12-19 11:49:24 -08:00
monitor.c
tipc: update mon's self addr when node addr generated
2020-01-26 10:01:00 +01:00
monitor.h
tipc: update mon's self addr when node addr generated
2020-01-26 10:01:00 +01:00
msg.c
tipc: fix memory leak caused by tipc_buf_append()
2020-11-01 12:01:04 +01:00
msg.h
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-08-19 11:54:03 -07:00
name_distr.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-09-15 14:17:27 +02:00
name_distr.h
…
name_table.c
netlink: make nla_nest_start() add NLA_F_NESTED flag
2019-04-27 17:03:44 -04:00
name_table.h
tipc: eliminate message disordering during binding table update
2018-10-22 19:29:12 -07:00
net.c
tipc: update mon's self addr when node addr generated
2020-01-26 10:01:00 +01:00
net.h
tipc: fix lockdep warning when reinitilaizing sockets
2018-11-17 22:01:31 -08:00
netlink_compat.c
tipc: fix uninit skb->data in tipc_nl_compat_dumpit()
2020-09-03 11:26:40 +02:00
netlink.c
tipc: add missing attribute validation for MTU property
2020-03-18 07:17:45 +01:00
netlink.h
…
node.c
tipc: clean up skb list lock handling on send path
2019-08-18 14:01:07 -07:00
node.h
tipc: optimize link synching mechanism
2019-07-25 15:55:47 -07:00
socket.c
tipc: fix link overflow issue at socket shutdown
2020-10-01 13:17:24 +02:00
socket.h
tipc: add trace_events for tipc socket
2018-12-19 11:49:24 -08:00
subscr.c
…
subscr.h
tipc: fix modprobe tipc failed after switch order of device registration
2019-05-20 10:45:43 -07:00
sysctl.c
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
topsrv.c
tipc: fix memory leak in tipc_topsrv_start()
2020-11-18 19:20:33 +01:00
topsrv.h
…
trace.c
tipc: remove unneeded semicolon in trace.c
2019-01-17 22:04:43 -08:00
trace.h
tipc: add trace_events for tipc bearer
2018-12-19 11:49:25 -08:00
udp_media.c
tipc: block BH before using dst_cache
2020-06-03 08:21:03 +02:00
udp_media.h
…