linux

iv/linux

History

Peter Huewe fc9ca48eb6 staging/comedi: Fix undefined array subscript

In vmk80xx_do_insn_bits the local variable reg, which is used as an
index to the tx_buf array, can be used uninitialized if
- data[0] == 0
and
- devpriv->model != VMK8061_MODEL
-> we get into the else branch without having reg initialized.

Since the driver usually differentiates between VMK8061_MODEL and
VMK8055_MODEL it's safe to assume that VMK8055_DO_REG was meant as an
initial value.

And to avoid duplication we can move the assignments to the top.

Acked-by: Ian Abbott <abbotti@mev.co.uk>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2013-02-13 09:33:38 -08:00

drivers

staging/comedi: Fix undefined array subscript

2013-02-13 09:33:38 -08:00

kcomedilib

staging: comedi: use comedi_dev_from_minor()

2013-01-07 14:25:46 -08:00

comedi_buf.c

staging: comedi: comedi_buf: remove noise in comedi_buf_read_free()

2013-01-17 16:56:01 -08:00

comedi_compat32.c

staging: comedi: Makefile: conditionally compile multi-file core module