6757a7abe4
Trip temperatures are read using ACPI methods and stored in the memory
during zone initializtion and when the firmware sends a notification for
change. This trip temperature is returned when the thermal core calls via
callback get_trip_temp().
But it is possible that while updating the memory copy of the trips when
the firmware sends a notification for change, thermal core is reading the
trip temperature via the callback get_trip_temp(). This may return invalid
trip temperature.
To address this add a mutex to protect the invalid temperature reads in
the callback get_trip_temp() and int340x_thermal_read_trips().
Fixes: 5fbf7f27fa ("Thermal/int340x: Add common thermal zone handler")
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: 5.0+ <stable@vger.kernel.org> # 5.0+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
63 lines
1.5 KiB
C
63 lines
1.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* int340x_thermal_zone.h
|
|
* Copyright (c) 2015, Intel Corporation.
|
|
*/
|
|
|
|
#ifndef __INT340X_THERMAL_ZONE_H__
|
|
#define __INT340X_THERMAL_ZONE_H__
|
|
|
|
#include <acpi/acpi_lpat.h>
|
|
|
|
#define INT340X_THERMAL_MAX_ACT_TRIP_COUNT 10
|
|
|
|
struct active_trip {
|
|
int temp;
|
|
int id;
|
|
bool valid;
|
|
};
|
|
|
|
struct int34x_thermal_zone {
|
|
struct acpi_device *adev;
|
|
struct active_trip act_trips[INT340X_THERMAL_MAX_ACT_TRIP_COUNT];
|
|
unsigned long *aux_trips;
|
|
int aux_trip_nr;
|
|
int psv_temp;
|
|
int psv_trip_id;
|
|
int crt_temp;
|
|
int crt_trip_id;
|
|
int hot_temp;
|
|
int hot_trip_id;
|
|
struct thermal_zone_device *zone;
|
|
struct thermal_zone_device_ops *override_ops;
|
|
void *priv_data;
|
|
struct acpi_lpat_conversion_table *lpat_table;
|
|
struct mutex trip_mutex;
|
|
};
|
|
|
|
struct int34x_thermal_zone *int340x_thermal_zone_add(struct acpi_device *,
|
|
struct thermal_zone_device_ops *override_ops);
|
|
void int340x_thermal_zone_remove(struct int34x_thermal_zone *);
|
|
int int340x_thermal_read_trips(struct int34x_thermal_zone *int34x_zone);
|
|
|
|
static inline void int340x_thermal_zone_set_priv_data(
|
|
struct int34x_thermal_zone *tzone, void *priv_data)
|
|
{
|
|
tzone->priv_data = priv_data;
|
|
}
|
|
|
|
static inline void *int340x_thermal_zone_get_priv_data(
|
|
struct int34x_thermal_zone *tzone)
|
|
{
|
|
return tzone->priv_data;
|
|
}
|
|
|
|
static inline void int340x_thermal_zone_device_update(
|
|
struct int34x_thermal_zone *tzone,
|
|
enum thermal_notify_event event)
|
|
{
|
|
thermal_zone_device_update(tzone->zone, event);
|
|
}
|
|
|
|
#endif
|