iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
fdc94d3a8c887e4e06a7ff8dcb51d55cd70e16cf
linux/fs/ocfs2
History
Benjamin Coddington 98123866fc Treewide: Stop corrupting socket's task_frag 
Since moving to memalloc_nofs_save/restore, SUNRPC has stopped setting the
GFP_NOIO flag on sk_allocation which the networking system uses to decide
when it is safe to use current->task_frag.  The results of this are
unexpected corruption in task_frag when SUNRPC is involved in memory
reclaim.

The corruption can be seen in crashes, but the root cause is often
difficult to ascertain as a crashing machine's stack trace will have no
evidence of being near NFS or SUNRPC code.  I believe this problem to
be much more pervasive than reports to the community may indicate.

Fix this by having kernel users of sockets that may corrupt task_frag due
to reclaim set sk_use_task_frag = false.  Preemptively correcting this
situation for users that still set sk_allocation allows them to convert to
memalloc_nofs_save/restore without the same unexpected corruptions that are
sure to follow, unlikely to show up in testing, and difficult to bisect.

CC: Philipp Reisner <philipp.reisner@linbit.com>
CC: Lars Ellenberg <lars.ellenberg@linbit.com>
CC: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
CC: Jens Axboe <axboe@kernel.dk>
CC: Josef Bacik <josef@toxicpanda.com>
CC: Keith Busch <kbusch@kernel.org>
CC: Christoph Hellwig <hch@lst.de>
CC: Sagi Grimberg <sagi@grimberg.me>
CC: Lee Duncan <lduncan@suse.com>
CC: Chris Leech <cleech@redhat.com>
CC: Mike Christie <michael.christie@oracle.com>
CC: "James E.J. Bottomley" <jejb@linux.ibm.com>
CC: "Martin K. Petersen" <martin.petersen@oracle.com>
CC: Valentina Manea <valentina.manea.m@gmail.com>
CC: Shuah Khan <shuah@kernel.org>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: David Howells <dhowells@redhat.com>
CC: Marc Dionne <marc.dionne@auristor.com>
CC: Steve French <sfrench@samba.org>
CC: Christine Caulfield <ccaulfie@redhat.com>
CC: David Teigland <teigland@redhat.com>
CC: Mark Fasheh <mark@fasheh.com>
CC: Joel Becker <jlbec@evilplan.org>
CC: Joseph Qi <joseph.qi@linux.alibaba.com>
CC: Eric Van Hensbergen <ericvh@gmail.com>
CC: Latchesar Ionkov <lucho@ionkov.net>
CC: Dominique Martinet <asmadeus@codewreck.org>
CC: Ilya Dryomov <idryomov@gmail.com>
CC: Xiubo Li <xiubli@redhat.com>
CC: Chuck Lever <chuck.lever@oracle.com>
CC: Jeff Layton <jlayton@kernel.org>
CC: Trond Myklebust <trond.myklebust@hammerspace.com>
CC: Anna Schumaker <anna@kernel.org>
CC: Steffen Klassert <steffen.klassert@secunet.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>

Suggested-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2022-12-19 17:28:49 -08:00
..
cluster
Treewide: Stop corrupting socket's task_frag
2022-12-19 17:28:49 -08:00
dlm
ocfs2/dlm: use bitmap API instead of hand-writing it
2022-11-18 13:55:06 -08:00
dlmfs
ocfs2: kill EBUSY from dlmfs_evict_inode
2022-06-16 19:58:20 -07:00
acl.c
fs: pass dentry to set acl method
2022-10-19 12:55:42 +02:00
acl.h
fs: pass dentry to set acl method
2022-10-19 12:55:42 +02:00
alloc.c
ocfs2: Convert ocfs2 to read_folio
2022-05-09 16:21:46 -04:00
alloc.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
aops.c
ocfs2: replace ll_rw_block()
2022-09-11 20:26:07 -07:00
aops.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
blockcheck.c
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
blockcheck.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
buffer_head_io.c
fs/buffer: Combine two submit_bh() and ll_rw_block() arguments
2022-07-14 12:14:32 -06:00
buffer_head_io.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
dcache.c
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
dcache.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
dir.c
Change calling conventions for filldir_t
2022-08-17 17:25:04 -04:00
dir.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
dlmglue.c
ocfs2: fix freeing uninitialized resource on ocfs2_dlm_shutdown
2022-08-28 14:02:45 -07:00
dlmglue.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
export.c
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
export.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
extent_map.c
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
extent_map.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
file.c
Merge tag 'fs.ovl.setgid.v6.2' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping
2022-12-12 19:03:10 -08:00
file.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
filecheck.c
ocfs2: use default_groups in kobj_type
2022-01-15 16:30:24 +02:00
filecheck.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
heartbeat.c
ocfs2: fix a typo in a comment
2022-07-29 18:12:36 -07:00
heartbeat.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
inode.c
ocfs2: fix mounting crash if journal is not alloced
2022-04-29 14:37:58 -07:00
inode.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
ioctl.c
block: add a bdev_discard_granularity helper
2022-04-17 19:49:59 -06:00
ioctl.h
ocfs2: convert to fileattr
2021-04-12 15:04:30 +02:00
journal.c
ocfs2: fix memory leak in ocfs2_mount_volume()
2022-11-30 16:13:17 -08:00
journal.h
ocfs2: fix memory leak in ocfs2_mount_volume()
2022-11-30 16:13:17 -08:00
Kconfig
ocfs2: replace HTTP links with HTTPS ones
2020-08-07 11:33:22 -07:00
localalloc.c
fs/ocfs2: fix comments mentioning i_mutex
2022-03-22 15:57:00 -07:00
localalloc.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
locks.c
fs: remove mandatory file locking support
2021-08-23 06:15:36 -04:00
locks.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
Makefile
ocfs2: improve ocfs2 Makefile
2018-12-28 12:11:45 -08:00
mmap.c
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
mmap.h
…
move_extents.c
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
move_extents.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
namei.c
Merge tag 'fs.acl.rework.v6.2' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping
2022-12-12 18:46:39 -08:00
namei.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
ocfs1_fs_compat.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
ocfs2_fs.h
ocfs2: replace zero-length arrays with DECLARE_FLEX_ARRAY() helper
2022-10-03 14:21:42 -07:00
ocfs2_ioctl.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
ocfs2_lockid.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
ocfs2_lockingver.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
ocfs2_trace.h
ocfs2: fix the application IO timeout when fstrim is running
2019-03-05 21:07:13 -08:00
ocfs2.h
ocfs2: always read both high and low parts of dinode link count
2022-12-11 19:30:19 -08:00
quota_global.c
fs/ocfs2: Fix spelling typo in comment
2022-07-17 17:31:43 -07:00
quota_local.c
ocfs2: replace usage of found with dedicated list iterator variable
2022-04-29 14:37:57 -07:00
quota.h
…
refcounttree.c
fs/ocfs2: fix repeated words in comments
2022-10-03 14:21:43 -07:00
refcounttree.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
reservations.c
ocfs2: change return type of ocfs2_resmap_init
2022-04-29 14:37:58 -07:00
reservations.h
ocfs2: change return type of ocfs2_resmap_init
2022-04-29 14:37:58 -07:00
resize.c
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
resize.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
slot_map.c
Revert "ocfs2: mount shared volume without ha stack"
2022-07-18 15:09:15 -07:00
slot_map.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
stack_o2cb.c
ocfs2: use bitmap API in fill_node_map
2022-11-18 13:55:06 -08:00
stack_user.c
fs: dlm: remove DLM_LSFL_FS from uapi
2022-08-23 14:54:54 -05:00
stackglue.c
ocfs2: fix memory leak in ocfs2_stack_glue_init()
2022-11-18 13:55:09 -08:00
stackglue.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
suballoc.c
ocfs2: fix a deadlock when commit trans
2022-01-30 09:56:58 +02:00
suballoc.h
fs/ocfs2/suballoc.h: fix spelling typo in comment
2022-10-03 14:21:42 -07:00
super.c
ocfs2: fix memory leak in ocfs2_mount_volume()
2022-11-30 16:13:17 -08:00
super.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
symlink.c
ocfs2: Convert ocfs2 to read_folio
2022-05-09 16:21:46 -04:00
symlink.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
sysfile.c
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
sysfile.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
uptodate.c
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
uptodate.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00
xattr.c
fs/ocfs2: fix comments mentioning i_mutex
2022-03-22 15:57:00 -07:00
xattr.h
treewide: remove editor modelines and cruft
2021-05-07 00:26:34 -07:00