Tejun Heo fe06e5f9b7 libata-sff: separate out BMDMA EH
Some of error handling logic in ata_sff_error_handler() and all of
ata_sff_post_internal_cmd() are for BMDMA.  Create
ata_bmdma_error_handler() and ata_bmdma_post_internal_cmd() and move
BMDMA part into those.

While at it, change DMA protocol check to ata_is_dma(), fix
post_internal_cmd to call ap->ops->bmdma_stop instead of directly
calling ata_bmdma_stop() and open code hardreset selection so that
ata_std_error_handler() doesn't have to know about sff hardreset.

As these two functions are BMDMA specific, there's no reason to check
for bmdma_addr before calling bmdma methods if the protocol of the
failed command is DMA.  sata_mv and pata_mpc52xx now don't need to set
.post_internal_cmd to ATA_OP_NULL and pata_icside and sata_qstor don't
need to set it to their bmdma_stop routines.

ata_sff_post_internal_cmd() becomes noop and is removed.

This fixes p3 described in clean-up-BMDMA-initialization patch.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
2010-05-19 13:36:46 -04:00
..
2010-05-14 17:35:51 -04:00
2010-05-19 13:36:46 -04:00
2010-05-17 22:49:02 -04:00
2010-05-19 13:36:46 -04:00
2010-05-19 13:36:46 -04:00
2010-05-14 17:08:01 -04:00
2010-05-19 13:36:46 -04:00
2010-05-19 13:36:46 -04:00
2008-01-23 05:24:15 -05:00
2010-05-19 13:36:46 -04:00
2010-05-17 22:49:02 -04:00
2010-05-17 22:49:02 -04:00
2009-09-08 21:17:36 -04:00
2010-05-19 13:36:46 -04:00
2010-05-17 22:49:02 -04:00
2007-07-02 10:17:42 -04:00