Files
linux/fs/xfs
Brian Foster fe685954ee xfs: end sync buffer I/O properly on shutdown error
[ Upstream commit 465fa17f4a ]

As of commit e339dd8d8b ("xfs: use sync buffer I/O for sync delwri
queue submission"), the delwri submission code uses sync buffer I/O
for sync delwri I/O. Instead of waiting on async I/O to unlock the
buffer, it uses the underlying sync I/O completion mechanism.

If delwri buffer submission fails due to a shutdown scenario, an
error is set on the buffer and buffer completion never occurs. This
can cause xfs_buf_delwri_submit() to deadlock waiting on a
completion event.

We could check the error state before waiting on such buffers, but
that doesn't serialize against the case of an error set via a racing
I/O completion. Instead, invoke I/O completion in the shutdown case
regardless of buffer I/O type.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-12-05 09:21:08 +01:00
..
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-07-11 22:25:59 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-07-30 07:57:48 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-08-01 07:40:48 -07:00
2018-06-06 14:17:53 -07:00
2018-07-26 10:15:16 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00