iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Eric Dumazet 11b73313c1 sch_netem: fix issues in netem_change() vs get_dist_table() 
In blamed commit, I missed that get_dist_table() was allocating
memory using GFP_KERNEL, and acquiring qdisc lock to perform
the swap of newly allocated table with current one.

In this patch, get_dist_table() is allocating memory and
copy user data before we acquire the qdisc lock.

Then we perform swap operations while being protected by the lock.

Note that after this patch netem_change() no longer can do partial changes.
If an error is returned, qdisc conf is left unchanged.

Fixes: 2174a08db80d ("sch_netem: acquire qdisc lock in netem_change()")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230622181503.2327695-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-06-24 15:12:47 -07:00
..
act_api.c
net/sched: act_api: use the correct TCA_ACT attributes in dump
2023-03-23 08:39:08 +00:00
act_bpf.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_connmark.c
net/sched: act_connmark: handle errno on tcf_idr_check_alloc
2023-03-01 08:19:09 +00:00
act_csum.c
net: skbuff: hide csum_not_inet when CONFIG_IP_SCTP not set
2023-04-19 13:04:30 +01:00
act_ct.c
net/sched: act_ct: Fix promotion of offloaded unreplied tuple
2023-06-14 09:56:50 +02:00
act_ctinfo.c
net/sched: act_ctinfo: use percpu stats
2023-02-13 20:09:01 -08:00
act_gact.c
Networking changes for 6.2.
2022-12-13 15:47:48 -08:00
act_gate.c
net/sched: act_gate: use percpu stats
2023-02-16 10:39:28 +01:00
act_ife.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_ipt.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_meta_mark.c
…
act_meta_skbprio.c
…
act_meta_skbtcindex.c
…
act_mirred.c
net/sched: act_mirred: Add carrier check
2023-05-01 07:26:10 +01:00
act_mpls.c
net/sched: remove two skb_mac_header() uses
2023-03-22 22:43:23 -07:00
act_nat.c
net/sched: act_nat: transition to percpu stats and rcu
2023-02-16 10:39:28 +01:00
act_pedit.c
net/sched: act_pedit: Parse L3 Header for L4 offset
2023-06-09 10:34:27 +01:00
act_police.c
net: sched: act_police: fix sparse errors in tcf_police_dump()
2023-06-07 12:28:04 +01:00
act_sample.c
net/sched: act_sample: fix action bind logic
2023-02-26 18:27:45 +00:00
act_simple.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_skbedit.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_skbmod.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_tunnel_key.c
net/sched: act_tunnel_key: add support for "don't fragment"
2023-03-30 23:24:24 -07:00
act_vlan.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_api.c
net/sched: cls_api: Fix lockup on flushing explicitly created chain
2023-06-14 23:03:16 -07:00
cls_basic.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_bpf.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_cgroup.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_flow.c
treewide: Convert del_timer*() to timer_shutdown*()
2022-12-25 13:38:09 -08:00
cls_flower.c
net/sched: flower: fix possible OOB write in fl_set_geneve_opt()
2023-06-01 12:59:04 +02:00
cls_fw.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_matchall.c
net/sched: support per action hw stats
2023-02-14 11:00:01 +01:00
cls_route.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_u32.c
net/sched: cls_u32: Fix reference counter leak leading to overflow
2023-06-09 11:40:17 +01:00
em_canid.c
…
em_cmp.c
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
em_ipset.c
…
em_ipt.c
…
em_meta.c
fix typos in net/sched/* files
2023-03-24 09:05:03 +00:00
em_nbyte.c
net: sched: Return the correct errno code
2021-02-06 11:15:28 -08:00
em_text.c
…
em_u32.c
…
ematch.c
net_sched: reject TCF_EM_SIMPLE case for complex ematch module
2022-12-19 09:43:18 +00:00
Kconfig
net/sched: Retire rsvp classifier
2023-02-16 09:27:07 +01:00
Makefile
net/sched: Retire rsvp classifier
2023-02-16 09:27:07 +01:00
sch_api.c
net/sched: qdisc_destroy() old ingress and clsact Qdiscs before grafting
2023-06-14 10:31:39 +02:00
sch_blackhole.c
…
sch_cake.c
sch_cake: do not use skb_mac_header() in cake_overhead()
2023-03-22 22:43:23 -07:00
sch_cbs.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_choke.c
treewide: use get_random_u32_below() instead of deprecated function
2022-11-18 02:15:15 +01:00
sch_codel.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_drr.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_etf.c
net: sched: etf: remove true check in etf_enable_offload()
2022-09-01 20:08:32 -07:00
sch_ets.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_fifo.c
net_sched: fix NULL deref in fifo_set_limit()
2021-10-01 14:59:10 -07:00
sch_fq_codel.c
Revert "net: sched: fq_codel: remove redundant resource cleanup in fq_codel_init()"
2022-10-19 13:47:09 +01:00
sch_fq_pie.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00
sch_fq.c
net/sched: sch_fq: fix integer overflow of "credit"
2023-04-21 20:24:29 -07:00
sch_frag.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2021-12-31 14:35:40 +00:00
sch_generic.c
net/sched: qdisc_destroy() old ingress and clsact Qdiscs before grafting
2023-06-14 10:31:39 +02:00
sch_gred.c
net: sched: gred: prevent races when adding offloads to stats
2023-01-18 20:28:25 -08:00
sch_hfsc.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_hhf.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_htb.c
net/sched: sch_htb: use extack on errors messages
2023-04-23 18:47:09 +01:00
sch_ingress.c
net/sched: Reserve TC_H_INGRESS (TC_H_CLSACT) for ingress (clsact) Qdiscs
2023-05-30 23:31:05 -07:00
sch_mq.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00
sch_mqprio_lib.c
net/sched: mqprio: allow per-TC user input of FP adminStatus
2023-04-13 22:22:10 -07:00
sch_mqprio_lib.h
net/sched: mqprio: allow per-TC user input of FP adminStatus
2023-04-13 22:22:10 -07:00
sch_mqprio.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00
sch_multiq.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_netem.c
sch_netem: fix issues in netem_change() vs get_dist_table()
2023-06-24 15:12:47 -07:00
sch_pie.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00
sch_plug.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_prio.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_qfq.c
net/sched: sch_qfq: refactor parsing of netlink parameters
2023-04-23 18:47:09 +01:00
sch_red.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00
sch_sfb.c
Networking fixes for 6.1-rc2, including fixes from netfilter
2022-10-20 17:24:59 -07:00
sch_sfq.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00
sch_skbprio.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_taprio.c
net/sched: taprio: fix slab-out-of-bounds Read in taprio_dequeue_from_txq
2023-06-09 10:48:14 +01:00
sch_tbf.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_teql.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00