iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/clk/qcom
History
Douglas Anderson ff1ccf59ea clk: qcom: lpass-sc7180: Fix pm_runtime usage 
The sc7180 lpass clock controller's pm_runtime usage wasn't broken
quite as spectacularly as the sc7280's pm_runtime usage, but it was
still broken. Putting some printouts in at boot showed me this (with
serial console enabled, which makes the prints slow and thus changes
timing):
  [    3.109951] DOUG: my_pm_clk_resume, usage=1
  [    3.114767] DOUG: my_pm_clk_resume, usage=1
  [    3.664443] DOUG: my_pm_clk_suspend, usage=0
  [    3.897566] DOUG: my_pm_clk_suspend, usage=0
  [    3.910137] DOUG: my_pm_clk_resume, usage=1
  [    3.923217] DOUG: my_pm_clk_resume, usage=0
  [    4.440116] DOUG: my_pm_clk_suspend, usage=-1
  [    4.444982] DOUG: my_pm_clk_suspend, usage=0
  [   14.170501] DOUG: my_pm_clk_resume, usage=1
  [   14.176245] DOUG: my_pm_clk_resume, usage=0

...or this w/out serial console:
  [    0.556139] DOUG: my_pm_clk_resume, usage=1
  [    0.556279] DOUG: my_pm_clk_resume, usage=1
  [    1.058422] DOUG: my_pm_clk_suspend, usage=-1
  [    1.058464] DOUG: my_pm_clk_suspend, usage=0
  [    1.186250] DOUG: my_pm_clk_resume, usage=1
  [    1.186292] DOUG: my_pm_clk_resume, usage=0
  [    1.731536] DOUG: my_pm_clk_suspend, usage=-1
  [    1.731557] DOUG: my_pm_clk_suspend, usage=0
  [   10.288910] DOUG: my_pm_clk_resume, usage=1
  [   10.289496] DOUG: my_pm_clk_resume, usage=0

It seems to be doing roughly the right sequence of calls, but just
like with sc7280 this is more by luck than anything. Having a usage of
-1 is just not OK.

Let's fix this like we did with sc7280.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Fixes: ce8c195e652f ("clk: qcom: lpasscc: Introduce pm autosuspend for SC7180")
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20221104064055.2.I49b25b9bda9430fc7ea21e5a708ca5a0aced2798@changeid
2022-12-01 17:26:34 -06:00
..
a7-pll.c
clk: qcom: a7-pll: Add missing MODULE_DEVICE_TABLE
2021-04-09 11:20:52 -07:00
a53-pll.c
clk: qcom: a53-pll: convert to use parent_data rather than parent_names
2022-09-13 16:49:15 -05:00
apcs-msm8916.c
clk: qcom: a53pll/mux: Use unique clock name
2021-08-05 18:52:11 -07:00
apcs-sdx55.c
clk: qcom: cleanup some dev_err_probe() calls
2021-06-01 16:34:02 -07:00
apss-ipq6018.c
clk: qcom: apss-ipq6018: mark apcs_alias0_core_clk as critical
2022-09-26 21:40:10 -05:00
apss-ipq-pll.c
clk: qcom: apss-ipq-pll: add support for IPQ8074
2022-09-26 21:40:11 -05:00
camcc-sc7180.c
clk: qcom: camcc-sc7180: use parent_hws instead of parent_data
2022-02-10 18:33:30 -06:00
camcc-sc7280.c
clk: qcom: camcc: Add camera clock controller driver for SC7280
2021-10-13 15:32:29 -07:00
camcc-sdm845.c
clk: qcom: camcc-sdm845: Fix topology around titan_top power domain
2022-06-30 18:34:54 -05:00
camcc-sm8250.c
clk: qcom: camcc-sm8250: Fix topology around titan_top power domain
2022-06-30 18:34:55 -05:00
camcc-sm8450.c
clk: qcom: add camera clock controller driver for SM8450 SoC
2022-07-06 15:20:59 -05:00
clk-alpha-pll.c
clk: qcom: alpha: Add support for programming the PLL_FSM_LEGACY_MODE bit
2022-09-27 22:25:57 -05:00
clk-alpha-pll.h
clk: qcom: alpha: Add support for programming the PLL_FSM_LEGACY_MODE bit
2022-09-27 22:25:57 -05:00
clk-branch.c
clk: qcom: branch: Add AON clock ops
2019-04-11 13:34:21 -07:00
clk-branch.h
clk: qcom: branch: Add AON clock ops
2019-04-11 13:34:21 -07:00
clk-cpu-8996.c
clk: qcom: cpu-8996: use constant mask for pmux
2022-09-26 11:12:45 -05:00
clk-hfpll.c
clk: qcom: clk-hfpll: use poll_timeout macro
2022-06-27 15:41:37 -05:00
clk-hfpll.h
clk: qcom: Add support for High-Frequency PLLs (HFPLLs)
2018-10-17 13:14:37 -07:00
clk-krait.c
clk: qcom: clk-krait: add apq/ipq8064 errata workaround
2022-06-27 15:41:37 -05:00
clk-krait.h
clk: qcom: clk-krait: add apq/ipq8064 errata workaround
2022-06-27 15:41:37 -05:00
clk-pll.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
clk-pll.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
clk-rcg2.c
Merge branch 'clk-rate-range' into clk-next
2022-10-14 13:44:44 -07:00
clk-rcg.c
clk: qcom: clk-rcg: add clk_rcg_floor_ops ops
2022-03-08 16:19:31 -06:00
clk-rcg.h
clk: qcom: clk-rcg2: add rcg2 mux ops
2022-09-26 21:40:10 -05:00
clk-regmap-divider.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
clk-regmap-divider.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
clk-regmap-mux-div.c
clk: qcom: Add regmap mux-div clocks support
2018-01-02 10:00:24 -08:00
clk-regmap-mux-div.h
clk: qcom: Use the correct style for SPDX License Identifier
2019-05-01 13:01:13 -07:00
clk-regmap-mux.c
Revert "clk: qcom: regmap-mux: add pipe clk implementation"
2022-05-23 12:26:13 -05:00
clk-regmap-mux.h
Revert "clk: qcom: regmap-mux: add pipe clk implementation"
2022-05-23 12:26:13 -05:00
clk-regmap-phy-mux.c
clk: qcom: regmap: add PHY clock source implementation
2022-06-25 21:36:07 -05:00
clk-regmap-phy-mux.h
clk: qcom: regmap: add PHY clock source implementation
2022-06-25 21:36:07 -05:00
clk-regmap.c
clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param
2021-02-10 19:42:51 -08:00
clk-regmap.h
clk: define to_clk_regmap() as inline function
2020-10-28 16:34:44 -07:00
clk-rpm.c
clk: qcom: clk-rpm: convert to parent_data API
2022-07-18 19:13:27 -05:00
clk-rpmh.c
clk: qcom: Add support for QDU1000 and QRU1000 RPMh clocks
2022-11-07 11:33:41 -06:00
clk-smd-rpm.c
clk: qcom: smd: Add SM6375 clocks
2022-09-27 12:07:17 -05:00
clk-spmi-pmic-div.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284
2019-06-05 17:36:37 +02:00
common.c
clk: qcom: regmap-mux: fix parent clock lookup
2021-12-02 15:07:34 -08:00
common.h
clk: qcom: regmap-mux: fix parent clock lookup
2021-12-02 15:07:34 -08:00
dispcc-qcm2290.c
clk: qcom: Add display clock controller driver for QCM2290
2022-02-10 17:56:10 -06:00
dispcc-sc7180.c
clk: qcom: dispcc: Update the transition delay for MDSS GDSC
2022-02-24 16:22:11 -08:00
dispcc-sc7280.c
clk: qcom: dispcc: Update the transition delay for MDSS GDSC
2022-02-24 16:22:11 -08:00
dispcc-sc8280xp.c
clk: qcom: Add SC8280XP display clock controller
2022-11-09 21:18:11 -06:00
dispcc-sdm845.c
clk: qcom: dispcc-sdm845: get rid of the test clock
2021-04-07 17:22:53 -07:00
dispcc-sm6115.c
clk: qcom: Add display clock controller driver for SM6115
2022-09-26 22:17:13 -05:00
dispcc-sm6125.c
clk: qcom: Add display clock controller driver for SM6125
2022-03-09 08:53:30 -06:00
dispcc-sm6350.c
clk: qcom: dispcc-sm6350: Add CLK_OPS_PARENT_ENABLE to pixel&byte src
2022-11-05 22:21:59 -05:00
dispcc-sm6375.c
clk: qcom: Add display clock controller driver for SM6375
2022-11-15 10:46:36 -06:00
dispcc-sm8250.c
clk: qcom: dispcc-sm8250: Disable link_div_clk_src for sm8150
2022-11-05 23:38:19 -05:00
dispcc-sm8450.c
clk: qcom: Add support for Display Clock Controller on SM8450
2022-09-26 22:17:14 -05:00
gcc-apq8084.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
gcc-ipq806x.c
clk: qcom: gcc-ipq806x: use parent_data for the last remaining entry
2022-11-05 21:47:56 -05:00
gcc-ipq4019.c
clk: qcom: gcc-ipq4019: Remove unused variable 'ret'
2021-02-11 11:56:05 -08:00
gcc-ipq6018.c
clk: qcom: Add ipq6018 Global Clock Controller support
2020-01-09 12:42:55 -08:00
gcc-ipq8074.c
clk: qcom: ipq8074: convert to parent data
2022-11-07 15:58:07 -06:00
gcc-mdm9607.c
clk/qcom: Remove unused variables
2021-06-27 17:04:48 -07:00
gcc-mdm9615.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
gcc-msm8660.c
clk: qcom: gcc-msm8660: Drop hardcoded fixed board clocks
2022-10-14 13:39:09 -07:00
gcc-msm8909.c
clk: qcom: gcc-msm8909: Increase delay for USB PHY reset
2022-09-13 22:07:25 -05:00
gcc-msm8916.c
clk: qcom: gcc-msm8916: use parent_hws/_data instead of parent_names
2022-08-29 15:42:54 -05:00
gcc-msm8939.c
clk: qcom: gcc-msm8939: use ARRAY_SIZE instead of specifying num_parents
2022-09-29 11:42:12 -05:00
gcc-msm8953.c
clk: qcom: Remove redundant .owner
2021-10-07 18:24:40 -07:00
gcc-msm8960.c
clk: qcom: gcc-msm8960: use parent_hws/_data instead of parent_names
2022-09-13 21:58:34 -05:00
gcc-msm8974.c
clk: qcom: gcc: Add support for Global Clock controller found on MSM8226
2021-06-27 17:00:50 -07:00
gcc-msm8976.c
clk: qcom: gcc-msm8976: Add modem reset
2022-05-05 22:22:27 -05:00
gcc-msm8994.c
clk: qcom: gcc-msm8994: use parent_hws for gpll0/4
2022-07-18 21:40:36 -05:00
gcc-msm8996.c
clk: qcom: gcc-msm8996: start getting rid of xo clk
2022-02-10 18:33:31 -06:00
gcc-msm8998.c
clk: qcom: gcc-msm8998: add SSC-related clocks
2022-04-19 12:05:14 -05:00
gcc-qcm2290.c
clk: qcom: Merge alt alpha plls for qcm2260, sm6115
2022-09-26 22:18:14 -05:00
gcc-qcs404.c
clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency
2019-12-18 22:07:52 -08:00
gcc-sc7180.c
clk: qcom: gcc-sc7180: Update the .pwrsts for usb gdsc
2022-09-27 21:58:38 -05:00
gcc-sc7280.c
clk: qcom: gcc-sc7280: Update the .pwrsts for usb gdscs
2022-09-27 21:58:38 -05:00
gcc-sc8180x.c
clk: qcom: gcc-sc8180x: use ARRAY_SIZE instead of specifying num_parents
2021-04-07 17:25:52 -07:00
gcc-sc8280xp.c
clk: qcom: gcc-sc8280xp: use retention for USB power domains
2022-09-29 11:42:08 -05:00
gcc-sdm660.c
clk: qcom: gcc-sdm660: Use floor ops for SDCC1 clock
2022-08-29 15:55:57 -05:00
gcc-sdm845.c
clk: qcom: gcc-sdm845: add sdm670 global clock data
2022-09-13 21:20:34 -05:00
gcc-sdx55.c
clk: qcom: gcc-sdx55: use parent_hws where possible
2021-04-07 17:22:54 -07:00
gcc-sdx65.c
clk: qcom: Add SDX65 GCC support
2021-12-16 13:17:22 -06:00
gcc-sm6115.c
clk: qcom: Merge alt alpha plls for qcm2260, sm6115
2022-09-26 22:18:14 -05:00
gcc-sm6125.c
clk: qcom: gcc-sm6125: Remove gpll7 from sdcc2_apps
2022-11-05 22:01:30 -05:00
gcc-sm6350.c
clk: qcom: gcc-sm6350: Update the .pwrsts for usb gdscs
2022-09-29 11:42:11 -05:00
gcc-sm6375.c
clk: qcom: gcc-sm6375: Ensure unsigned long type
2022-10-04 10:24:26 -07:00
gcc-sm8150.c
clk: qcom: gcc: Add emac GDSC support for SM8150
2022-03-09 08:53:29 -06:00
gcc-sm8250.c
clk: qcom: gcc-sm8250: Use retention mode for USB GDSCs
2022-11-05 23:37:22 -05:00
gcc-sm8350.c
clk: qcom: gcc-sm8350: explicitly include clk-provider.h
2021-12-20 23:14:50 -06:00
gcc-sm8450.c
clk: qcom: gcc-sm8450: use new clk_regmap_phy_mux_ops for PCIe pipe clocks
2022-06-25 21:36:08 -05:00
gdsc.c
clk: qcom: gdsc: add missing error handling
2022-09-29 11:34:46 -05:00
gdsc.h
clk: qcom: gdsc: Fix the handling of PWRSTS_RET support
2022-09-27 21:58:38 -05:00
gpucc-msm8998.c
clk: qcom: gpucc-msm8998: Remove unnecessary fallbacks to global clocks
2021-09-14 14:40:33 -07:00
gpucc-sc7180.c
clk: qcom: gpucc-sc7180: drop unused enum entries
2021-04-07 17:22:51 -07:00
gpucc-sc7280.c
clk: qcom: Add graphics clock controller driver for SC7280
2021-07-20 13:46:32 -07:00
gpucc-sc8280xp.c
clk: qcom: Add SC8280XP GPU clock controller
2022-09-27 12:07:30 -05:00
gpucc-sdm660.c
clk: qcom: gpucc-sdm660: use parent_hws instead of parent_data
2022-02-10 18:33:30 -06:00
gpucc-sdm845.c
clk: qcom: gpucc-sdm845: get rid of the test clock
2021-04-07 17:22:53 -07:00
gpucc-sm6350.c
clk: qcom: Add GPU clock controller driver for SM6350
2022-03-08 16:16:47 -06:00
gpucc-sm8150.c
clk: qcom: gpucc-sm8150: Add SC8180x support
2021-08-05 18:50:43 -07:00
gpucc-sm8250.c
clk: qcom: gpucc-sm8250: use parent_hws where possible
2021-04-07 17:22:54 -07:00
gpucc-sm8350.c
clk: qcom: fix build error initializer element is not constant
2022-07-16 21:35:55 -05:00
hfpll.c
clk: qcom: hfpll: use clk_parent_data to specify the parent
2019-12-18 22:07:52 -08:00
Kconfig
clk: qcom: Add display clock controller driver for SM6375
2022-11-15 10:46:36 -06:00
kpss-xcc.c
clk: qcom: kpss-xcc: convert to parent data API
2022-10-03 20:50:22 -07:00
krait-cc.c
clk: qcom: clk-krait: add apq/ipq8064 errata workaround
2022-06-27 15:41:37 -05:00
lcc-ipq806x.c
clk: qcom: lcc-ipq806x: use ARRAY_SIZE for num_parents
2022-09-26 11:18:56 -05:00
lcc-mdm9615.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
lcc-msm8960.c
clk: qcom: lcc-msm8960: use parent_hws/_data instead of parent_names
2022-09-13 21:58:34 -05:00
lpass-gfm-sm8250.c
clk: qcom: use devm_pm_runtime_enable and devm_pm_clk_create
2021-08-26 11:28:11 -07:00
lpassaudiocc-sc7280.c
clk: qcom: lpass-sc7280: Fix pm_runtime usage
2022-12-01 17:26:13 -06:00
lpasscc-sc7280.c
clk: qcom: lpass: Handle the regmap overlap of lpasscc and lpass_aon
2022-09-13 09:48:30 -05:00
lpasscc-sdm845.c
clk: qcom: lpasscc-sdm845: explicitly include clk-provider.h
2021-12-20 23:14:50 -06:00
lpasscorecc-sc7180.c
clk: qcom: lpass-sc7180: Fix pm_runtime usage
2022-12-01 17:26:34 -06:00
lpasscorecc-sc7280.c
clk: qcom: lpass: Add support for resets & external mclk for SC7280
2022-09-13 09:48:30 -05:00
Makefile
clk: qcom: Add display clock controller driver for SM6375
2022-11-15 10:46:36 -06:00
mmcc-apq8084.c
clk: qcom: mmcc-apq8084: explicitly include clk-provider.h
2021-12-20 23:14:50 -06:00
mmcc-msm8960.c
clk: qcom: mmcc-msm8960: use parent_hws/_data instead of parent_names
2022-09-13 21:58:35 -05:00
mmcc-msm8974.c
clk: qcom: Add MSM8226 Multimedia Clock Controller support
2022-02-10 18:36:08 -06:00
mmcc-msm8994.c
clk: qcom: mmcc-msm8994: Add MSM8992 support
2021-08-26 11:58:17 -07:00
mmcc-msm8996.c
clk: qcom: mmcc-msm8996: use parent_hws/_data instead of parent_names
2022-06-25 15:18:15 -05:00
mmcc-msm8998.c
clk: qcom: mmcc-msm8998: Remove unnecessary fallbacks to global clocks
2021-09-14 14:40:33 -07:00
mmcc-sdm660.c
clk: qcom: mmcc-sdm660: Add hw_ctrl flag to venus_core0_gdsc
2021-10-13 15:20:24 -07:00
mss-sc7180.c
clk: qcom: use devm_pm_runtime_enable and devm_pm_clk_create
2021-08-26 11:28:11 -07:00
q6sstop-qcs404.c
clk: qcom: q6sstop-qcs404: explicitly include clk-provider.h
2021-12-20 23:14:50 -06:00
reset.c
clk: qcom: reset: Allow specifying custom reset delay
2022-09-13 22:07:25 -05:00
reset.h
clk: qcom: reset: Allow specifying custom reset delay
2022-09-13 22:07:25 -05:00
turingcc-qcs404.c
clk: qcom: turingcc-qcs404: explicitly include clk-provider.h
2021-12-20 23:14:50 -06:00
videocc-sc7180.c
clk: qcom: videocc-sc7180: use parent_hws instead of parent_data
2022-02-10 18:33:31 -06:00
videocc-sc7280.c
clk: qcom: Add video clock controller driver for SC7280
2021-07-20 13:46:32 -07:00
videocc-sdm845.c
clk: qcom: videocc-sdm845: get rid of the test clock
2021-04-07 17:22:53 -07:00
videocc-sm8150.c
clk: qcom: videocc-sm8150: use parent_hws where possible
2021-04-07 17:22:54 -07:00
videocc-sm8250.c
clk: qcom: Drop mmcx gdsc supply for dispcc and videocc
2022-07-18 16:35:03 -05:00