iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
ffd0393adcdcefab7e131488e10dcfde5e02d6eb
linux/net/ipv6
History
Eric Dumazet 3cab045c99 ipmr,ip6mr: acquire RTNL before calling ip[6]mr_free_table() on failure path 
[ Upstream commit 5611a00697 ]

ip[6]mr_free_table() can only be called under RTNL lock.

RTNL: assertion failed at net/core/dev.c (10367)
WARNING: CPU: 1 PID: 5890 at net/core/dev.c:10367 unregister_netdevice_many+0x1246/0x1850 net/core/dev.c:10367
Modules linked in:
CPU: 1 PID: 5890 Comm: syz-executor.2 Not tainted 5.16.0-syzkaller-11627-g422ee58dc0ef #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:unregister_netdevice_many+0x1246/0x1850 net/core/dev.c:10367
Code: 0f 85 9b ee ff ff e8 69 07 4b fa ba 7f 28 00 00 48 c7 c6 00 90 ae 8a 48 c7 c7 40 90 ae 8a c6 05 6d b1 51 06 01 e8 8c 90 d8 01 <0f> 0b e9 70 ee ff ff e8 3e 07 4b fa 4c 89 e7 e8 86 2a 59 fa e9 ee
RSP: 0018:ffffc900046ff6e0 EFLAGS: 00010286
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff888050f51d00 RSI: ffffffff815fa008 RDI: fffff520008dfece
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: ffffffff815f3d6e R11: 0000000000000000 R12: 00000000fffffff4
R13: dffffc0000000000 R14: ffffc900046ff750 R15: ffff88807b7dc000
FS:  00007f4ab736e700(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fee0b4f8990 CR3: 000000001e7d2000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 mroute_clean_tables+0x244/0xb40 net/ipv6/ip6mr.c:1509
 ip6mr_free_table net/ipv6/ip6mr.c:389 [inline]
 ip6mr_rules_init net/ipv6/ip6mr.c:246 [inline]
 ip6mr_net_init net/ipv6/ip6mr.c:1306 [inline]
 ip6mr_net_init+0x3f0/0x4e0 net/ipv6/ip6mr.c:1298
 ops_init+0xaf/0x470 net/core/net_namespace.c:140
 setup_net+0x54f/0xbb0 net/core/net_namespace.c:331
 copy_net_ns+0x318/0x760 net/core/net_namespace.c:475
 create_new_namespaces+0x3f6/0xb20 kernel/nsproxy.c:110
 copy_namespaces+0x391/0x450 kernel/nsproxy.c:178
 copy_process+0x2e0c/0x7300 kernel/fork.c:2167
 kernel_clone+0xe7/0xab0 kernel/fork.c:2555
 __do_sys_clone+0xc8/0x110 kernel/fork.c:2672
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f4ab89f9059
Code: Unable to access opcode bytes at RIP 0x7f4ab89f902f.
RSP: 002b:00007f4ab736e118 EFLAGS: 00000206 ORIG_RAX: 0000000000000038
RAX: ffffffffffffffda RBX: 00007f4ab8b0bf60 RCX: 00007f4ab89f9059
RDX: 0000000020000280 RSI: 0000000020000270 RDI: 0000000040200000
RBP: 00007f4ab8a5308d R08: 0000000020000300 R09: 0000000020000300
R10: 00000000200002c0 R11: 0000000000000206 R12: 0000000000000000
R13: 00007ffc3977cc1f R14: 00007f4ab736e300 R15: 0000000000022000
 </TASK>

Fixes: f243e5a785 ("ipmr,ip6mr: call ip6mr_free_table() on failure path")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Cong Wang <cong.wang@bytedance.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Link: https://lore.kernel.org/r/20220208053451.2885398-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-02-16 12:56:29 +01:00
..
ila
net: Add MODULE_DESCRIPTION entries to network modules
2020-06-20 21:33:57 -07:00
netfilter
netfilter: ip6t_rt: fix rt0_hdr parsing in rt_mt6
2021-10-14 23:08:35 +02:00
addrconf_core.c
ipv6: add ipv6_dev_find to stubs
2021-03-30 13:29:39 -07:00
addrconf.c
Revert "ipv6: Honor all IPv6 PIO Valid Lifetime values"
2022-02-01 17:27:14 +01:00
addrlabel.c
ipv6: addrlabel: fix possible memory leak in ip6addrlbl_net_init
2020-11-25 11:20:16 -08:00
af_inet6.c
net: ipv6: add fib6_nh_release_dsts stub
2021-12-01 09:04:49 +01:00
ah6.c
xfrm: remove hdr_offset indirection
2021-06-11 14:48:50 +02:00
anycast.c
ipv6: fix memory leaks on IPV6_ADDRFORM path
2020-07-30 16:30:55 -07:00
calipso.c
cipso,calipso: resolve a number of problems with the DOI refcounts
2021-03-04 15:26:57 -08:00
datagram.c
lsm,selinux: pass flowi_common instead of flowi to the LSM hooks
2020-11-23 18:36:21 -05:00
esp6_offload.c
xfrm: remove description from xfrm_type struct
2021-06-09 09:38:52 +02:00
esp6.c
ipv6: check return value of ipv6_skip_exthdr
2021-12-08 09:04:40 +01:00
exthdrs_core.c
…
exthdrs_offload.c
…
exthdrs.c
ipv6: exthdrs: get rid of indirect calls in ip6_parse_tlv()
2021-08-04 10:34:40 +01:00
fib6_notifier.c
…
fib6_rules.c
ipv6: fix memory leak in fib6_rule_suppress
2021-12-08 09:04:43 +01:00
fou6.c
net: Add MODULE_DESCRIPTION entries to network modules
2020-06-20 21:33:57 -07:00
icmp.c
icmp: ICMPV6: Examine invoking packet for Segment Route Headers.
2022-01-27 11:05:05 +01:00
inet6_connection_sock.c
lsm,selinux: pass flowi_common instead of flowi to the LSM hooks
2020-11-23 18:36:21 -05:00
inet6_hashtables.c
net: prefer socket bound to interface when not in VRF
2021-10-07 07:27:55 -07:00
ioam6_iptunnel.c
ipv6: ioam: move the check for undefined bits
2021-10-12 11:49:49 +01:00
ioam6.c
ipv6: ioam: move the check for undefined bits
2021-10-12 11:49:49 +01:00
ip6_checksum.c
…
ip6_fib.c
ipv6: annotate accesses to fn->fn_sernum
2022-02-01 17:27:09 +01:00
ip6_flowlabel.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-08-05 20:13:21 -07:00
ip6_gre.c
xfrm: fix policy lookup for ipv6 gre packets
2022-01-27 11:05:14 +01:00
ip6_icmp.c
net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending
2021-02-23 11:29:52 -08:00
ip6_input.c
ipv6: weaken the v4mapped source check
2021-03-18 11:19:23 -07:00
ip6_offload.c
net/core: move gro function declarations to separate header
2021-02-04 18:37:57 -08:00
ip6_offload.h
…
ip6_output.c
ipv6: fix typos in __ip6_finish_output()
2021-12-01 09:04:49 +01:00
ip6_tunnel.c
ipv6_tunnel: Rate limit warning messages
2022-02-01 17:27:07 +01:00
ip6_udp_tunnel.c
net: Make locking in sock_bindtoindex optional
2020-06-01 14:57:14 -07:00
ip6_vti.c
ip6_vti: initialize __ip6_tnl_parm struct in vti6_siocdevprivate
2022-01-11 15:35:17 +01:00
ip6mr.c
ipmr,ip6mr: acquire RTNL before calling ip[6]mr_free_table() on failure path
2022-02-16 12:56:29 +01:00
ipcomp6.c
xfrm: remove hdr_offset indirection
2021-06-11 14:48:50 +02:00
ipv6_sockglue.c
net/ipv4/ipv6: Replace one-element arraya with flexible-array members
2021-08-05 11:46:42 +01:00
Kconfig
ipv6: ioam: Support for IOAM injection with lwtunnels
2021-07-21 08:14:33 -07:00
Makefile
ipv6: ioam: Support for IOAM injection with lwtunnels
2021-07-21 08:14:33 -07:00
mcast_snoop.c
net: bridge: mcast: fix broken length + header check for MRDv6 Adv.
2021-04-27 14:02:06 -07:00
mcast.c
ipv6: change return type from int to void for mld_process_v2
2021-09-02 11:29:55 +01:00
mip6.c
xfrm: ipv6: move mip6_rthdr_offset into xfrm core
2021-06-11 14:48:50 +02:00
ndisc.c
ipv6: add IFLA_INET6_RA_MTU to expose mtu value
2021-08-27 17:29:18 -07:00
netfilter.c
netfilter: Dissect flow after packet mangling
2021-04-18 22:04:16 +02:00
output_core.c
ipv6: use prandom_u32() for ID generation
2021-05-31 22:12:08 -07:00
ping.c
lsm,selinux: pass flowi_common instead of flowi to the LSM hooks
2020-11-23 18:36:21 -05:00
proc.c
net: udp: introduce UDP_MIB_MEMERRORS for udp_mem
2020-11-09 15:34:44 -08:00
protocol.c
…
raw.c
ipv6: raw: check passed optlen before reading
2022-01-11 15:35:18 +01:00
reassembly.c
ipv6: record frag_max_size in atomic fragments in input path
2021-05-21 15:02:25 -07:00
route.c
ipv6: annotate accesses to fn->fn_sernum
2022-02-01 17:27:09 +01:00
rpl_iptunnel.c
net: ipv6: rpl_iptunnel: simplify the return expression of rpl_do_srh()
2020-12-08 16:22:54 -08:00
rpl.c
net: ipv6: rpl*: Fix strange kerneldoc warnings due to bad header
2020-10-30 12:12:52 -07:00
seg6_hmac.c
crypto: sha - split sha.h into sha1.h and sha2.h
2020-11-20 14:45:33 +11:00
seg6_iptunnel.c
seg6: fix the iif in the IPv6 socket control block
2021-12-14 10:57:09 +01:00
seg6_local.c
seg6: export get_srh() for ICMP handling
2022-01-27 11:05:05 +01:00
seg6.c
icmp: ICMPV6: Examine invoking packet for Segment Route Headers.
2022-01-27 11:05:05 +01:00
sit.c
sit: do not call ipip6_dev_free() from sit_init_net()
2021-12-22 09:32:44 +01:00
syncookies.c
Merge tag 'selinux-pr-20201214' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux
2020-12-16 11:01:04 -08:00
sysctl_net_ipv6.c
ipv6: ioam: Data plane support for Pre-allocated Trace
2021-07-21 08:14:33 -07:00
tcp_ipv6.c
inet: fully convert sk->sk_rx_dst to RCU rules
2021-12-29 12:28:42 +01:00
tcpv6_offload.c
…
tunnel6.c
tunnel6: add tunnel6_input_afinfo for ipip and ipv6 tunnels
2020-07-09 12:52:37 +02:00
udp_impl.h
net: pass a sockptr_t into ->setsockopt
2020-07-24 15:41:54 -07:00
udp_offload.c
udp: properly complete L4 GRO over UDP tunnel packet
2021-03-30 17:06:49 -07:00
udp.c
udp6: Use Segment Routing Header for dest address if present
2022-01-27 11:05:05 +01:00
udplite.c
net/ipv6: remove compat_ipv6_{get,set}sockopt
2020-07-19 18:16:41 -07:00
xfrm6_input.c
xfrm: state: remove extract_input indirection from xfrm_state_afinfo
2020-05-06 09:40:08 +02:00
xfrm6_output.c
net: ipv6: fix return value of ip6_skb_dst_mtu
2021-07-02 11:57:01 -07:00
xfrm6_policy.c
…
xfrm6_protocol.c
xfrm: add support for UDPv6 encapsulation of ESP
2020-04-28 11:28:36 +02:00
xfrm6_state.c
xfrm: remove output_finish indirection from xfrm_state_afinfo
2020-05-06 09:40:08 +02:00
xfrm6_tunnel.c
xfrm: remove description from xfrm_type struct
2021-06-09 09:38:52 +02:00