Jack Morgenstein ffe4cfc3da net/mlx4_core: Fix error handling when initializing CQ bufs in the driver
Procedure mlx4_init_user_cqes() handles returns by copy_to_user
incorrectly. copy_to_user() returns the number of bytes not copied.
Thus, a non-zero return should be treated as a -EFAULT error
(as is done elsewhere in the kernel). However, mlx4_init_user_cqes()
error handling simply returns the number of bytes not copied
(instead of -EFAULT).

Note, though, that this is a harmless bug: procedure mlx4_alloc_cq()
(which is the only caller of mlx4_init_user_cqes()) treats any
non-zero return as an error, but that returned error value is processed
internally, and not passed further up the call stack.

In addition, fixes the following sparse warning:
warning: incorrect type in argument 1 (different address spaces)
   expected void [noderef] <asn:1>*to
   got void *buf

Fixes: e45678973dcb ("{net, IB}/mlx4: Initialize CQ buffers in the driver when possible")
Reported by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-01-24 21:48:26 -08:00
..
2019-01-20 10:24:30 +12:00
2018-12-19 09:40:13 +01:00
2019-01-19 07:17:19 +12:00
2019-01-20 09:12:50 +12:00
2018-12-31 17:32:35 -08:00
2018-12-29 08:20:44 -07:00
2018-12-27 10:43:24 -08:00
2019-01-05 11:28:39 -08:00
2019-01-19 05:46:00 +12:00
2018-12-28 20:54:57 -08:00
2019-01-11 00:15:04 +01:00
2018-12-28 13:19:59 -08:00
2019-01-15 06:24:36 +12:00
2019-01-18 17:17:20 +12:00
2019-01-05 11:30:37 -08:00
2018-12-28 16:52:18 -08:00
2019-01-15 06:24:36 +12:00
2019-01-15 06:26:28 +12:00
2019-01-20 09:12:50 +12:00
2019-01-19 07:26:16 +12:00
2019-01-05 11:23:17 -08:00
2018-12-29 13:03:29 -08:00
2018-12-24 12:06:56 +01:00
2019-01-01 13:24:31 -08:00
2019-01-20 09:15:04 +12:00
2019-01-14 05:49:35 +12:00
2018-12-31 13:06:30 -08:00
2019-01-14 05:47:48 +12:00
2018-12-28 20:54:57 -08:00
2019-01-14 05:45:28 +12:00
2019-01-19 05:43:05 +12:00
2019-01-19 05:53:41 +12:00
2018-12-29 13:40:29 -08:00