iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/md
History
Song Liu 9922fa4c3b md/raid5: fix oops during stripe resizing 
commit b44c018cdf748b96b676ba09fdbc5b34fc443ada upstream.

KoWei reported crash during raid5 reshape:

[ 1032.252932] Oops: 0002 [#1] SMP PTI
[...]
[ 1032.252943] RIP: 0010:memcpy_erms+0x6/0x10
[...]
[ 1032.252947] RSP: 0018:ffffba1ac0c03b78 EFLAGS: 00010286
[ 1032.252949] RAX: 0000784ac0000000 RBX: ffff91bec3d09740 RCX: 0000000000001000
[ 1032.252951] RDX: 0000000000001000 RSI: ffff91be6781c000 RDI: 0000784ac0000000
[ 1032.252953] RBP: ffffba1ac0c03bd8 R08: 0000000000001000 R09: ffffba1ac0c03bf8
[ 1032.252954] R10: 0000000000000000 R11: 0000000000000000 R12: ffffba1ac0c03bf8
[ 1032.252955] R13: 0000000000001000 R14: 0000000000000000 R15: 0000000000000000
[ 1032.252958] FS:  0000000000000000(0000) GS:ffff91becf500000(0000) knlGS:0000000000000000
[ 1032.252959] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1032.252961] CR2: 0000784ac0000000 CR3: 000000031780a002 CR4: 00000000001606e0
[ 1032.252962] Call Trace:
[ 1032.252969]  ? async_memcpy+0x179/0x1000 [async_memcpy]
[ 1032.252977]  ? raid5_release_stripe+0x8e/0x110 [raid456]
[ 1032.252982]  handle_stripe_expansion+0x15a/0x1f0 [raid456]
[ 1032.252988]  handle_stripe+0x592/0x1270 [raid456]
[ 1032.252993]  handle_active_stripes.isra.0+0x3cb/0x5a0 [raid456]
[ 1032.252999]  raid5d+0x35c/0x550 [raid456]
[ 1032.253002]  ? schedule+0x42/0xb0
[ 1032.253006]  ? schedule_timeout+0x10e/0x160
[ 1032.253011]  md_thread+0x97/0x160
[ 1032.253015]  ? wait_woken+0x80/0x80
[ 1032.253019]  kthread+0x104/0x140
[ 1032.253022]  ? md_start_sync+0x60/0x60
[ 1032.253024]  ? kthread_park+0x90/0x90
[ 1032.253027]  ret_from_fork+0x35/0x40

This is because cache_size_mutex was unlocked too early in resize_stripes,
which races with grow_one_stripe() that grow_one_stripe() allocates a
stripe with wrong pool_size.

Fix this issue by unlocking cache_size_mutex after updating pool_size.

Cc: <stable@vger.kernel.org> # v4.4+
Reported-by: KoWei Sung <winders@amazon.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-11-05 11:08:45 +01:00
..
bcache
bcache: fix a lost wake-up problem caused by mca_cannibalize_lock
2020-10-01 13:14:27 +02:00
persistent-data
dm space map common: fix to ensure new block isn't already in use
2020-02-11 04:34:03 -08:00
dm-bio-prison-v1.c
dm: adjust structure members to improve alignment
2018-06-08 11:53:14 -04:00
dm-bio-prison-v1.h
block: switch bios to blk_status_t
2017-06-09 09:27:32 -06:00
dm-bio-prison-v2.c
dm: adjust structure members to improve alignment
2018-06-08 11:53:14 -04:00
dm-bio-prison-v2.h
dm bio prison v2: new interface for the bio prison
2017-03-07 11:30:16 -05:00
dm-bio-record.h
dm bio record: save/restore bi_end_io and bi_integrity
2020-03-25 08:06:07 +01:00
dm-bufio.c
Revert "dm bufio: fix deadlock with loop device"
2019-08-29 08:28:49 +02:00
dm-builtin.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dm-cache-background-tracker.c
dm cache background tracker: fix sparse warning
2018-04-30 15:40:40 -04:00
dm-cache-background-tracker.h
dm cache: significant rework to leverage dm-bio-prison-v2
2017-03-07 13:28:31 -05:00
dm-cache-block-types.h
…
dm-cache-metadata.c
dm cache metadata: Avoid returning cmd->bm wild pointer on error
2020-09-09 19:04:31 +02:00
dm-cache-metadata.h
dm cache: significant rework to leverage dm-bio-prison-v2
2017-03-07 13:28:31 -05:00
dm-cache-policy-internal.h
dm cache: significant rework to leverage dm-bio-prison-v2
2017-03-07 13:28:31 -05:00
dm-cache-policy-smq.c
treewide: Use array_size() in vzalloc()
2018-06-12 16:19:22 -07:00
dm-cache-policy.c
…
dm-cache-policy.h
dm cache: significant rework to leverage dm-bio-prison-v2
2017-03-07 13:28:31 -05:00
dm-cache-target.c
dm cache: fix a crash due to incorrect work item cancelling
2020-03-11 14:15:05 +01:00
dm-core.h
dm: disable DISCARD if the underlying storage no longer supports it
2019-08-25 10:48:01 +02:00
dm-crypt.c
dm crypt: avoid truncating the logical block size
2020-06-22 09:05:28 +02:00
dm-delay.c
dm delay: fix a crash when invalid device is specified
2019-05-25 18:23:39 +02:00
dm-era-target.c
dm: allow targets to return output from messages they are sent
2018-04-03 15:04:10 -04:00
dm-exception-store.c
…
dm-exception-store.h
…
dm-flakey.c
dm flakey: Properly corrupt multi-page bios.
2019-12-05 09:20:36 +01:00
dm-integrity.c
dm integrity: fix integrity recalculation that is improperly skipped
2020-07-29 10:16:59 +02:00
dm-io.c
dm: Use kzalloc for all structs with embedded biosets/mempools
2018-06-05 08:47:43 -06:00
dm-ioctl.c
dm ioctl: harden copy_params()'s copy_from_user() from malicious users
2018-11-13 11:08:49 -08:00
dm-kcopyd.c
dm kcopyd: always complete failed jobs
2019-08-29 08:28:55 +02:00
dm-linear.c
dm: Check for device sector overflow if CONFIG_LBDAF is not set
2019-01-26 09:32:42 +01:00
dm-log-userspace-base.c
dm: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00
dm-log-userspace-transfer.c
…
dm-log-userspace-transfer.h
…
dm-log-writes.c
dm log writes: make sure super sector log updates are written in order
2019-07-03 13:14:45 +02:00
dm-log.c
…
dm-mpath.c
dm mpath: switch paths in dm_blk_ioctl() code path
2020-06-25 15:32:49 +02:00
dm-mpath.h
…
dm-path-selector.c
…
dm-path-selector.h
…
dm-queue-length.c
dm mpath selector: more evenly distribute ties
2018-01-29 13:44:58 -05:00
dm-raid1.c
dm: Check for device sector overflow if CONFIG_LBDAF is not set
2019-01-26 09:32:42 +01:00
dm-raid.c
dm raid: fix false -EBUSY when handling check/repair message
2019-12-05 09:20:37 +01:00
dm-region-hash.c
- Error path bug fix for overflow tests (Dan)
2018-06-12 18:28:00 -07:00
dm-round-robin.c
dm round robin: revert "use percpu 'repeat_count' and 'current_path'"
2017-02-17 00:54:09 -05:00
dm-rq.c
dm rq: don't call blk_mq_queue_stopped() in dm_stop_queue()
2020-08-21 11:05:35 +02:00
dm-rq.h
dm rq: do not update rq partially in each ending bio
2017-08-28 10:23:28 -04:00
dm-service-time.c
dm mpath selector: more evenly distribute ties
2018-01-29 13:44:58 -05:00
dm-snap-persistent.c
block: fix an integer overflow in logical block size
2020-01-23 08:21:29 +01:00
dm-snap-transient.c
…
dm-snap.c
dm snapshot: rework COW throttling to fix deadlock
2019-11-06 13:05:11 +01:00
dm-stats.c
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
dm-stats.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dm-stripe.c
dax: Introduce a ->copy_to_iter dax operation
2018-05-22 23:18:31 -07:00
dm-switch.c
treewide: Use array_size() in vmalloc()
2018-06-12 16:19:22 -07:00
dm-sysfs.c
…
dm-table.c
dm table: fix invalid memory accesses with too high sector number
2019-08-29 08:28:56 +02:00
dm-target.c
dm mpath: fix missing call of path selector type->end_io
2019-09-16 08:22:12 +02:00
dm-thin-metadata.c
dm thin metadata: Avoid returning cmd->bm wild pointer on error
2020-09-09 19:04:31 +02:00
dm-thin-metadata.h
dm thin: fix passdown_double_checking_shared_status()
2019-01-31 08:14:38 +01:00
dm-thin.c
dm thin: add sanity checks to thin-pool and external snapshot creation
2019-04-05 22:32:59 +02:00
dm-uevent.c
…
dm-uevent.h
…
dm-unstripe.c
dm: Check for device sector overflow if CONFIG_LBDAF is not set
2019-01-26 09:32:42 +01:00
dm-verity-fec.c
dm verity fec: fix hash block number in verity_fec_decode
2020-05-06 08:13:28 +02:00
dm-verity-fec.h
dm: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00
dm-verity-target.c
dm verity: use message limit for data block corruption message
2019-07-21 09:03:08 +02:00
dm-verity.h
dm verity: add 'check_at_most_once' option to only validate hashes once
2018-04-03 15:04:29 -04:00
dm-writecache.c
dm writecache: handle DAX to partitions on persistent memory correctly
2020-09-09 19:04:31 +02:00
dm-zero.c
dm: don't return errnos from ->map
2017-06-09 09:27:32 -06:00
dm-zoned-metadata.c
dm zoned: return NULL if dmz_get_zone_for_reclaim() fails to find a zone
2020-06-25 15:32:58 +02:00
dm-zoned-reclaim.c
dm zoned: return NULL if dmz_get_zone_for_reclaim() fails to find a zone
2020-06-25 15:32:58 +02:00
dm-zoned-target.c
dm zoned: assign max_io_len correctly
2020-07-09 09:37:12 +02:00
dm-zoned.h
dm zoned: reduce overhead of backing device checks
2019-12-17 20:34:53 +01:00
dm.c
dm integrity: fix integrity recalculation that is improperly skipped
2020-07-29 10:16:59 +02:00
dm.h
dm: move dm_table_destroy() to same header as dm_table_create()
2018-01-17 09:16:06 -05:00
Kconfig
dm: add writecache target
2018-06-08 11:59:51 -04:00
Makefile
dm: add writecache target
2018-06-08 11:59:51 -04:00
md-bitmap.c
md/bitmap: md_bitmap_get_counter returns wrong blocks
2020-11-05 11:08:43 +01:00
md-bitmap.h
md: Avoid namespace collision with bitmap API
2018-08-01 15:49:39 -07:00
md-cluster.c
md-cluster: fix wild pointer of unlock_all_bitmaps()
2020-08-19 08:14:51 +02:00
md-cluster.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
md-faulty.c
md: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00
md-linear.c
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 20:34:55 +01:00
md-linear.h
Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md
2017-11-14 16:07:26 -08:00
md-multipath.c
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 20:34:55 +01:00
md-multipath.h
md: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00
md.c
md: add feature flag MD_FEATURE_RAID0_LAYOUT
2020-06-25 15:33:10 +02:00
md.h
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 20:34:55 +01:00
raid0.c
md: add feature flag MD_FEATURE_RAID0_LAYOUT
2020-06-25 15:33:10 +02:00
raid0.h
md/raid0: avoid RAID0 data corruption due to layout confusion.
2019-10-05 13:10:12 +02:00
raid1-10.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
raid1.c
md: raid1: check rdev before reference in raid1_sync_request func
2020-01-09 10:18:57 +01:00
raid1.h
md: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00
raid5-cache.c
md/raid5: fix 'out of memory' during raid cache recovery
2019-02-06 17:30:16 +01:00
raid5-log.h
md/raid5-cache: disable reshape completely
2018-08-31 17:38:09 -07:00
raid5-ppl.c
md: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00
raid5.c
md/raid5: fix oops during stripe resizing
2020-11-05 11:08:45 +01:00
raid5.h
Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md
2018-06-09 12:01:36 -07:00
raid10.c
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 20:34:55 +01:00
raid10.h
md: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00