Jamie Iles
8285a15cd4
bonding: wait for sysfs kobject destruction before freeing struct slave
...
[ Upstream commit b9ad3e9f5a7a760ab068e33e1f18d240ba32ce92 ]
syzkaller found that with CONFIG_DEBUG_KOBJECT_RELEASE=y, releasing a
struct slave device could result in the following splat:
kobject: 'bonding_slave' (00000000cecdd4fe): kobject_release, parent 0000000074ceb2b2 (delayed 1000)
bond0 (unregistering): (slave bond_slave_1): Releasing backup interface
------------[ cut here ]------------
ODEBUG: free active (active state 0) object type: timer_list hint: workqueue_select_cpu_near kernel/workqueue.c:1549 [inline]
ODEBUG: free active (active state 0) object type: timer_list hint: delayed_work_timer_fn+0x0/0x98 kernel/workqueue.c:1600
WARNING: CPU: 1 PID: 842 at lib/debugobjects.c:485 debug_print_object+0x180/0x240 lib/debugobjects.c:485
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 842 Comm: kworker/u4:4 Tainted: G S 5.9.0-rc8+ #96
Hardware name: linux,dummy-virt (DT)
Workqueue: netns cleanup_net
Call trace:
dump_backtrace+0x0/0x4d8 include/linux/bitmap.h:239
show_stack+0x34/0x48 arch/arm64/kernel/traps.c:142
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x174/0x1f8 lib/dump_stack.c:118
panic+0x360/0x7a0 kernel/panic.c:231
__warn+0x244/0x2ec kernel/panic.c:600
report_bug+0x240/0x398 lib/bug.c:198
bug_handler+0x50/0xc0 arch/arm64/kernel/traps.c:974
call_break_hook+0x160/0x1d8 arch/arm64/kernel/debug-monitors.c:322
brk_handler+0x30/0xc0 arch/arm64/kernel/debug-monitors.c:329
do_debug_exception+0x184/0x340 arch/arm64/mm/fault.c:864
el1_dbg+0x48/0xb0 arch/arm64/kernel/entry-common.c:65
el1_sync_handler+0x170/0x1c8 arch/arm64/kernel/entry-common.c:93
el1_sync+0x80/0x100 arch/arm64/kernel/entry.S:594
debug_print_object+0x180/0x240 lib/debugobjects.c:485
__debug_check_no_obj_freed lib/debugobjects.c:967 [inline]
debug_check_no_obj_freed+0x200/0x430 lib/debugobjects.c:998
slab_free_hook mm/slub.c:1536 [inline]
slab_free_freelist_hook+0x190/0x210 mm/slub.c:1577
slab_free mm/slub.c:3138 [inline]
kfree+0x13c/0x460 mm/slub.c:4119
bond_free_slave+0x8c/0xf8 drivers/net/bonding/bond_main.c:1492
__bond_release_one+0xe0c/0xec8 drivers/net/bonding/bond_main.c:2190
bond_slave_netdev_event drivers/net/bonding/bond_main.c:3309 [inline]
bond_netdev_event+0x8f0/0xa70 drivers/net/bonding/bond_main.c:3420
notifier_call_chain+0xf0/0x200 kernel/notifier.c:83
__raw_notifier_call_chain kernel/notifier.c:361 [inline]
raw_notifier_call_chain+0x44/0x58 kernel/notifier.c:368
call_netdevice_notifiers_info+0xbc/0x150 net/core/dev.c:2033
call_netdevice_notifiers_extack net/core/dev.c:2045 [inline]
call_netdevice_notifiers net/core/dev.c:2059 [inline]
rollback_registered_many+0x6a4/0xec0 net/core/dev.c:9347
unregister_netdevice_many.part.0+0x2c/0x1c0 net/core/dev.c:10509
unregister_netdevice_many net/core/dev.c:10508 [inline]
default_device_exit_batch+0x294/0x338 net/core/dev.c:10992
ops_exit_list.isra.0+0xec/0x150 net/core/net_namespace.c:189
cleanup_net+0x44c/0x888 net/core/net_namespace.c:603
process_one_work+0x96c/0x18c0 kernel/workqueue.c:2269
worker_thread+0x3f0/0xc30 kernel/workqueue.c:2415
kthread+0x390/0x498 kernel/kthread.c:292
ret_from_fork+0x10/0x18 arch/arm64/kernel/entry.S:925
This is a potential use-after-free if the sysfs nodes are being accessed
whilst removing the struct slave, so wait for the object destruction to
complete before freeing the struct slave itself.
Fixes: 07699f9a7c8d ("bonding: add sysfs /slave dir for bond slave devices.")
Fixes: a068aab42258 ("bonding: Fix reference count leak in bond_sysfs_slave_add.")
Cc: Qiushi Wu <wu000273@umn.edu>
Cc: Jay Vosburgh <j.vosburgh@gmail.com>
Cc: Veaceslav Falico <vfalico@gmail.com>
Cc: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: Jamie Iles <jamie@nuviainc.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20201120142827.879226-1-jamie@nuviainc.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-12-08 10:18:53 +01:00
..
2019-07-03 13:14:42 +02:00
2020-10-17 10:12:57 +02:00
2018-01-19 14:02:12 -05:00
2018-06-28 10:40:47 -07:00
2020-10-29 09:55:15 +01:00
2019-06-17 19:51:56 +02:00
2019-05-16 19:41:27 +02:00
2019-03-23 20:09:51 +01:00
2020-06-30 23:17:05 -04:00
2019-05-04 09:20:18 +02:00
2020-06-03 08:19:15 +02:00
2020-08-11 15:32:34 +02:00
2018-07-13 12:18:18 -04:00
2018-08-03 12:46:20 -07:00
2017-11-02 11:10:55 +01:00
2018-08-07 12:39:13 -07:00
2017-11-02 11:10:55 +01:00
2019-06-11 12:20:57 +02:00
2017-11-02 11:10:55 +01:00
2019-02-23 09:07:27 +01:00
2018-04-19 16:11:11 -04:00
2018-08-04 13:23:15 -07:00
2017-05-27 18:51:41 -04:00
2020-12-08 10:18:53 +01:00
2019-11-10 11:27:39 +01:00
2017-07-04 22:35:16 +01:00
2020-02-05 14:43:46 +00:00
2017-07-04 01:29:04 -07:00
2018-04-02 20:16:17 +02:00
2017-11-02 11:10:55 +01:00
2018-07-27 13:17:50 -07:00
2018-10-10 10:19:10 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-18 12:39:36 +01:00
2017-11-30 09:54:25 -05:00
2017-11-04 09:26:51 +09:00
2020-11-10 12:36:02 +01:00
2017-11-02 11:10:55 +01:00
2018-03-05 12:52:45 -05:00
2017-11-04 09:26:51 +09:00
2020-01-04 19:13:37 +01:00
2020-07-22 09:31:59 +02:00
2018-05-20 18:31:42 -04:00
2017-11-02 11:10:55 +01:00
2018-02-28 11:43:28 -05:00
2018-05-28 22:59:54 -04:00
2017-11-01 11:50:43 +09:00
2020-03-18 07:14:14 +01:00
2017-11-02 11:10:55 +01:00
2020-03-05 16:42:16 +01:00
2018-07-20 10:14:41 +02:00
2017-11-02 11:10:55 +01:00
2019-12-05 09:19:45 +01:00
2019-11-10 11:27:54 +01:00
2017-11-02 11:10:55 +01:00
2018-08-11 12:37:10 -07:00
2020-07-22 09:31:58 +02:00
2017-11-02 11:10:55 +01:00
2018-02-27 14:46:26 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-12-11 14:10:06 -05:00
2017-11-02 11:10:55 +01:00
2019-03-10 07:17:19 +01:00
2018-06-15 14:04:00 +02:00
2018-05-29 10:12:45 -04:00
2018-04-22 21:12:00 -04:00
2017-08-07 11:39:22 -07:00
2018-06-26 11:33:04 +09:00
2020-09-26 18:01:32 +02:00
2020-07-22 09:32:00 +02:00
2019-04-27 09:36:33 +02:00
2020-01-04 19:13:41 +01:00
2018-10-02 15:52:12 -07:00
2018-06-05 10:45:24 -04:00
2019-02-23 09:07:24 +01:00
2019-06-11 12:20:48 +02:00
2020-04-21 09:03:04 +02:00
2019-07-14 08:11:14 +02:00
2019-01-31 08:14:32 +01:00
2020-11-24 13:27:21 +01:00
2020-08-19 08:14:56 +02:00
2020-10-29 09:54:56 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-07-10 09:53:46 +02:00
2020-04-29 16:31:16 +02:00
2020-02-11 04:34:14 -08:00
2018-03-27 09:51:23 +02:00
2019-02-06 17:30:06 +01:00
2018-07-11 23:10:19 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-25 12:06:25 +09:00
2019-11-06 13:06:23 +01:00
2019-11-20 18:46:35 +01:00
2018-02-14 14:43:32 -05:00
2018-06-18 22:40:32 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-01-09 10:19:09 +01:00
2018-05-28 22:59:54 -04:00
2019-11-10 11:27:42 +01:00
2017-11-02 11:10:55 +01:00
2018-08-01 09:52:30 -07:00
2017-07-01 07:39:09 -07:00
2018-09-29 11:48:26 -07:00
2019-05-02 09:58:57 +02:00
2018-04-07 22:32:31 -04:00
2017-11-08 16:12:33 +09:00
2017-11-02 11:10:55 +01:00
2018-05-24 18:36:15 -07:00
2018-05-16 07:23:35 +02:00
2020-02-01 09:37:06 +00:00
2020-07-22 09:32:00 +02:00
2017-11-02 11:10:55 +01:00
2017-10-01 03:55:47 +01:00
2019-09-10 10:33:38 +01:00
2017-11-02 11:10:55 +01:00
2018-05-16 07:23:35 +02:00
2017-11-02 11:10:55 +01:00
2017-12-05 14:37:13 -05:00
2018-08-28 11:11:47 +02:00
2020-01-27 14:51:18 +01:00
2018-05-16 07:23:35 +02:00
2018-05-29 10:12:45 -04:00
2018-03-13 18:37:02 +02:00
2018-05-31 22:48:46 -04:00
2020-02-01 09:37:06 +00:00
2018-07-21 10:43:12 -05:00
2017-11-02 11:10:55 +01:00
2018-06-22 13:43:27 +09:00
2018-07-31 09:22:48 +02:00
2018-06-22 13:43:27 +09:00
2018-04-11 10:33:46 -04:00
2018-06-30 20:42:25 +09:00
2019-09-21 07:16:43 +02:00
2020-10-01 13:14:26 +02:00
2018-03-01 21:21:36 -05:00
2017-11-02 11:10:55 +01:00
2018-06-06 14:07:53 -04:00
2018-05-03 13:46:47 -04:00
2018-02-21 15:06:05 -05:00
2020-05-20 08:18:38 +02:00
2018-05-08 00:02:41 -04:00
2020-12-08 10:18:52 +01:00
2018-07-07 10:58:49 +09:00
2017-11-02 11:10:55 +01:00
2017-08-29 15:16:52 -07:00
2018-06-26 11:33:04 +09:00
2018-07-03 10:29:26 +09:00
2018-02-16 15:57:42 -05:00
2018-04-17 13:53:13 -04:00
2018-01-24 19:13:45 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-05-04 09:20:12 +02:00
2018-08-10 16:12:20 +02:00
2020-10-14 10:31:24 +02:00