iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/tipc
History
Wang Hai cf99137759 tipc: fix memory leak in tipc_topsrv_start() 
[ Upstream commit fa6882c63621821f73cc806f291208e1c6ea6187 ]

kmemleak report a memory leak as follows:

unreferenced object 0xffff88810a596800 (size 512):
  comm "ip", pid 21558, jiffies 4297568990 (age 112.120s)
  hex dump (first 32 bytes):
    00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00  .....N..........
    ff ff ff ff ff ff ff ff 00 83 60 b0 ff ff ff ff  ..........`.....
  backtrace:
    [<0000000022bbe21f>] tipc_topsrv_init_net+0x1f3/0xa70
    [<00000000fe15ddf7>] ops_init+0xa8/0x3c0
    [<00000000138af6f2>] setup_net+0x2de/0x7e0
    [<000000008c6807a3>] copy_net_ns+0x27d/0x530
    [<000000006b21adbd>] create_new_namespaces+0x382/0xa30
    [<00000000bb169746>] unshare_nsproxy_namespaces+0xa1/0x1d0
    [<00000000fe2e42bc>] ksys_unshare+0x39c/0x780
    [<0000000009ba3b19>] __x64_sys_unshare+0x2d/0x40
    [<00000000614ad866>] do_syscall_64+0x56/0xa0
    [<00000000a1b5ca3c>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

'srv' is malloced in tipc_topsrv_start() but not free before
leaving from the error handling cases. We need to free it.

Fixes: 5c45ab24ac77 ("tipc: make struct tipc_server private for server.c")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Link: https://lore.kernel.org/r/20201109140913.47370-1-wanghai38@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-11-18 19:18:51 +01:00
..
addr.c
tipc: initialise addr_trail_end when setting node addresses
2019-08-25 10:48:05 +02:00
addr.h
tipc: add 128-bit node identifier
2018-03-23 13:12:18 -04:00
bcast.c
tipc: clean up skb list lock handling on send path
2020-07-29 10:16:47 +02:00
bcast.h
…
bearer.c
tipc: fix a double free in tipc_enable_bearer()
2019-01-09 17:38:34 +01:00
bearer.h
tipc: implement configuration of UDP media MTU
2018-04-20 11:04:05 -04:00
core.c
tipc: fix use-after-free in tipc_bcast_get_mode
2020-11-10 12:35:53 +01:00
core.h
tipc: replace name table service range array with rb tree
2018-03-31 22:19:52 -04:00
diag.c
tipc: switch to rhashtable iterator
2018-08-29 18:04:54 -07:00
discover.c
tipc: fix lockdep warning when reinitilaizing sockets
2018-11-23 08:17:03 +01:00
discover.h
tipc: some cleanups in the file discover.c
2018-03-23 13:12:17 -04:00
eth_media.c
…
group.c
tipc: Fix memory leak in tipc_group_create_member()
2020-09-26 18:01:30 +02:00
group.h
tipc: extend sock diag for group communication
2018-06-30 21:05:42 +09:00
ib_media.c
…
Kconfig
tipc: implement socket diagnostics for AF_TIPC
2018-03-22 14:43:35 -04:00
link.c
tipc: clean up skb list lock handling on send path
2020-07-29 10:16:47 +02:00
link.h
tipc: fix failover problem
2018-09-29 11:45:14 -07:00
Makefile
tipc: implement socket diagnostics for AF_TIPC
2018-03-22 14:43:35 -04:00
monitor.c
tipc: update mon's self addr when node addr generated
2020-01-27 14:49:52 +01:00
monitor.h
tipc: update mon's self addr when node addr generated
2020-01-27 14:49:52 +01:00
msg.c
tipc: fix memory leak caused by tipc_buf_append()
2020-11-05 11:08:33 +01:00
msg.h
tipc: handle collisions of 32-bit node address hash values
2018-03-23 13:12:18 -04:00
name_distr.c
tipc: eliminate message disordering during binding table update
2020-01-27 14:50:00 +01:00
name_distr.h
tipc: permit overlapping service ranges in name table
2018-03-31 22:19:52 -04:00
name_table.c
tipc: eliminate message disordering during binding table update
2020-01-27 14:50:00 +01:00
name_table.h
tipc: eliminate message disordering during binding table update
2020-01-27 14:50:00 +01:00
net.c
tipc: update mon's self addr when node addr generated
2020-01-27 14:49:52 +01:00
net.h
tipc: fix lockdep warning when reinitilaizing sockets
2018-11-23 08:17:03 +01:00
netlink_compat.c
tipc: fix uninit skb->data in tipc_nl_compat_dumpit()
2020-09-03 11:24:17 +02:00
netlink.c
tipc: add missing attribute validation for MTU property
2020-03-18 07:14:18 +01:00
netlink.h
…
node.c
tipc: clean up skb list lock handling on send path
2020-07-29 10:16:47 +02:00
node.h
tipc: add sequence number check for link STATE messages
2018-07-11 23:06:14 -07:00
socket.c
tipc: fix shutdown() of connection oriented socket
2020-09-26 18:01:30 +02:00
socket.h
tipc: call start and done ops directly in __tipc_nl_compat_dumpit()
2018-09-06 21:49:18 -07:00
subscr.c
tipc: fix unbalanced reference counter
2018-04-12 21:46:10 -04:00
subscr.h
tipc: fix modprobe tipc failed after switch order of device registration
2019-06-04 08:02:34 +02:00
sysctl.c
tipc: set sysctl_tipc_rmem and named_timeout right range
2020-01-27 14:50:39 +01:00
topsrv.c
tipc: fix memory leak in tipc_topsrv_start()
2020-11-18 19:18:51 +01:00
topsrv.h
…
udp_media.c
net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup
2020-04-29 16:31:17 +02:00
udp_media.h
tipc: implement configuration of UDP media MTU
2018-04-20 11:04:05 -04:00