iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Eric Dumazet df4646250f net_sched: reject silly cell_log in qdisc_get_rtab() 
commit e4bedf48aaa5552bc1f49703abd17606e7e6e82a upstream.

iproute2 probably never goes beyond 8 for the cell exponent,
but stick to the max shift exponent for signed 32bit.

UBSAN reported:
UBSAN: shift-out-of-bounds in net/sched/sch_api.c:389:22
shift exponent 130 is too large for 32-bit type 'int'
CPU: 1 PID: 8450 Comm: syz-executor586 Not tainted 5.11.0-rc3-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:79 [inline]
 dump_stack+0x183/0x22e lib/dump_stack.c:120
 ubsan_epilogue lib/ubsan.c:148 [inline]
 __ubsan_handle_shift_out_of_bounds+0x432/0x4d0 lib/ubsan.c:395
 __detect_linklayer+0x2a9/0x330 net/sched/sch_api.c:389
 qdisc_get_rtab+0x2b5/0x410 net/sched/sch_api.c:435
 cbq_init+0x28f/0x12c0 net/sched/sch_cbq.c:1180
 qdisc_create+0x801/0x1470 net/sched/sch_api.c:1246
 tc_modify_qdisc+0x9e3/0x1fc0 net/sched/sch_api.c:1662
 rtnetlink_rcv_msg+0xb1d/0xe60 net/core/rtnetlink.c:5564
 netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2494
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x7de/0x9b0 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0xaa6/0xe90 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg net/socket.c:672 [inline]
 ____sys_sendmsg+0x5a2/0x900 net/socket.c:2345
 ___sys_sendmsg net/socket.c:2399 [inline]
 __sys_sendmsg+0x319/0x400 net/socket.c:2432
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Acked-by: Cong Wang <cong.wang@bytedance.com>
Link: https://lore.kernel.org/r/20210114160637.1660597-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-01-27 11:05:43 +01:00
..
act_api.c
net: avoid potential infinite loop in tc_ctl_action()
2019-10-29 09:19:39 +01:00
act_bpf.c
net_sched: fix a NULL pointer deref in ipt action
2019-09-10 10:33:39 +01:00
act_connmark.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-22 09:32:00 +02:00
act_csum.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-22 09:32:00 +02:00
act_gact.c
net_sched: fix a NULL pointer deref in ipt action
2019-09-10 10:33:39 +01:00
act_ife.c
net_sched: fix a NULL pointer deref in ipt action
2019-09-10 10:33:39 +01:00
act_ipt.c
net_sched: fix a NULL pointer deref in ipt action
2019-09-10 10:33:39 +01:00
act_meta_mark.c
net: remove duplicate includes
2017-12-13 13:18:46 -05:00
act_meta_skbprio.c
net sched actions: change IFE modules alias names
2017-10-12 22:13:20 -07:00
act_meta_skbtcindex.c
net: remove duplicate includes
2017-12-13 13:18:46 -05:00
act_mirred.c
act_mirred: Fix mirred_init_module error handling
2020-01-27 14:51:18 +01:00
act_nat.c
net_sched: fix a NULL pointer deref in ipt action
2019-09-10 10:33:39 +01:00
act_pedit.c
net/sched: act_pedit: fix WARN() in the traffic path
2019-12-01 09:16:06 +01:00
act_police.c
net_sched: fix a NULL pointer deref in ipt action
2019-09-10 10:33:39 +01:00
act_sample.c
net/sched: act_sample: don't push mac header on ip6gre ingress
2019-10-05 13:09:28 +02:00
act_simple.c
net_sched: fix a NULL pointer deref in ipt action
2019-09-10 10:33:39 +01:00
act_skbedit.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-22 09:32:00 +02:00
act_skbmod.c
net_sched: fix a NULL pointer deref in ipt action
2019-09-10 10:33:39 +01:00
act_tunnel_key.c
net/sched: act_tunnel_key: fix OOB write in case of IPv6 ERSPAN tunnels
2020-10-29 09:54:58 +01:00
act_vlan.c
net_sched: fix a NULL pointer deref in ipt action
2019-09-10 10:33:39 +01:00
cls_api.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-22 09:32:00 +02:00
cls_basic.c
net_sched: fix ops->bind_class() implementations
2020-02-01 09:37:06 +00:00
cls_bpf.c
net_sched: fix ops->bind_class() implementations
2020-02-01 09:37:06 +00:00
cls_cgroup.c
net_sched: switch to rcu_work
2018-05-24 22:56:15 -04:00
cls_flow.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-22 09:32:00 +02:00
cls_flower.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-22 09:32:00 +02:00
cls_fw.c
net_sched: fix ops->bind_class() implementations
2020-02-01 09:37:06 +00:00
cls_matchall.c
net/sched: matchall: add missing validation of TCA_MATCHALL_FLAGS
2020-02-24 08:34:34 +01:00
cls_route.c
net_sched: cls_route: remove the right filter from hashtable
2020-04-02 15:28:11 +02:00
cls_rsvp6.c
…
cls_rsvp.c
…
cls_rsvp.h
cls_rsvp: fix rsvp_policy
2020-02-11 04:33:52 -08:00
cls_tcindex.c
net_sched: avoid shift-out-of-bounds in tcindex_set_parms()
2021-01-27 11:05:43 +01:00
cls_u32.c
net_sched: fix ops->bind_class() implementations
2020-02-01 09:37:06 +00:00
em_canid.c
…
em_cmp.c
…
em_ipset.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-22 09:32:00 +02:00
em_ipt.c
net: sched: add em_ipt ematch for calling xtables matches
2018-02-21 13:15:33 -05:00
em_meta.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-22 09:32:00 +02:00
em_nbyte.c
net: sched: em_nbyte: don't add the data offset twice
2018-01-24 14:52:40 -05:00
em_text.c
…
em_u32.c
…
ematch.c
net_sched: ematch: reject invalid TCF_EM_SIMPLE
2020-02-01 09:37:05 +00:00
Kconfig
net/sched: add skbprio scheduler
2018-07-24 14:44:00 -07:00
Makefile
net/sched: add skbprio scheduler
2018-07-24 14:44:00 -07:00
sch_api.c
net_sched: reject silly cell_log in qdisc_get_rtab()
2021-01-27 11:05:43 +01:00
sch_atm.c
net_sched: fix a memory leak in atm_tc_init()
2020-07-22 09:31:59 +02:00
sch_blackhole.c
net_sched: blackhole: tell upper qdisc about dropped packets
2018-06-17 08:42:33 +09:00
sch_cake.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-22 09:32:00 +02:00
sch_cbq.c
sch_cbq: validate TCA_CBQ_WRROPT to avoid crash
2019-10-07 18:57:26 +02:00
sch_cbs.c
net: cbs: Fix software cbs to consider packet sending time
2020-04-02 15:28:11 +02:00
sch_choke.c
net: sched: prevent invalid Scell_log shift count
2021-01-12 20:10:20 +01:00
sch_codel.c
net: sched: Fix a possible null-pointer dereference in dequeue_func()
2019-08-09 17:52:32 +02:00
sch_drr.c
net: sch: sch_drr: add extack support
2017-12-21 12:32:51 -05:00
sch_dsmark.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-22 09:32:00 +02:00
sch_etf.c
sched: etf: do not assume all sockets are full blown
2020-04-29 16:31:21 +02:00
sch_fifo.c
net: sch: api: add extack support in qdisc_create_dflt
2017-12-21 12:32:51 -05:00
sch_fq_codel.c
fq_codel: fix TCA_FQ_CODEL_DROP_BATCH_SIZE sanity checks
2020-05-14 07:57:17 +02:00
sch_fq.c
net: fq: add missing attribute validation for orphan mask
2020-03-18 07:14:16 +01:00
sch_generic.c
net: sch_generic: fix the missing new qdisc assignment bug
2020-11-18 19:18:53 +01:00
sch_gred.c
net: sched: prevent invalid Scell_log shift count
2021-01-12 20:10:20 +01:00
sch_hfsc.c
net_sched: remove a bogus warning in hfsc
2018-06-23 10:58:46 +09:00
sch_hhf.c
net/flow_dissector: switch to siphash
2019-11-10 11:27:54 +01:00
sch_htb.c
net_sched: remove unused htb drop_list
2018-06-24 16:42:46 +09:00
sch_ingress.c
net: sched: allow ingress and clsact qdiscs to share filter blocks
2018-01-17 14:53:57 -05:00
sch_mq.c
net: sched: fix dump qlen for sch_mq/sch_mqprio with NOLOCK subqueues
2019-12-21 10:57:12 +01:00
sch_mqprio.c
net: sched: fix dump qlen for sch_mq/sch_mqprio with NOLOCK subqueues
2019-12-21 10:57:12 +01:00
sch_multiq.c
net: sched: fix tc -s class show no bstats on class with nolock subqueues
2019-12-05 09:21:32 +01:00
sch_netem.c
netem: fix zero division in tabledist
2020-11-05 11:08:33 +01:00
sch_pie.c
net: sched: sch: add extack for change qdisc ops
2017-12-21 12:32:50 -05:00
sch_plug.c
net: sched: sch: add extack for change qdisc ops
2017-12-21 12:32:50 -05:00
sch_prio.c
net: sch_prio: When ungrafting, replace with FIFO
2020-01-12 12:17:29 +01:00
sch_qfq.c
net: sch: api: add extack support in qdisc_create_dflt
2017-12-21 12:32:51 -05:00
sch_red.c
net: sched: prevent invalid Scell_log shift count
2021-01-12 20:10:20 +01:00
sch_sfb.c
net/flow_dissector: switch to siphash
2019-11-10 11:27:54 +01:00
sch_sfq.c
net: sched: prevent invalid Scell_log shift count
2021-01-12 20:10:20 +01:00
sch_skbprio.c
net_sched: sch_skbprio: add message validation to skbprio_change()
2020-05-14 07:57:17 +02:00
sch_tbf.c
net: sched: red: avoid hashing NULL child
2018-05-18 13:52:32 -04:00
sch_teql.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-22 09:32:00 +02:00