iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/tipc
History
Hoang Le 4d1d3dddcb tipc: fix NULL deref in tipc_link_xmit() 
[ Upstream commit b77413446408fdd256599daf00d5be72b5f3e7c6 ]

The buffer list can have zero skb as following path:
tipc_named_node_up()->tipc_node_xmit()->tipc_link_xmit(), so
we need to check the list before casting an &sk_buff.

Fault report:
 [] tipc: Bulk publication failure
 [] general protection fault, probably for non-canonical [#1] PREEMPT [...]
 [] KASAN: null-ptr-deref in range [0x00000000000000c8-0x00000000000000cf]
 [] CPU: 0 PID: 0 Comm: swapper/0 Kdump: loaded Not tainted 5.10.0-rc4+ #2
 [] Hardware name: Bochs ..., BIOS Bochs 01/01/2011
 [] RIP: 0010:tipc_link_xmit+0xc1/0x2180
 [] Code: 24 b8 00 00 00 00 4d 39 ec 4c 0f 44 e8 e8 d7 0a 10 f9 48 [...]
 [] RSP: 0018:ffffc90000006ea0 EFLAGS: 00010202
 [] RAX: dffffc0000000000 RBX: ffff8880224da000 RCX: 1ffff11003d3cc0d
 [] RDX: 0000000000000019 RSI: ffffffff886007b9 RDI: 00000000000000c8
 [] RBP: ffffc90000007018 R08: 0000000000000001 R09: fffff52000000ded
 [] R10: 0000000000000003 R11: fffff52000000dec R12: ffffc90000007148
 [] R13: 0000000000000000 R14: 0000000000000000 R15: ffffc90000007018
 [] FS:  0000000000000000(0000) GS:ffff888037400000(0000) knlGS:000[...]
 [] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 [] CR2: 00007fffd2db5000 CR3: 000000002b08f000 CR4: 00000000000006f0

Fixes: af9b028e270fd ("tipc: make media xmit call outside node spinlock context")
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
Link: https://lore.kernel.org/r/20210108071337.3598-1-hoang.h.le@dektech.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-01-23 15:49:56 +01:00
..
addr.c
tipc: initialise addr_trail_end when setting node addresses
2019-08-25 10:48:05 +02:00
addr.h
tipc: add 128-bit node identifier
2018-03-23 13:12:18 -04:00
bcast.c
tipc: clean up skb list lock handling on send path
2020-07-29 10:16:47 +02:00
bcast.h
…
bearer.c
tipc: fix a double free in tipc_enable_bearer()
2019-01-09 17:38:34 +01:00
bearer.h
tipc: implement configuration of UDP media MTU
2018-04-20 11:04:05 -04:00
core.c
tipc: fix use-after-free in tipc_bcast_get_mode
2020-11-10 12:35:53 +01:00
core.h
tipc: replace name table service range array with rb tree
2018-03-31 22:19:52 -04:00
diag.c
tipc: switch to rhashtable iterator
2018-08-29 18:04:54 -07:00
discover.c
tipc: fix lockdep warning when reinitilaizing sockets
2018-11-23 08:17:03 +01:00
discover.h
tipc: some cleanups in the file discover.c
2018-03-23 13:12:17 -04:00
eth_media.c
…
group.c
tipc: Fix memory leak in tipc_group_create_member()
2020-09-26 18:01:30 +02:00
group.h
tipc: extend sock diag for group communication
2018-06-30 21:05:42 +09:00
ib_media.c
…
Kconfig
tipc: implement socket diagnostics for AF_TIPC
2018-03-22 14:43:35 -04:00
link.c
tipc: fix NULL deref in tipc_link_xmit()
2021-01-23 15:49:56 +01:00
link.h
tipc: fix failover problem
2018-09-29 11:45:14 -07:00
Makefile
tipc: implement socket diagnostics for AF_TIPC
2018-03-22 14:43:35 -04:00
monitor.c
tipc: update mon's self addr when node addr generated
2020-01-27 14:49:52 +01:00
monitor.h
tipc: update mon's self addr when node addr generated
2020-01-27 14:49:52 +01:00
msg.c
tipc: fix memory leak caused by tipc_buf_append()
2020-11-05 11:08:33 +01:00
msg.h
tipc: handle collisions of 32-bit node address hash values
2018-03-23 13:12:18 -04:00
name_distr.c
tipc: eliminate message disordering during binding table update
2020-01-27 14:50:00 +01:00
name_distr.h
tipc: permit overlapping service ranges in name table
2018-03-31 22:19:52 -04:00
name_table.c
tipc: eliminate message disordering during binding table update
2020-01-27 14:50:00 +01:00
name_table.h
tipc: eliminate message disordering during binding table update
2020-01-27 14:50:00 +01:00
net.c
tipc: update mon's self addr when node addr generated
2020-01-27 14:49:52 +01:00
net.h
tipc: fix lockdep warning when reinitilaizing sockets
2018-11-23 08:17:03 +01:00
netlink_compat.c
tipc: fix uninit skb->data in tipc_nl_compat_dumpit()
2020-09-03 11:24:17 +02:00
netlink.c
tipc: add missing attribute validation for MTU property
2020-03-18 07:14:18 +01:00
netlink.h
…
node.c
tipc: clean up skb list lock handling on send path
2020-07-29 10:16:47 +02:00
node.h
tipc: add sequence number check for link STATE messages
2018-07-11 23:06:14 -07:00
socket.c
tipc: fix shutdown() of connection oriented socket
2020-09-26 18:01:30 +02:00
socket.h
tipc: call start and done ops directly in __tipc_nl_compat_dumpit()
2018-09-06 21:49:18 -07:00
subscr.c
tipc: fix unbalanced reference counter
2018-04-12 21:46:10 -04:00
subscr.h
tipc: fix modprobe tipc failed after switch order of device registration
2019-06-04 08:02:34 +02:00
sysctl.c
tipc: set sysctl_tipc_rmem and named_timeout right range
2020-01-27 14:50:39 +01:00
topsrv.c
tipc: fix memory leak in tipc_topsrv_start()
2020-11-18 19:18:51 +01:00
topsrv.h
…
udp_media.c
net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup
2020-04-29 16:31:17 +02:00
udp_media.h
tipc: implement configuration of UDP media MTU
2018-04-20 11:04:05 -04:00