Andrey Ryabinin
4ed2042cb8
iommu/amd: Fix sleeping in atomic in increase_address_space() ...
commit 140456f994195b568ecd7fc2287a34eadffef3ca upstream.
increase_address_space() calls get_zeroed_page(gfp) under spin_lock with
disabled interrupts. gfp flags passed to increase_address_space() may allow
sleeping, so it comes to this:
BUG: sleeping function called from invalid context at mm/page_alloc.c:4342
in_atomic(): 1, irqs_disabled(): 1, pid: 21555, name: epdcbbf1qnhbsd8
Call Trace:
dump_stack+0x66/0x8b
___might_sleep+0xec/0x110
__alloc_pages_nodemask+0x104/0x300
get_zeroed_page+0x15/0x40
iommu_map_page+0xdd/0x3e0
amd_iommu_map+0x50/0x70
iommu_map+0x106/0x220
vfio_iommu_type1_ioctl+0x76e/0x950 [vfio_iommu_type1]
do_vfs_ioctl+0xa3/0x6f0
ksys_ioctl+0x66/0x70
__x64_sys_ioctl+0x16/0x20
do_syscall_64+0x4e/0x100
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Fix this by moving get_zeroed_page() out of spin_lock/unlock section.
Fixes: 754265bcab ("iommu/amd: Fix race in increase_address_space()")
Signed-off-by: Andrey Ryabinin <arbn@yandex-team.com>
Acked-by: Will Deacon <will@kernel.org>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210217143004.19165-1-arbn@yandex-team.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Andrey Ryabinin <arbn@yandex-team.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-11 14:05:01 +01:00
2020-05-27 17:37:30 +02:00
2019-11-12 19:21:14 +01:00
2020-12-11 13:25:03 +01:00
2020-09-17 13:45:26 +02:00
2021-03-11 14:05:01 +01:00
2019-10-05 13:09:59 +02:00
2020-02-24 08:34:48 +01:00
2019-06-19 08:18:00 +02:00
2020-03-18 07:14:22 +01:00
2021-02-03 23:23:26 +01:00
2020-10-07 08:00:07 +02:00
2021-01-17 14:04:22 +01:00
2021-02-10 09:21:09 +01:00
2020-04-23 10:30:21 +02:00
2019-11-24 08:19:30 +01:00
2020-01-27 14:50:28 +01:00
2020-06-03 08:19:41 +02:00
2020-09-03 11:24:19 +02:00
2019-10-05 13:09:59 +02:00
2020-01-27 14:51:07 +01:00
2020-08-21 11:05:36 +02:00
2020-05-06 08:13:31 +02:00
2020-01-04 19:12:37 +01:00
2020-01-04 19:12:38 +01:00
4ed2042cb8