iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/btrfs
History
Josef Bacik 6eccfb28f8 btrfs: do not BUG_ON in link_to_fixup_dir 
[ Upstream commit 91df99a6eb50d5a1bc70fff4a09a0b7ae6aab96d ]

While doing error injection testing I got the following panic

  kernel BUG at fs/btrfs/tree-log.c:1862!
  invalid opcode: 0000 [#1] SMP NOPTI
  CPU: 1 PID: 7836 Comm: mount Not tainted 5.13.0-rc1+ #305
  Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-2.fc32 04/01/2014
  RIP: 0010:link_to_fixup_dir+0xd5/0xe0
  RSP: 0018:ffffb5800180fa30 EFLAGS: 00010216
  RAX: fffffffffffffffb RBX: 00000000fffffffb RCX: ffff8f595287faf0
  RDX: ffffb5800180fa37 RSI: ffff8f5954978800 RDI: 0000000000000000
  RBP: ffff8f5953af9450 R08: 0000000000000019 R09: 0000000000000001
  R10: 000151f408682970 R11: 0000000120021001 R12: ffff8f5954978800
  R13: ffff8f595287faf0 R14: ffff8f5953c77dd0 R15: 0000000000000065
  FS:  00007fc5284c8c40(0000) GS:ffff8f59bbd00000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 00007fc5287f47c0 CR3: 000000011275e002 CR4: 0000000000370ee0
  Call Trace:
   replay_one_buffer+0x409/0x470
   ? btree_read_extent_buffer_pages+0xd0/0x110
   walk_up_log_tree+0x157/0x1e0
   walk_log_tree+0xa6/0x1d0
   btrfs_recover_log_trees+0x1da/0x360
   ? replay_one_extent+0x7b0/0x7b0
   open_ctree+0x1486/0x1720
   btrfs_mount_root.cold+0x12/0xea
   ? __kmalloc_track_caller+0x12f/0x240
   legacy_get_tree+0x24/0x40
   vfs_get_tree+0x22/0xb0
   vfs_kern_mount.part.0+0x71/0xb0
   btrfs_mount+0x10d/0x380
   ? vfs_parse_fs_string+0x4d/0x90
   legacy_get_tree+0x24/0x40
   vfs_get_tree+0x22/0xb0
   path_mount+0x433/0xa10
   __x64_sys_mount+0xe3/0x120
   do_syscall_64+0x3d/0x80
   entry_SYSCALL_64_after_hwframe+0x44/0xae

We can get -EIO or any number of legitimate errors from
btrfs_search_slot(), panicing here is not the appropriate response.  The
error path for this code handles errors properly, simply return the
error.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-06-03 08:38:10 +02:00
..
tests
Btrfs: fix selftests failure due to uninitialized i_mode in test inodes
2020-08-05 10:06:00 +02:00
acl.c
Btrfs: setup a nofs context for memory allocation at __btrfs_set_acl
2019-03-23 20:10:00 +01:00
async-thread.c
Btrfs: fix crash during unmount due to race with delayed inode workers
2020-04-17 10:48:49 +02:00
async-thread.h
Btrfs: fix crash during unmount due to race with delayed inode workers
2020-04-17 10:48:49 +02:00
backref.c
btrfs: fix double free on ulist after backref resolution failure
2020-07-29 10:16:47 +02:00
backref.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
btrfs_inode.h
btrfs: use tagged writepage to mitigate livelock of snapshot
2019-02-12 19:47:11 +01:00
check-integrity.c
btrfs: fix possible NULL-pointer dereference in integrity checks
2020-02-24 08:34:49 +01:00
check-integrity.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
compression.c
btrfs: correctly validate compression type
2019-09-16 08:22:19 +02:00
compression.h
btrfs: correctly validate compression type
2019-09-16 08:22:19 +02:00
ctree.c
btrfs: fix race when picking most recent mod log operation for an old root
2021-05-22 10:59:19 +02:00
ctree.h
btrfs: tree-checker: Verify inode item
2020-11-10 12:35:56 +01:00
dedupe.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
delayed-inode.c
btrfs: free correct amount of space in btrfs_delayed_inode_reserve_metadata
2021-03-11 14:04:59 +01:00
delayed-inode.h
btrfs: Remove fs_info from btrfs_delete_delayed_dir_index
2018-08-06 13:13:00 +02:00
delayed-ref.c
Btrfs: fix race between adding and putting tree mod seq elements and nodes
2020-02-11 04:34:06 -08:00
delayed-ref.h
btrfs: Remove fs_info from btrfs_add_delayed_data_ref
2018-08-06 13:12:34 +02:00
dev-replace.c
btrfs: dev-replace: fail mount if we don't have replace item with target device
2020-11-18 19:18:48 +01:00
dev-replace.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
dir-item.c
btrfs: Remove fs_info from btrfs_insert_delayed_dir_index
2018-08-06 13:13:00 +02:00
disk-io.c
btrfs: fix space cache memory leak after transaction abort
2020-09-03 11:24:26 +02:00
disk-io.h
btrfs: Check the first key and level for cached extent buffer
2019-05-22 07:37:42 +02:00
export.c
btrfs: export helpers for subvolume name/id resolution
2020-08-26 10:30:58 +02:00
export.h
btrfs: export helpers for subvolume name/id resolution
2020-08-26 10:30:58 +02:00
extent_io.c
Btrfs: fix missing error return if writeback for extent buffer never started
2020-11-18 19:18:43 +01:00
extent_io.h
btrfs: fix potential deadlock in the search ioctl
2020-09-09 19:04:29 +02:00
extent_map.c
Btrfs: fix race between using extent maps and merging them
2020-02-19 19:51:56 +01:00
extent_map.h
btrfs: use fs_info for btrfs_handle_em_exist tracepoint
2018-05-28 18:07:17 +02:00
extent-tree.c
btrfs: don't force read-only after error in drop snapshot
2020-10-01 13:14:46 +02:00
file-item.c
btrfs: do not ignore error from btrfs_next_leaf() when inserting checksums
2020-06-22 09:05:11 +02:00
file.c
btrfs: unlock extents in btrfs_zero_range in case of quota reservation errors
2021-03-11 14:04:59 +01:00
free-space-cache.c
btrfs: clarify error returns values in __load_free_space_cache
2021-03-04 09:39:41 +01:00
free-space-cache.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
free-space-tree.c
btrfs: Remove fs_info from btrfs_del_root
2018-08-06 13:13:00 +02:00
free-space-tree.h
btrfs: Remove fs_info argument from add_to_free_space_tree
2018-05-28 18:07:36 +02:00
inode-item.c
btrfs: replace GPL boilerplate by SPDX -- sources
2018-04-12 16:29:51 +02:00
inode-map.c
Btrfs: fix inode cache waiters hanging on path allocation failure
2020-01-27 14:51:12 +01:00
inode-map.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
inode.c
btrfs: fix slab cache flags for free space tree bitmap
2021-03-24 11:07:32 +01:00
ioctl.c
btrfs: fix metadata extent leak after failure to create subvolume
2021-05-22 10:59:14 +02:00
Kconfig
btrfs: add SPDX header to Kconfig
2018-04-12 16:29:55 +02:00
locking.c
btrfs: replace waitqueue_actvie with cond_wake_up
2018-05-28 18:23:09 +02:00
locking.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
lzo.c
btrfs: lzo: Harden inline lzo compressed extent decompression
2018-05-30 16:46:43 +02:00
Makefile
btrfs: Remove custom crc32c init code
2018-03-26 15:09:39 +02:00
math.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
ordered-data.c
Btrfs: fix btrfs_wait_ordered_range() so that it waits for all ordered extents
2020-02-28 16:38:58 +01:00
ordered-data.h
btrfs: remove remaing full_sync logic from btrfs_sync_file
2018-08-06 13:12:31 +02:00
orphan.c
btrfs: replace GPL boilerplate by SPDX -- sources
2018-04-12 16:29:51 +02:00
print-tree.c
btrfs: require only sector size alignment for parent eb bytenr
2020-09-17 13:45:28 +02:00
print-tree.h
btrfs: print-tree: debugging output enhancement
2018-04-20 19:18:16 +02:00
props.c
btrfs: correctly validate compression type
2019-09-16 08:22:19 +02:00
props.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
qgroup.c
btrfs: fix transaction leak and crash after RO remount caused by qgroup rescan
2021-01-19 18:22:36 +01:00
qgroup.h
btrfs: qgroup: Avoid calling qgroup functions if qgroup is not enabled
2018-11-13 11:08:56 -08:00
raid56.c
btrfs: fix raid6 qstripe kmap
2021-03-11 14:04:59 +01:00
raid56.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
rcu-string.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
reada.c
btrfs: fix use-after-free on readahead extent after failure to create it
2020-11-05 11:08:48 +01:00
ref-verify.c
btrfs: ref-verify: fix memory leak in btrfs_ref_tree_mod
2020-11-18 19:18:48 +01:00
ref-verify.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
relocation.c
btrfs: convert logic BUG_ON()'s in replace_path to ASSERT()'s
2021-05-22 10:59:16 +02:00
root-tree.c
btrfs: do not delete mismatched root refs
2020-01-23 08:21:31 +01:00
scrub.c
btrfs: merge btrfs_find_device and find_device
2020-06-22 09:04:59 +02:00
send.c
btrfs: send: fix wrong file path when there is an inode with a pending rmdir
2021-01-12 20:10:24 +01:00
send.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
struct-funcs.c
btrfs: prune unused includes
2018-08-06 13:12:43 +02:00
super.c
btrfs: fix transaction leak and crash after RO remount caused by qgroup rescan
2021-01-19 18:22:36 +01:00
sysfs.c
btrfs: sysfs: use NOFS for device creation
2020-08-26 10:30:59 +02:00
sysfs.h
btrfs: sysfs: Use enum/define value for feature array definitions
2018-05-28 18:23:39 +02:00
transaction.c
btrfs: fix error handling in commit_fs_roots
2021-03-07 12:18:59 +01:00
transaction.h
Btrfs: fix deadlock between fiemap and transaction commits
2019-08-25 10:47:54 +02:00
tree-checker.c
btrfs: tree-checker: fix the error message for transid error
2020-11-10 12:35:57 +01:00
tree-checker.h
btrfs: Move btrfs_check_chunk_valid() to tree-check.[ch] and export it
2020-11-10 12:35:56 +01:00
tree-defrag.c
btrfs: replace GPL boilerplate by SPDX -- sources
2018-04-12 16:29:51 +02:00
tree-log.c
btrfs: do not BUG_ON in link_to_fixup_dir
2021-06-03 08:38:10 +02:00
tree-log.h
Btrfs: sync log after logging new name
2018-08-23 17:37:26 +02:00
ulist.c
btrfs: replace GPL boilerplate by SPDX -- sources
2018-04-12 16:29:51 +02:00
ulist.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
uuid-tree.c
btrfs: handle ENOENT in btrfs_uuid_tree_iterate
2019-12-31 16:34:44 +01:00
volumes.c
btrfs: fix lockdep splat in btrfs_recover_relocation
2021-01-27 11:05:35 +01:00
volumes.h
btrfs: tree-checker: Verify dev item
2020-11-10 12:35:56 +01:00
xattr.c
Btrfs: use nofs context when initializing security xattrs to avoid deadlock
2019-01-16 22:04:37 +01:00
xattr.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
zlib.c
btrfs: replace GPL boilerplate by SPDX -- sources
2018-04-12 16:29:51 +02:00
zstd.c
btrfs: replace GPL boilerplate by SPDX -- sources
2018-04-12 16:29:51 +02:00