iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Pavel Skripkin 9436cdffaf nilfs2: fix memory leak in nilfs_sysfs_delete_device_group 
[ Upstream commit 8fd0c1b0647a6bda4067ee0cd61e8395954b6f28 ]

My local syzbot instance hit memory leak in nilfs2.  The problem was in
missing kobject_put() in nilfs_sysfs_delete_device_group().

kobject_del() does not call kobject_cleanup() for passed kobject and it
leads to leaking duped kobject name if kobject_put() was not called.

Fail log:

  BUG: memory leak
  unreferenced object 0xffff8880596171e0 (size 8):
  comm "syz-executor379", pid 8381, jiffies 4294980258 (age 21.100s)
  hex dump (first 8 bytes):
    6c 6f 6f 70 30 00 00 00                          loop0...
  backtrace:
     kstrdup+0x36/0x70 mm/util.c:60
     kstrdup_const+0x53/0x80 mm/util.c:83
     kvasprintf_const+0x108/0x190 lib/kasprintf.c:48
     kobject_set_name_vargs+0x56/0x150 lib/kobject.c:289
     kobject_add_varg lib/kobject.c:384 [inline]
     kobject_init_and_add+0xc9/0x160 lib/kobject.c:473
     nilfs_sysfs_create_device_group+0x150/0x800 fs/nilfs2/sysfs.c:999
     init_nilfs+0xe26/0x12b0 fs/nilfs2/the_nilfs.c:637

Link: https://lkml.kernel.org/r/20210612140559.20022-1-paskripkin@gmail.com
Fixes: da7141fb78db ("nilfs2: add /sys/fs/nilfs2/<device> group")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: Michael L. Semon <mlsemon35@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-06-30 08:48:34 -04:00
..
9p
9P: Cast to loff_t before multiplying
2020-11-05 11:08:53 +01:00
adfs
fs/adfs: super: fix use-after-free bug
2019-08-06 19:06:49 +02:00
affs
fs/affs: release old buffer head on error path
2021-03-04 09:39:55 +01:00
afs
afs: Fix an IS_ERR() vs NULL check
2021-06-30 08:48:14 -04:00
autofs
autofs: fix a leak in autofs_expire_indirect()
2019-12-13 08:51:01 +01:00
befs
…
bfs
bfs: add sanity check at bfs_fill_super()
2018-12-01 09:37:27 +01:00
btrfs
btrfs: return value from btrfs_mark_extent_written() in case of error
2021-06-16 11:54:59 +02:00
cachefiles
cachefiles: Handle readpage error correctly
2020-11-05 11:08:54 +01:00
ceph
ceph: fix fscache invalidation
2021-05-22 10:59:49 +02:00
cifs
SMB3: incorrect file id in requests compounded with open
2021-06-03 08:38:10 +02:00
coda
coda: add error handling for fget
2019-08-06 19:06:51 +02:00
configfs
configfs: fix a use-after-free in __configfs_open_file
2021-03-17 16:43:51 +01:00
cramfs
Cramfs: fix abad comparison when wrap-arounds occur
2018-11-13 11:08:55 -08:00
crypto
fscrypt: add fscrypt_is_nokey_name()
2021-01-06 14:44:58 +01:00
debugfs
debugfs: fix use-after-free on symlink traversal
2019-05-08 07:21:48 +02:00
devpts
fs/devpts: always delete dcache dentry-s in dput()
2019-03-23 20:09:59 +01:00
dlm
fs: dlm: fix debugfs dump
2021-05-22 10:59:39 +02:00
ecryptfs
Revert "ecryptfs: replace BUG_ON with error handling code"
2021-05-26 11:48:34 +02:00
efivarfs
efivarfs: revert "fix memory leak in efivarfs_create()"
2020-12-02 08:48:12 +01:00
efs
…
exofs
exofs_mount(): fix leaks on failure exits
2019-12-05 09:20:32 +01:00
exportfs
exportfs: fix 'passing zero to ERR_PTR()' warning
2020-01-27 14:50:02 +01:00
ext2
ext2: don't update mtime on COW faults
2020-09-09 19:04:28 +02:00
ext4
ext4: fix bug on in ext4_es_cache_extent as ext4_split_extent_at failed
2021-06-10 13:24:06 +02:00
f2fs
f2fs: fix a redundant call to f2fs_balance_fs if an error occurs
2021-05-22 10:59:42 +02:00
fat
fat: don't allow to mount if the FAT length == 0
2020-06-22 09:05:08 +02:00
freevxfs
…
fscache
fscache: fix race between enablement and dropping of object
2018-12-17 09:24:40 +01:00
fuse
cuse: prevent clone
2021-05-22 10:59:41 +02:00
gfs2
gfs2: Fix use-after-free in gfs2_glock_shrink_scan
2021-06-30 08:48:11 -04:00
hfs
fs/hfs/extent.c: fix array out of bounds read of array extent
2019-12-01 09:17:10 +01:00
hfsplus
hfsplus: prevent corruption in shrinking truncate
2021-05-22 10:59:45 +02:00
hostfs
vfs: discard ATTR_ATTR_FLAG
2018-08-17 16:20:28 -07:00
hpfs
hpfs: remove unnecessary checks on the value of r when assigning error code
2018-08-25 12:42:33 -07:00
hugetlbfs
hugetlbfs: hugetlb_fault_mutex_hash() cleanup
2021-06-03 08:38:12 +02:00
isofs
isofs: release buffer head before return
2021-03-04 09:39:45 +01:00
jbd2
jbd2: abort journal if free a async write error metadata buffer
2020-09-03 11:24:24 +02:00
jffs2
jffs2: check the validity of dstlen in jffs2_zlib_compress()
2021-05-22 10:59:21 +02:00
jfs
JFS: more checks for invalid superblock
2021-03-07 12:18:54 +01:00
kernfs
kernfs: fix ino wrap-around detection
2019-12-13 08:52:43 +01:00
lockd
lockd: don't use interval-based rebinding over TCP
2020-12-30 11:25:59 +01:00
minix
fs/minix: remove expected error message in block_to_path()
2020-08-21 11:05:38 +02:00
nfs
NFSv4: nfs4_proc_set_acl needs to restore NFS_CAP_UIDGID_NOMAP on error.
2021-06-16 11:55:02 +02:00
nfs_common
nfs_common: need lock during iterate through the list
2020-12-30 11:26:02 +01:00
nfsd
nfsd4: readdirplus shouldn't return parent of export
2021-01-23 15:49:55 +01:00
nilfs2
nilfs2: fix memory leak in nilfs_sysfs_delete_device_group
2021-06-30 08:48:34 -04:00
nls
…
notify
fanotify: fix ignore mask logic for events on child and on dir
2020-06-30 23:17:00 -04:00
ntfs
ntfs: check for valid standard information attribute
2021-03-04 09:39:29 +01:00
ocfs2
ocfs2: fix data corruption by fallocate
2021-06-10 13:24:06 +02:00
omfs
…
openpromfs
…
orangefs
help_next should increase position index
2020-02-24 08:34:53 +01:00
overlayfs
ovl: fix missing revert_creds() on error path
2021-05-22 10:59:26 +02:00
proc
proc: only require mm_struct for writing
2021-06-16 11:55:02 +02:00
pstore
pstore: Fix typo in compression option name
2021-03-04 09:39:54 +01:00
qnx4
…
qnx6
…
quota
quota: Fix memory leak when handling corrupted quota file
2021-03-04 09:39:42 +01:00
ramfs
ramfs: fix nommu mmap with gaps in the page cache
2020-10-30 10:38:21 +01:00
reiserfs
reiserfs: update reiserfs_xattrs_initialized() condition
2021-04-07 12:48:50 +02:00
romfs
romfs: fix uninitialized memory leak in romfs_dev_read()
2020-08-26 10:30:59 +02:00
squashfs
squashfs: fix divide error in calculate_skip()
2021-05-22 10:59:45 +02:00
sysfs
sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output
2021-03-07 12:19:01 +01:00
sysv
sysv: return 'err' instead of 0 in __sysv_write_inode
2018-12-17 09:24:30 +01:00
tracefs
…
ubifs
ubifs: Only check replay with inode type to judge if inode linked
2021-05-22 10:59:19 +02:00
udf
udf: fix silent AED tagLocation corruption
2021-03-17 16:43:45 +01:00
ufs
fs/ufs: avoid potential u32 multiplication overflow
2020-08-21 11:05:38 +02:00
xfs
xfs: Fix assert failure in xfs_setattr_size()
2021-03-07 12:18:55 +01:00
aio.c
aio: fix async fsync creds
2020-06-22 09:05:01 +02:00
anon_inodes.c
…
attr.c
…
bad_inode.c
…
binfmt_aout.c
…
binfmt_elf_fdpic.c
…
binfmt_elf.c
fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()
2020-06-03 08:19:41 +02:00
binfmt_em86.c
…
binfmt_flat.c
fs/binfmt_flat.c: make load_flat_shared_library() work
2019-07-03 13:14:44 +02:00
binfmt_misc.c
binfmt_misc: fix possible deadlock in bm_register_write
2021-03-17 16:43:51 +01:00
binfmt_script.c
exec: load_script: Do not exec truncated interpreter path
2019-11-06 13:05:37 +01:00
block_dev.c
block: reexpand iov_iter after read/write
2021-05-22 10:59:49 +02:00
buffer.c
fs: Don't invalidate page buffers in block_write_full_page()
2020-11-05 11:08:46 +01:00
char_dev.c
chardev: Avoid potential use-after-free in 'chrdev_open()'
2020-01-14 20:06:57 +01:00
compat_binfmt_elf.c
…
compat_ioctl.c
fix compat handling of FICLONERANGE, FIDEDUPERANGE and FS_IOC_FIEMAP
2020-01-09 10:19:07 +01:00
compat.c
…
coredump.c
coredump: fix crash when umh is disabled
2020-05-14 07:57:21 +02:00
d_path.c
…
dax.c
dax: pass NOWAIT flag to iomap_apply
2020-03-05 16:42:12 +01:00
dcache.c
fs, fscrypt: clear DCACHE_ENCRYPTED_NAME when unaliasing directory
2020-11-05 11:08:35 +01:00
dcookies.c
…
direct-io.c
fs: direct-io: fix missing sdio->boundary
2021-04-14 08:22:32 +02:00
drop_caches.c
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:17:20 +01:00
eventfd.c
eventfd: track eventfd_signal() recursion depth
2020-02-11 04:34:08 -08:00
eventpoll.c
ep_create_wakeup_source(): dentry name can change under you...
2020-10-07 08:00:09 +02:00
exec.c
exit/exec: Seperate mm_release()
2021-01-30 13:32:11 +01:00
fcntl.c
fcntl: Fix potential deadlock in send_sig{io, urg}()
2021-01-06 14:45:00 +01:00
fhandle.c
…
file_table.c
overlayfs update for 4.19
2018-08-21 18:19:09 -07:00
file.c
fix multiplication overflow in copy_fdtable()
2020-05-27 17:37:29 +02:00
filesystems.c
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()
2020-04-17 10:48:51 +02:00
fs_pin.c
…
fs_struct.c
…
fs-writeback.c
memcg: fix a crash in wb_workfn when a device disappears
2021-02-13 13:51:15 +01:00
inode.c
futex: Fix inode life-time issue
2020-03-25 08:06:14 +01:00
internal.h
acct_on(): don't mess with freeze protection
2019-05-31 06:46:05 -07:00
ioctl.c
vfs: fix FIGETBSZ ioctl on an overlayfs file
2018-11-21 09:19:14 +01:00
iomap.c
iomap: fix sub-page uptodate handling
2021-05-22 10:59:50 +02:00
Kconfig
…
Kconfig.binfmt
…
libfs.c
libfs: fix error cast of negative value in simple_attr_write()
2020-11-24 13:27:23 +01:00
locks.c
locks: print unsigned ino in /proc/locks
2020-01-09 10:19:00 +01:00
Makefile
…
mbcache.c
…
mount.h
…
mpage.c
mpage: mpage_readpages() should submit IO as read-ahead
2018-08-17 16:20:29 -07:00
namei.c
namei: only return -ECHILD from follow_dotdot_rcu()
2020-03-05 16:42:20 +01:00
namespace.c
fs/namespace.c: fix mountpoint reference counter race
2020-04-29 16:31:26 +02:00
no-block.c
…
nsfs.c
dcache: sort the freeing-without-RCU-delay mess for good.
2019-05-25 18:23:26 +02:00
open.c
cifs_atomic_open(): fix double-put on late allocation failure
2020-03-18 07:14:21 +01:00
pipe.c
fs: prevent page refcount overflow in pipe_buf_get
2019-05-04 09:20:11 +02:00
pnode.c
propagate_one(): mnt_set_mountpoint() needs mount_lock
2020-05-02 17:26:01 +02:00
pnode.h
…
posix_acl.c
…
proc_namespace.c
…
read_write.c
vfs: avoid problematic remapping requests into partial EOF block
2019-12-01 09:17:04 +01:00
readdir.c
readdir: make sure to verify directory entry for legacy interfaces too
2021-04-28 13:16:50 +02:00
select.c
kernel, fs: Introduce and use set_restart_fn() and arch_set_restart_data()
2021-03-24 11:07:37 +01:00
seq_file.c
seq_file: fix problem when seeking mid-record
2019-08-25 10:47:43 +02:00
signalfd.c
fs/signalfd.c: fix inconsistent return codes for signalfd4
2020-08-26 10:31:02 +02:00
splice.c
splice: only read in as much information as there is pipe buffer space
2019-12-17 20:35:43 +01:00
stack.c
…
stat.c
…
statfs.c
vfs: Fix EOVERFLOW testing in put_compat_statfs64
2019-10-11 18:21:39 +02:00
super.c
vfs: remove lockdep bogosity in __sb_start_write
2020-11-24 13:27:20 +01:00
sync.c
…
timerfd.c
Merge branch 'work.aio' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-08-13 20:56:23 -07:00
userfaultfd.c
userfaultfd: require CAP_SYS_PTRACE for UFFD_FEATURE_EVENT_FORK
2020-01-04 19:13:18 +01:00
utimes.c
…
xattr.c
xattr: break delegations in {set,remove}xattr
2020-08-11 15:32:34 +02:00