iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/arch/arm/kernel
History
Yang Jihong 90639a0e19 arm_pmu: Fix write counter incorrect in ARMv7 big-endian mode 
commit fdbef8c4e68ad423416aa6cc93d1616d6f8ac5b3 upstream.

Commit 3a95200d3f89 ("arm_pmu: Change API to support 64bit counter values")
changes the input "value" type from 32-bit to 64-bit, which introduces the
following problem: ARMv7 PMU counters is 32-bit width, in big-endian mode,
write counter uses high 32-bit, which writes an incorrect value.

Before:

 Performance counter stats for 'ls':

              2.22 msec task-clock                #    0.675 CPUs utilized
                 0      context-switches          #    0.000 K/sec
                 0      cpu-migrations            #    0.000 K/sec
                49      page-faults               #    0.022 M/sec
        2150476593      cycles                    #  966.663 GHz
        2148588788      instructions              #    1.00  insn per cycle
        2147745484      branches                  # 965435.074 M/sec
        2147508540      branch-misses             #   99.99% of all branches

None of the above hw event counters are correct.

Solution:

"value" forcibly converted to 32-bit type before being written to PMU register.

After:

 Performance counter stats for 'ls':

              2.09 msec task-clock                #    0.681 CPUs utilized
                 0      context-switches          #    0.000 K/sec
                 0      cpu-migrations            #    0.000 K/sec
                46      page-faults               #    0.022 M/sec
           2807301      cycles                    #    1.344 GHz
           1060159      instructions              #    0.38  insn per cycle
            250496      branches                  #  119.914 M/sec
             23192      branch-misses             #    9.26% of all branches

Fixes: 3a95200d3f89 ("arm_pmu: Change API to support 64bit counter values")
Cc: <stable@vger.kernel.org>
Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20210430012659.232110-1-yangjihong1@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-07-20 16:15:39 +02:00
..
.gitignore
…
arch_timer.c
…
armksyms.c
ARM: 8745/1: get rid of __memzero()
2018-01-21 15:37:56 +00:00
asm-offsets.c
ARM: 9075/1: kernel: Fix interrupted SMC calls
2021-05-22 10:59:49 +02:00
atags_compat.c
…
atags_parse.c
ARM: better diagnostics with missing/corrupt dtb
2017-09-29 13:57:21 +01:00
atags_proc.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
atags.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
bios32.c
PCI: Remove PCI_REASSIGN_ALL_RSRC use on arm and arm64
2017-12-18 23:07:43 -06:00
bugs.c
ARM: clean up per-processor check_bugs method call
2019-02-20 10:25:38 +01:00
cpuidle.c
ARM: Convert to using %pOF instead of full_name
2017-08-16 22:25:30 +02:00
crash_dump.c
…
debug.S
Merge branches 'fixes', 'misc' and 'sa1111-for-next' into for-next
2017-11-08 19:42:43 +00:00
devtree.c
ARM: Convert to using %pOF instead of full_name
2017-08-16 22:25:30 +02:00
dma-isa.c
…
dma.c
proc: introduce proc_create_single{,_data}
2018-05-16 07:23:35 +02:00
early_printk.c
ARM: 8705/1: early_printk: use printascii() rather than printch()
2017-10-12 11:29:29 +01:00
efi.c
ARM/efi: Apply strict permissions for UEFI Runtime Services regions
2016-04-28 11:33:53 +02:00
elf.c
Merge branch 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-arm
2017-11-16 12:50:35 -08:00
entry-armv.S
ARM: uaccess: consolidate uaccess asm to asm/uaccess-asm.h
2020-06-03 08:19:34 +02:00
entry-common.S
ARM: 8802/1: Call syscall_trace_exit even when system call skipped
2019-11-24 08:20:56 +01:00
entry-ftrace.S
ARM: 8678/1: ftrace: Adds support for CONFIG_DYNAMIC_FTRACE_WITH_REGS
2017-06-18 22:25:16 +01:00
entry-header.S
ARM: uaccess: consolidate uaccess asm to asm/uaccess-asm.h
2020-06-03 08:19:34 +02:00
entry-v7m.S
ARM: 8830/1: NOMMU: Toggle only bits in EXC_RETURN we are really care of
2019-04-05 22:33:12 +02:00
fiq.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fiqasm.S
…
ftrace.c
ARM: function_graph: Simplify with function_graph_enter()
2018-12-05 19:32:09 +01:00
head-common.S
ARM: 8914/1: NOMMU: Fix exc_ret for XIP
2019-11-06 13:06:10 +01:00
head-inflate-data.c
ARM: XIP kernel: store .data compressed in ROM
2017-09-10 19:34:53 -04:00
head-nommu.S
ARM: 8849/1: NOMMU: Fix encodings for PMSAv8's PRBAR4/PRLAR4
2020-01-27 14:50:28 +01:00
head.S
ARM: p2v: fix handling of LPAE translation in BE mode
2020-12-30 11:25:50 +01:00
hibernate.c
ARM: use virt_to_idmap() for soft_restart()
2016-02-08 15:48:32 +00:00
hw_breakpoint.c
ARM: 9064/1: hw_breakpoint: Do not directly check the event's overflow_handler hook
2021-05-22 10:59:42 +02:00
hyp-stub.S
ARM: 8955/1: virt: Relax arch timer version check during early boot
2020-02-05 14:43:50 +00:00
insn.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
io.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
irq.c
ARM: 8824/1: fix a migrating irq bug when hotplug cpu
2019-03-23 20:09:48 +01:00
isa.c
…
iwmmxt.S
ARM: align .data section
2017-08-14 16:22:55 +01:00
jump_label.c
jump_label: move 'asm goto' support test to Kconfig
2019-06-04 08:02:34 +02:00
kgdb.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
machine_kexec.c
ARM: kexec: fix oops after TLB are invalidated
2021-02-23 15:00:57 +01:00
Makefile
ARM: bugs: prepare processor bug infrastructure
2018-05-31 10:39:18 +01:00
module-plts.c
ARM: 8662/1: module: split core and init PLT sections
2017-03-17 10:01:28 +00:00
module.c
ARM: Silence first allocation with CONFIG_ARM_MODULE_PLTS=y
2017-05-11 14:43:31 +01:00
module.lds
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
opcodes.c
…
paravirt.c
…
patch.c
ARM: 8839/1: kprobe: make patch_lock a raw_spinlock_t
2019-04-20 09:16:04 +02:00
perf_callchain.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
perf_event_v6.c
arm_pmu: Tidy up clear_event_idx call backs
2018-07-10 18:19:02 +01:00
perf_event_v7.c
arm_pmu: Fix write counter incorrect in ARMv7 big-endian mode
2021-07-20 16:15:39 +02:00
perf_event_xscale.c
arm_pmu: Tidy up clear_event_idx call backs
2018-07-10 18:19:02 +01:00
perf_regs.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
pj4-cp0.c
…
process.c
mm: zero out the vma in vma_init()
2018-08-22 10:52:44 -07:00
psci_smp.c
…
ptrace.c
ARM: 8977/1: ptrace: Fix mask for thumb breakpoint hook
2020-06-22 09:04:59 +02:00
reboot.c
ARM: soft-reboot into same mode that we entered the kernel
2017-04-09 07:49:24 -07:00
reboot.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
relocate_kernel.S
ARM: kexec: fix oops after TLB are invalidated
2021-02-23 15:00:57 +01:00
return_address.c
…
setup.c
ARM: 9081/1: fix gcc-10 thumb2-kernel regression
2021-06-30 08:48:28 -04:00
signal.c
ARM: ensure the signal page contains defined contents
2021-02-23 15:00:57 +01:00
signal.h
ARM: signal handling support for FDPIC_FUNCPTRS functions
2017-09-10 19:31:46 -04:00
sigreturn_codes.S
ARM: signal handling support for FDPIC_FUNCPTRS functions
2017-09-10 19:31:46 -04:00
sleep.S
ARM: 8847/1: pm: fix HYP/SVC mode mismatch when MCPM is used
2020-01-27 14:50:28 +01:00
smccc-call.S
ARM: 9075/1: kernel: Fix interrupted SMC calls
2021-05-22 10:59:49 +02:00
smp_scu.c
ARM: smp_scu: allow the platform code to read the SCU CPU status
2017-10-29 08:29:30 -07:00
smp_tlb.c
ARM: 8613/1: Fix the uaccess crash on PB11MPCore
2017-01-16 17:30:46 +00:00
smp_twd.c
clocksource/drivers: Rename CLOCKSOURCE_OF_DECLARE to TIMER_OF_DECLARE
2017-06-14 11:58:45 +02:00
smp.c
ARM: prevent tracing IPI_CPU_BACKTRACE
2019-06-15 11:54:00 +02:00
stacktrace.c
ARM: 8948/1: Prevent OOB access in stacktrace
2020-10-01 13:14:31 +02:00
suspend.c
ARM: 9066/1: ftrace: pause/unpause function graph tracer in cpu_suspend()
2021-05-22 10:59:48 +02:00
swp_emulate.c
Merge branch 'siginfo-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2018-06-04 15:23:48 -07:00
sys_arm.c
mm: add ksys_fadvise64_64() helper; remove in-kernel call to sys_fadvise64_64()
2018-04-02 20:16:10 +02:00
sys_oabi-compat.c
ARM: 8792/1: oabi-compat: copy oabi events using __copy_to_user()
2019-02-20 10:25:36 +01:00
tcm.c
…
thumbee.c
…
time.c
ARM/time: Remove read_boot_clock64()
2018-07-20 00:02:41 +02:00
topology.c
ARM: Convert to using %pOF instead of full_name
2017-08-16 22:25:30 +02:00
traps.c
ARM: 8948/1: Prevent OOB access in stacktrace
2020-10-01 13:14:31 +02:00
unwind.c
ARM: 8840/1: use a raw_spinlock_t in unwind
2019-04-05 22:33:01 +02:00
v7m.c
…
vdso.c
ARM: 8957/1: VDSO: Match ARMv8 timer in cntvct_functional()
2020-03-20 11:55:59 +01:00
vmlinux-xip.lds.S
ARM: 8757/1: NOMMU: Support PMSAv8 MPU
2018-05-19 11:53:46 +01:00
vmlinux.lds.h
vmlinux.lds.h: Fix incomplete .text.exit discards
2018-10-12 08:54:58 +11:00
vmlinux.lds.S
ARM: 8757/1: NOMMU: Support PMSAv8 MPU
2018-05-19 11:53:46 +01:00
xscale-cp0.c
…