Zheyu Ma
adbda14730
can: peak_pci: peak_pci_remove(): fix UAF ...
commit 949fe9b35570361bc6ee2652f89a0561b26eec98 upstream.
When remove the module peek_pci, referencing 'chan' again after
releasing 'dev' will cause UAF.
Fix this by releasing 'dev' later.
The following log reveals it:
[ 35.961814 ] BUG: KASAN: use-after-free in peak_pci_remove+0x16f/0x270 [peak_pci]
[ 35.963414 ] Read of size 8 at addr ffff888136998ee8 by task modprobe/5537
[ 35.965513 ] Call Trace:
[ 35.965718 ] dump_stack_lvl+0xa8/0xd1
[ 35.966028 ] print_address_description+0x87/0x3b0
[ 35.966420 ] kasan_report+0x172/0x1c0
[ 35.966725 ] ? peak_pci_remove+0x16f/0x270 [peak_pci]
[ 35.967137 ] ? trace_irq_enable_rcuidle+0x10/0x170
[ 35.967529 ] ? peak_pci_remove+0x16f/0x270 [peak_pci]
[ 35.967945 ] __asan_report_load8_noabort+0x14/0x20
[ 35.968346 ] peak_pci_remove+0x16f/0x270 [peak_pci]
[ 35.968752 ] pci_device_remove+0xa9/0x250
Fixes: e6d9c80b7ca1 ("can: peak_pci: add support of some new PEAK-System PCI cards")
Link: https://lore.kernel.org/all/1634192913-15639-1-git-send-email-zheyuma97@gmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-27 09:53:13 +02:00
2021-03-30 14:37:01 +02:00
2021-03-30 14:37:01 +02:00
2020-01-14 20:07:02 +01:00
2021-07-20 16:15:41 +02:00
2021-10-27 09:53:13 +02:00
2021-10-27 09:53:13 +02:00
2020-12-30 11:25:44 +01:00
2021-08-04 12:23:46 +02:00
2021-10-27 09:53:13 +02:00
2021-03-30 14:37:03 +02:00
2021-03-30 14:37:01 +02:00
2020-11-18 19:18:42 +01:00
2020-04-13 10:45:08 +02:00
2020-11-24 13:27:22 +01:00
2021-01-27 11:05:39 +01:00
2019-12-13 08:52:08 +01:00
adbda14730