iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv4
History
Eric Dumazet 0a70f11847 tcp: fix possible socket leaks in internal pacing mode 
This patch is addressing an issue in stable linux-4.19 only.

In linux-4.20, TCP stack adopted EDT (Earliest Departure
Time) model and this issue was incidentally fixed.

Issue at hand was an extra sock_hold() from tcp_internal_pacing()
in paths not using tcp_xmit_retransmit_queue()

Jason Xing reported this leak and provided a patch stopping
the extra sock_hold() to happen.

This patch is more complete and makes sure to avoid
unnecessary extra delays, by reprogramming the high
resolution timer.

Fixes: 73a6bab5aa2a ("tcp: switch pacing timer to softirq based hrtimer")
Reference: https://lore.kernel.org/all/CANn89i+7-wE4xr5D9DpH+N-xkL1SB8oVghCKgz+CT5eG1ODQhA@mail.gmail.com/
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Jason Xing <kerneljasonxing@gmail.com>
Reported-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Cc: liweishi <liweishi@kuaishou.com>
Cc: Shujin Li <lishujin@kuaishou.com>
Cc: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-02-08 18:23:12 +01:00
..
bpfilter
bpfilter: remove trailing newline
2018-07-24 14:10:42 -07:00
netfilter
netfilter: ipt_CLUSTERIP: fix refcount leak in clusterip_tg_check()
2022-01-27 09:04:20 +01:00
af_inet.c
net: fix use-after-free in tw_timer_handler
2022-01-05 12:35:00 +01:00
ah4.c
net: use -ENOSPC for transient busy indication
2017-11-03 22:11:17 +08:00
arp.c
proc: introduce proc_create_net{,_data}
2018-05-16 07:24:30 +02:00
cipso_ipv4.c
net: ipv4: fix memory leak in netlbl_cipsov4_add_std
2021-06-30 08:48:15 -04:00
datagram.c
inet: stop leaking jiffies on the wire
2019-11-10 11:27:37 +01:00
devinet.c
net: return correct error code
2021-12-08 08:50:11 +01:00
esp4_offload.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2018-07-27 09:33:37 -07:00
esp4.c
esp: avoid unneeded kmap_atomic call
2021-01-23 15:49:55 +01:00
fib_frontend.c
net/ipv4: swap flow ports when validating source
2021-07-20 16:15:51 +02:00
fib_lookup.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fib_notifier.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fib_rules.c
net: fib_rules: add extack support
2018-04-23 10:21:24 -04:00
fib_semantics.c
net: Fix the arp error in some cases
2020-06-30 23:17:06 -04:00
fib_trie.c
ipv4: Silence suspicious RCU usage warning
2020-08-11 15:32:34 +02:00
fou.c
net: fou: do not use guehdr after iptunnel_pull_offloads in gue_udp_recv
2019-04-27 09:36:31 +02:00
gre_demux.c
erspan: fix version 1 check in gre_parse_header()
2021-01-12 20:10:19 +01:00
gre_offload.c
net: gre: recompute gre csum for sctp over gre tunnels
2020-08-11 15:32:34 +02:00
icmp.c
ipv4/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)
2021-09-22 11:47:47 +02:00
igmp.c
igmp: Add ip_mc_list lock in ip_check_mc_rcu
2021-09-22 11:47:47 +02:00
inet_connection_sock.c
tcp: relookup sock for RST+ACK packets handled by obsolete req sock
2021-04-07 12:48:47 +02:00
inet_diag.c
inet_diag: Fix error path to cancel the meseage in inet_req_diag_fill()
2020-11-24 13:27:16 +01:00
inet_fragment.c
net: IP defrag: encapsulate rbtree defrag code into callable functions
2019-04-27 09:36:33 +02:00
inet_hashtables.c
net: initialize fastreuse on inet_inherit_port
2020-08-19 08:15:04 +02:00
inet_timewait_sock.c
soreuseport: initialise timewait reuseport field
2018-04-07 22:32:32 -04:00
inetpeer.c
inetpeer: fix data-race in inet_putpeer / inet_putpeer
2020-01-04 19:13:29 +01:00
ip_forward.c
net: clear skb->tstamp in forwarding paths
2019-01-09 17:38:31 +01:00
ip_fragment.c
net: IP defrag: encapsulate rbtree defrag code into callable functions
2019-04-27 09:36:33 +02:00
ip_gre.c
ip_gre: validate csum_start only on pull
2021-09-22 11:48:14 +02:00
ip_input.c
vrf: check accept_source_route on the original netdevice
2019-04-17 08:38:42 +02:00
ip_options.c
vrf: check accept_source_route on the original netdevice
2019-04-17 08:38:42 +02:00
ip_output.c
ipv4: tcp: send zero IPID in SYNACK messages
2022-02-08 18:23:11 +01:00
ip_sockglue.c
net: bpfilter: fix iptables failure if bpfilter_umh is disabled
2019-12-01 09:17:18 +01:00
ip_tunnel_core.c
ip_tunnel: allow not to count pkts on tstats by setting skb's dev to NULL
2019-08-04 09:30:57 +02:00
ip_tunnel.c
net: ip_tunnel: fix mtu calculation for ETHER tunnel devices
2021-07-28 11:13:46 +02:00
ip_vti.c
ip_vti: receive ipip packet by calling ip_tunnel_rcv
2020-06-03 08:19:46 +02:00
ipcomp.c
…
ipconfig.c
net: ipconfig: Don't override command-line hostnames or domains
2021-06-30 08:48:13 -04:00
ipip.c
net: ipip: fix wrong address family in init error path
2020-06-03 08:19:10 +02:00
ipmr_base.c
net: ipmr: fix unresolved entry dumps
2018-10-17 22:35:42 -07:00
ipmr.c
ipmr: Fix skb headroom in ipmr_get_route().
2019-11-20 18:45:11 +01:00
Kconfig
vti[6]: fix packet tx through bpf_redirect() in XinY cases
2020-04-02 15:28:18 +02:00
Makefile
net: remove blank lines at end of file
2018-07-24 14:10:43 -07:00
metrics.c
net: metrics: add proper netlink validation
2018-06-05 12:29:43 -04:00
netfilter.c
netfilter: use actual socket sk rather than skb sk when routing harder
2020-11-18 19:18:44 +01:00
netlink.c
ipv4: Add ICMPv6 support when parse route ipproto
2019-03-10 07:17:17 +01:00
ping.c
ping: fix the sk_bound_dev_if match in ping_lookup
2022-02-08 18:23:08 +01:00
proc.c
tcp: tcp_fragment() should apply sane memory limits
2019-06-17 19:51:56 +02:00
protocol.c
…
raw_diag.c
inet_diag: return classid for all socket types
2020-03-18 07:14:11 +01:00
raw.c
ipv4: raw: lock the socket in raw_bind()
2022-02-08 18:23:11 +01:00
route.c
ipv4: use siphash instead of Jenkins in fnhe_hashfun()
2021-11-02 18:26:44 +01:00
syncookies.c
net: Update window_clamp if SOCK_RCVBUF is set
2020-11-18 19:18:51 +01:00
sysctl_net_ipv4.c
tcp: add tcp_min_snd_mss sysctl
2019-06-17 19:51:56 +02:00
tcp_bbr.c
tcp_bbr: fix u32 wrap bug in round logic if bbr_init() called after 2B packets
2021-08-26 08:36:39 -04:00
tcp_bic.c
…
tcp_cdg.c
…
tcp_cong.c
net: Only allow init netns to set default tcp cong to a restricted algo
2021-05-22 10:59:39 +02:00
tcp_cubic.c
tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows
2021-12-01 09:27:43 +01:00
tcp_dctcp.c
tcp: Ensure DCTCP reacts to losses
2019-04-17 08:38:41 +02:00
tcp_diag.c
tcp: annotate tp->write_seq lockless reads
2021-03-17 16:43:43 +01:00
tcp_fastopen.c
tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD
2021-09-22 11:48:07 +02:00
tcp_highspeed.c
…
tcp_htcp.c
…
tcp_hybla.c
…
tcp_illinois.c
net/tcp/illinois: replace broken algorithm reference link
2018-02-28 12:03:47 -05:00
tcp_input.c
tcp: address problems caused by EDT misshaps
2021-10-06 15:31:19 +02:00
tcp_ipv4.c
tcp: seq_file: Avoid skipping sk during tcp_seek_last_pos
2021-09-22 11:47:52 +02:00
tcp_lp.c
…
tcp_metrics.c
net: Drop pernet_operations::async
2018-03-27 13:18:09 -04:00
tcp_minisocks.c
tcp: relookup sock for RST+ACK packets handled by obsolete req sock
2021-04-07 12:48:47 +02:00
tcp_nv.c
tcp_nv: fix potential integer overflow in tcpnv_acked
2018-01-31 10:26:30 -05:00
tcp_offload.c
tcp: Don't coalesce decrypted and encrypted SKBs
2018-07-16 00:12:09 -07:00
tcp_output.c
tcp: fix possible socket leaks in internal pacing mode
2022-02-08 18:23:12 +01:00
tcp_rate.c
tcp: expose both send and receive intervals for rate sample
2018-07-11 23:01:56 -07:00
tcp_recovery.c
tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN
2021-02-03 23:23:27 +01:00
tcp_scalable.c
…
tcp_timer.c
tcp: adjust rto_base in retransmits_timed_out()
2021-10-06 15:31:20 +02:00
tcp_ulp.c
tcp, ulp: fix leftover icsk_ulp_ops preventing sock from reattach
2018-08-16 14:58:08 -07:00
tcp_vegas.c
…
tcp_vegas.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
tcp_veno.c
…
tcp_westwood.c
…
tcp_yeah.c
…
tcp.c
tcp: don't free a FIN sk_buff in tcp_remove_empty_skb()
2021-11-26 11:36:11 +01:00
tunnel4.c
inet: whitespace cleanup
2018-02-28 11:43:28 -05:00
udp_diag.c
inet_diag: return classid for all socket types
2020-03-18 07:14:11 +01:00
udp_impl.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
udp_offload.c
net: Fix gro aggregation for udp encaps with zero csum
2021-03-17 16:43:42 +01:00
udp_tunnel.c
…
udp.c
net: udp: fix alignment problem in udp4_seq_show()
2022-01-11 13:58:50 +01:00
udplite.c
proc: introduce proc_create_net{,_data}
2018-05-16 07:24:30 +02:00
xfrm4_input.c
xfrm: reset transport header back to network header after all input transforms ahave been applied
2018-09-04 10:26:30 +02:00
xfrm4_mode_beet.c
…
xfrm4_mode_transport.c
xfrm: reset transport header back to network header after all input transforms ahave been applied
2018-09-04 10:26:30 +02:00
xfrm4_mode_tunnel.c
xfrm: Verify MAC header exists before overwriting eth_hdr(skb)->h_proto
2018-03-07 10:54:29 +01:00
xfrm4_output.c
xfrm: Always set XFRM_TRANSFORMED in xfrm{4,6}_output_finish
2020-04-29 16:31:23 +02:00
xfrm4_policy.c
net: add bool confirm_neigh parameter for dst_ops.update_pmtu
2020-01-04 19:13:37 +01:00
xfrm4_protocol.c
…
xfrm4_state.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xfrm4_tunnel.c
…