Yang Yingliang
a3730f7415
iio: accel: kxcjk-1013: Fix possible memory leak in probe and remove ...
commit 70c9774e180d151abaab358108e3510a8e615215 upstream.
When ACPI type is ACPI_SMO8500, the data->dready_trig will not be set, the
memory allocated by iio_triggered_buffer_setup() will not be freed, and cause
memory leak as follows:
unreferenced object 0xffff888009551400 (size 512):
comm "i2c-SMO8500-125", pid 911, jiffies 4294911787 (age 83.852s)
hex dump (first 32 bytes):
02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 20 e2 e5 c0 ff ff ff ff ........ .......
backtrace:
[<0000000041ce75ee>] kmem_cache_alloc_trace+0x16d/0x360
[<000000000aeb17b0>] iio_kfifo_allocate+0x41/0x130 [kfifo_buf]
[<000000004b40c1f5>] iio_triggered_buffer_setup_ext+0x2c/0x210 [industrialio_triggered_buffer]
[<000000004375b15f>] kxcjk1013_probe+0x10c3/0x1d81 [kxcjk_1013]
Fix it by remove data->dready_trig condition in probe and remove.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: a25691c1f967 ("iio: accel: kxcjk1013: allow using an external trigger")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Cc: <Stable@vger.kernel.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20211025124159.2700301-1-yangyingliang@huawei.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-12-14 10:18:10 +01:00
2021-12-14 10:18:10 +01:00
2021-12-14 10:18:09 +01:00
2020-09-17 13:45:28 +02:00
2021-10-20 11:23:03 +02:00
2021-11-26 11:36:03 +01:00
2021-12-14 10:18:09 +01:00
2020-07-22 09:32:05 +02:00
2021-08-26 08:36:35 -04:00
2021-07-20 16:15:53 +02:00
2021-12-14 10:18:09 +01:00
2021-01-09 13:43:48 +01:00
2021-07-20 16:15:54 +02:00
2020-12-30 11:26:16 +01:00
2021-07-20 16:15:56 +02:00
2021-03-24 11:07:36 +01:00
2021-12-14 10:18:09 +01:00
2020-12-30 11:26:15 +01:00
2019-04-27 09:36:35 +02:00
2021-12-14 10:18:09 +01:00
a3730f7415