Antoine Tenart 0be943916d net: fix a memleak when uncloning an skb dst and its metadata
[ Upstream commit 9eeabdf17fa0ab75381045c867c370f4cc75a613 ]

When uncloning an skb dst and its associated metadata, a new
dst+metadata is allocated and later replaces the old one in the skb.
This is helpful to have a non-shared dst+metadata attached to a specific
skb.

The issue is the uncloned dst+metadata is initialized with a refcount of
1, which is increased to 2 before attaching it to the skb. When
tun_dst_unclone returns, the dst+metadata is only referenced from a
single place (the skb) while its refcount is 2. Its refcount will never
drop to 0 (when the skb is consumed), leading to a memory leak.

Fix this by removing the call to dst_hold in tun_dst_unclone, as the
dst+metadata refcount is already 1.

Fixes: fc4099f17240 ("openvswitch: Fix egress tunnel info.")
Cc: Pravin B Shelar <pshelar@ovn.org>
Reported-by: Vlad Buslov <vladbu@nvidia.com>
Tested-by: Vlad Buslov <vladbu@nvidia.com>
Signed-off-by: Antoine Tenart <atenart@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-02-16 12:51:46 +01:00
..
2019-07-03 13:14:42 +02:00
2021-06-10 13:24:06 +02:00
2019-03-23 20:09:51 +01:00
2022-01-05 12:34:58 +01:00
2019-02-23 09:07:27 +01:00
2018-02-28 11:43:28 -05:00
2019-11-10 11:27:54 +01:00
2020-07-22 09:31:58 +02:00
2017-12-11 14:10:06 -05:00
2021-08-04 12:23:46 +02:00
2018-06-18 22:40:32 +02:00
2018-04-07 22:32:31 -04:00
2017-11-08 16:12:33 +09:00
2021-12-14 10:18:04 +01:00
2018-05-16 07:23:35 +02:00
2018-05-16 07:23:35 +02:00
2018-06-22 13:43:27 +09:00
2018-06-22 13:43:27 +09:00
2018-04-17 13:53:13 -04:00