iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv4
History
Eric Dumazet 824bc1fd2e icmp: guard against too small mtu 
[ Upstream commit 7d63b67125382ff0ffdfca434acbc94a38bd092b ]

syzbot was able to trigger a panic [1] in icmp_glue_bits(), or
more exactly in skb_copy_and_csum_bits()

There is no repro yet, but I think the issue is that syzbot
manages to lower device mtu to a small value, fooling __icmp_send()

__icmp_send() must make sure there is enough room for the
packet to include at least the headers.

We might in the future refactor skb_copy_and_csum_bits() and its
callers to no longer crash when something bad happens.

[1]
kernel BUG at net/core/skbuff.c:3343 !
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 15766 Comm: syz-executor.0 Not tainted 6.3.0-rc4-syzkaller-00039-gffe78bbd5121 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
RIP: 0010:skb_copy_and_csum_bits+0x798/0x860 net/core/skbuff.c:3343
Code: f0 c1 c8 08 41 89 c6 e9 73 ff ff ff e8 61 48 d4 f9 e9 41 fd ff ff 48 8b 7c 24 48 e8 52 48 d4 f9 e9 c3 fc ff ff e8 c8 27 84 f9 <0f> 0b 48 89 44 24 28 e8 3c 48 d4 f9 48 8b 44 24 28 e9 9d fb ff ff
RSP: 0018:ffffc90000007620 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 00000000000001e8 RCX: 0000000000000100
RDX: ffff8880276f6280 RSI: ffffffff87fdd138 RDI: 0000000000000005
RBP: 0000000000000000 R08: 0000000000000005 R09: 0000000000000000
R10: 00000000000001e8 R11: 0000000000000001 R12: 000000000000003c
R13: 0000000000000000 R14: ffff888028244868 R15: 0000000000000b0e
FS: 00007fbc81f1c700(0000) GS:ffff88802ca00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b2df43000 CR3: 00000000744db000 CR4: 0000000000150ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<IRQ>
icmp_glue_bits+0x7b/0x210 net/ipv4/icmp.c:353
__ip_append_data+0x1d1b/0x39f0 net/ipv4/ip_output.c:1161
ip_append_data net/ipv4/ip_output.c:1343 [inline]
ip_append_data+0x115/0x1a0 net/ipv4/ip_output.c:1322
icmp_push_reply+0xa8/0x440 net/ipv4/icmp.c:370
__icmp_send+0xb80/0x1430 net/ipv4/icmp.c:765
ipv4_send_dest_unreach net/ipv4/route.c:1239 [inline]
ipv4_link_failure+0x5a9/0x9e0 net/ipv4/route.c:1246
dst_link_failure include/net/dst.h:423 [inline]
arp_error_report+0xcb/0x1c0 net/ipv4/arp.c:296
neigh_invalidate+0x20d/0x560 net/core/neighbour.c:1079
neigh_timer_handler+0xc77/0xff0 net/core/neighbour.c:1166
call_timer_fn+0x1a0/0x580 kernel/time/timer.c:1700
expire_timers+0x29b/0x4b0 kernel/time/timer.c:1751
__run_timers kernel/time/timer.c:2022 [inline]

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: syzbot+d373d60fddbdc915e666@syzkaller.appspotmail.com
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20230330174502.1915328-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-04-20 12:04:38 +02:00
..
bpfilter
bpfilter: remove trailing newline
2018-07-24 14:10:42 -07:00
netfilter
netfilter: nft_fib: Fix for rpath check with VRF devices
2022-10-26 13:19:25 +02:00
af_inet.c
tcp/udp: Make early_demux back namespacified.
2022-11-10 17:46:54 +01:00
ah4.c
…
arp.c
ipv4: Invalidate neighbour for broadcast address upon address addition
2022-04-15 14:15:01 +02:00
cipso_ipv4.c
cipso: Fix data-races around sysctl.
2022-07-21 21:09:28 +02:00
datagram.c
inet: stop leaking jiffies on the wire
2019-11-10 11:27:37 +01:00
devinet.c
net: return correct error code
2021-12-08 08:50:11 +01:00
esp4_offload.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2018-07-27 09:33:37 -07:00
esp4.c
esp: limit skb_page_frag_refill use to a single page
2022-07-12 16:29:00 +02:00
fib_frontend.c
ipv4: Fix incorrect table ID in IOCTL path
2023-03-22 13:27:10 +01:00
fib_lookup.h
…
fib_notifier.c
…
fib_rules.c
net: fib_rules: add extack support
2018-04-23 10:21:24 -04:00
fib_semantics.c
net: Fix the arp error in some cases
2020-06-30 23:17:06 -04:00
fib_trie.c
ipv4: Silence suspicious RCU usage warning
2020-08-11 15:32:34 +02:00
fou.c
net: fou: do not use guehdr after iptunnel_pull_offloads in gue_udp_recv
2019-04-27 09:36:31 +02:00
gre_demux.c
erspan: fix version 1 check in gre_parse_header()
2021-01-12 20:10:19 +01:00
gre_offload.c
net: gre: recompute gre csum for sctp over gre tunnels
2020-08-11 15:32:34 +02:00
icmp.c
icmp: guard against too small mtu
2023-04-20 12:04:38 +02:00
igmp.c
igmp: Fix data-races around sysctl_igmp_qrv.
2022-08-11 12:48:39 +02:00
inet_connection_sock.c
tcp: Fix listen() regression in 4.19.270
2023-03-11 16:32:02 +01:00
inet_diag.c
inet_diag: Fix error path to cancel the meseage in inet_req_diag_fill()
2020-11-24 13:27:16 +01:00
inet_fragment.c
net: IP defrag: encapsulate rbtree defrag code into callable functions
2019-04-27 09:36:33 +02:00
inet_hashtables.c
inet: fix fast path in __inet_hash_connect()
2023-03-11 16:31:46 +01:00
inet_timewait_sock.c
tcp: avoid the lookup process failing to get sk in ehash table
2023-02-06 07:49:40 +01:00
inetpeer.c
inetpeer: Fix data-races around sysctl.
2022-07-21 21:09:27 +02:00
ip_forward.c
net: clear skb->tstamp in forwarding paths
2019-01-09 17:38:31 +01:00
ip_fragment.c
net: IP defrag: encapsulate rbtree defrag code into callable functions
2019-04-27 09:36:33 +02:00
ip_gre.c
erspan: do not use skb_mac_header() in ndo_start_xmit()
2023-04-05 11:15:34 +02:00
ip_input.c
tcp/udp: Make early_demux back namespacified.
2022-11-10 17:46:54 +01:00
ip_options.c
vrf: check accept_source_route on the original netdevice
2019-04-17 08:38:42 +02:00
ip_output.c
ipv4: tcp: send zero IPID in SYNACK messages
2022-02-08 18:23:11 +01:00
ip_sockglue.c
net: bpfilter: fix iptables failure if bpfilter_umh is disabled
2019-12-01 09:17:18 +01:00
ip_tunnel_core.c
ip_tunnel: allow not to count pkts on tstats by setting skb's dev to NULL
2019-08-04 09:30:57 +02:00
ip_tunnel.c
net: tunnels: annotate lockless accesses to dev->needed_headroom
2023-03-22 13:27:09 +01:00
ip_vti.c
ip_vti: receive ipip packet by calling ip_tunnel_rcv
2020-06-03 08:19:46 +02:00
ipcomp.c
…
ipconfig.c
net: ipconfig: Don't override command-line hostnames or domains
2021-06-30 08:48:13 -04:00
ipip.c
net: ipip: fix wrong address family in init error path
2020-06-03 08:19:10 +02:00
ipmr_base.c
net: ipmr: fix unresolved entry dumps
2018-10-17 22:35:42 -07:00
ipmr.c
ipmr,ip6mr: acquire RTNL before calling ip[6]mr_free_table() on failure path
2022-02-16 12:51:45 +01:00
Kconfig
tcp: configurable source port perturb table size
2022-12-08 11:18:31 +01:00
Makefile
net: remove blank lines at end of file
2018-07-24 14:10:43 -07:00
metrics.c
ipv4: prevent potential spectre v1 gadget in ip_metrics_convert()
2023-02-06 07:49:43 +01:00
netfilter.c
netfilter: use actual socket sk rather than skb sk when routing harder
2020-11-18 19:18:44 +01:00
netlink.c
ipv4: Add ICMPv6 support when parse route ipproto
2019-03-10 07:17:17 +01:00
ping.c
ping: fix address binding wrt vrf
2022-05-18 09:42:50 +02:00
proc.c
tcp: tcp_fragment() should apply sane memory limits
2019-06-17 19:51:56 +02:00
protocol.c
…
raw_diag.c
inet_diag: return classid for all socket types
2020-03-18 07:14:11 +01:00
raw.c
net: add missing SOF_TIMESTAMPING_OPT_ID support
2022-04-15 14:15:04 +02:00
route.c
ip: Fix data-races around sysctl_ip_fwd_use_pmtu.
2022-07-29 17:10:31 +02:00
syncookies.c
tcp: make sure treq->af_specific is initialized
2022-05-12 12:20:25 +02:00
sysctl_net_ipv4.c
tcp/udp: Make early_demux back namespacified.
2022-11-10 17:46:54 +01:00
tcp_bbr.c
tcp_bbr: fix u32 wrap bug in round logic if bbr_init() called after 2B packets
2021-08-26 08:36:39 -04:00
tcp_bic.c
…
tcp_cdg.c
tcp: cdg: allow tcp_cdg_release() to be called multiple times
2022-11-25 17:40:28 +01:00
tcp_cong.c
net: Only allow init netns to set default tcp cong to a restricted algo
2021-05-22 10:59:39 +02:00
tcp_cubic.c
tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows
2021-12-01 09:27:43 +01:00
tcp_dctcp.c
tcp: Ensure DCTCP reacts to losses
2019-04-17 08:38:41 +02:00
tcp_diag.c
tcp: annotate tp->write_seq lockless reads
2021-03-17 16:43:43 +01:00
tcp_fastopen.c
tcp: Fix data-races around sysctl_tcp_fastopen.
2022-07-29 17:10:33 +02:00
tcp_highspeed.c
…
tcp_htcp.c
…
tcp_hybla.c
…
tcp_illinois.c
…
tcp_input.c
tcp: fix indefinite deferral of RTO with SACK reneging
2022-11-03 23:52:31 +09:00
tcp_ipv4.c
dccp/tcp: Reset saddr on failure after inet6?_hash_connect().
2022-12-08 11:18:30 +01:00
tcp_lp.c
…
tcp_metrics.c
tcp: Fix a data-race around sysctl_tcp_nometrics_save.
2022-08-11 12:48:39 +02:00
tcp_minisocks.c
tcp: tcp_check_req() can be called from process context
2023-03-11 16:31:59 +01:00
tcp_nv.c
…
tcp_offload.c
tcp: Don't coalesce decrypted and encrypted SKBs
2018-07-16 00:12:09 -07:00
tcp_output.c
tcp: tcp_make_synack() can be called from process context
2023-03-22 13:27:08 +01:00
tcp_rate.c
tcp: expose both send and receive intervals for rate sample
2018-07-11 23:01:56 -07:00
tcp_recovery.c
tcp: Fix data-races around sysctl_tcp_recovery.
2022-07-29 17:10:33 +02:00
tcp_scalable.c
…
tcp_timer.c
tcp: Fix a data-race around sysctl_tcp_thin_linear_timeouts.
2022-07-29 17:10:33 +02:00
tcp_ulp.c
tcp, ulp: fix leftover icsk_ulp_ops preventing sock from reattach
2018-08-16 14:58:08 -07:00
tcp_vegas.c
…
tcp_vegas.h
…
tcp_veno.c
…
tcp_westwood.c
…
tcp_yeah.c
…
tcp.c
inet: fully convert sk->sk_rx_dst to RCU rules
2022-10-26 13:19:42 +02:00
tunnel4.c
…
udp_diag.c
inet_diag: return classid for all socket types
2020-03-18 07:14:11 +01:00
udp_impl.h
…
udp_offload.c
net: Fix gro aggregation for udp encaps with zero csum
2021-03-17 16:43:42 +01:00
udp_tunnel.c
net/tunnel: wait until all sk_user_data reader finish before releasing the sock
2023-01-18 11:30:18 +01:00
udp.c
inet: fully convert sk->sk_rx_dst to RCU rules
2022-10-26 13:19:42 +02:00
udplite.c
proc: introduce proc_create_net{,_data}
2018-05-16 07:24:30 +02:00
xfrm4_input.c
xfrm: reset transport header back to network header after all input transforms ahave been applied
2018-09-04 10:26:30 +02:00
xfrm4_mode_beet.c
…
xfrm4_mode_transport.c
xfrm: reset transport header back to network header after all input transforms ahave been applied
2018-09-04 10:26:30 +02:00
xfrm4_mode_tunnel.c
…
xfrm4_output.c
xfrm: Always set XFRM_TRANSFORMED in xfrm{4,6}_output_finish
2020-04-29 16:31:23 +02:00
xfrm4_policy.c
xfrm: Don't accidentally set RTO_ONLINK in decode_session4()
2022-02-23 11:58:39 +01:00
xfrm4_protocol.c
net: xfrm: unexport __init-annotated xfrm4_protocol_init()
2022-06-14 16:59:35 +02:00
xfrm4_state.c
…
xfrm4_tunnel.c
…