j.nixdorf@avm.de fc6df94529 net: sunrpc: interpret the return value of kstrtou32 correctly ...

commit 86b53fbf08f48d353a86a06aef537e78e82ba721 upstream.

A return value of 0 means success. This is documented in lib/kstrtox.c.

This was found by trying to mount an NFS share from a link-local IPv6
address with the interface specified by its index:

  mount("[fe80::1%1]:/srv/nfs", "/mnt", "nfs", 0, "nolock,addr=fe80::1%1")

Before this commit this failed with EINVAL and also caused the following
message in dmesg:

  [...] NFS: bad IP address specified: addr=fe80::1%1

The syscall using the same address based on the interface name instead
of its index succeeds.

Credits for this patch go to my colleague Christian Speich, who traced
the origin of this bug to this line of code.

Signed-off-by: Johannes Nixdorf <j.nixdorf@avm.de>
Fixes: 00cfaa943ec3 ("replace strict_strto calls")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2021-01-23 15:38:18 +01:00

..

auth_gss

sunrpc: clean up properly in gss_mech_unregister()

2020-06-20 10:24:21 +02:00

xprtrdma

SUNRPC: xprt_load_transport() needs to support the netid "rdma6"

2020-12-29 13:44:57 +01:00

addr.c

net: sunrpc: interpret the return value of kstrtou32 correctly

2021-01-23 15:38:18 +01:00

auth_generic.c

SUNRPC: Fix a bogus get/put in generic_key_to_expire()

2018-12-01 09:44:21 +01:00

auth_null.c

sunrpc: move NO_CRKEY_TIMEOUT to the auth->au_flags

2016-07-19 16:23:24 -04:00

auth_unix.c

NFS client updates for Linux 4.9

2016-10-13 21:28:20 -07:00

auth.c

sunrpc: replace generic auth_cred hash with auth-specific function

2016-09-30 15:47:47 -04:00

backchannel_rqst.c

SUNRPC: Refactor rpc_xdr_buf_init()

2016-09-19 13:08:37 -04:00

cache.c

sunrpc: fix crash when cache_head become valid before update

2019-12-21 10:42:19 +01:00

clnt.c

SUNRPC: ECONNREFUSED should cause a rebind.

2020-11-10 10:23:50 +01:00

debugfs.c

SUNRPC: Address kbuild warning in net/sunrpc/debugfs.c

2015-06-11 14:01:06 -04:00

Kconfig

rpcrdma: Merge svcrdma and xprtrdma modules into one

2015-06-04 16:56:02 -04:00

Makefile

SUNRPC: Add a structure to track multiple transports

2016-02-05 18:48:54 -05:00

netns.h

…

rpc_pipe.c

sunrpc: fixed rollback in rpc_gssd_dummy_populate()

2020-06-30 15:38:45 -04:00

rpcb_clnt.c

SUNRPC: stop printk reading past end of string

2020-09-23 08:46:14 +02:00

sched.c

SUNRPC: Fix priority queue fairness

2019-11-25 09:53:19 +01:00

socklib.c

sunrpc: do not pull udp headers on receive

2016-04-11 15:31:33 -04:00

stats.c

…

sunrpc_syms.c

SUNRPC: cleanup ida information when removing sunrpc module

2017-02-01 08:33:09 +01:00

sunrpc.h

…

svc_xprt.c

SUNRPC: Fix a potential buffer overflow in 'svc_print_xprts()'

2020-10-01 20:40:11 +02:00

svc.c

sunrpc: use-after-free in svc_process_common()

2019-01-16 22:12:33 +01:00

svcauth_unix.c

kernel: make groups_sort calling a responsibility group_info allocators

2018-01-10 09:29:52 +01:00

svcauth.c

svcrpc: move some initialization to common code

2015-11-24 10:39:16 -07:00

svcsock.c

sunrpc: use-after-free in svc_process_common()

2019-01-16 22:12:33 +01:00

sysctl.c

Sunrpc: Supports hexadecimal number for sysctl files of sunrpc debug

2015-11-03 15:56:49 -05:00

timer.c

…

xdr.c

SUNRPC: Properly set the @subbuf parameter of xdr_buf_subsegment()

2020-06-30 15:38:45 -04:00

xprt.c

SUNRPC: xprt_load_transport() needs to support the netid "rdma6"

2020-12-29 13:44:57 +01:00

xprtmultipath.c

SUNRPC search xprt switch for sockaddr

2016-09-19 13:08:36 -04:00

xprtsock.c

SUNRPC: xprt_load_transport() needs to support the netid "rdma6"

2020-12-29 13:44:57 +01:00