iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Eric Dumazet f4191e8943 net: sched: validate stab values 
commit e323d865b36134e8c5c82c834df89109a5c60dab upstream.

iproute2 package is well behaved, but malicious user space can
provide illegal shift values and trigger UBSAN reports.

Add stab parameter to red_check_params() to validate user input.

syzbot reported:

UBSAN: shift-out-of-bounds in ./include/net/red.h:312:18
shift exponent 111 is too large for 64-bit type 'long unsigned int'
CPU: 1 PID: 14662 Comm: syz-executor.3 Not tainted 5.12.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:79 [inline]
 dump_stack+0x141/0x1d7 lib/dump_stack.c:120
 ubsan_epilogue+0xb/0x5a lib/ubsan.c:148
 __ubsan_handle_shift_out_of_bounds.cold+0xb1/0x181 lib/ubsan.c:327
 red_calc_qavg_from_idle_time include/net/red.h:312 [inline]
 red_calc_qavg include/net/red.h:353 [inline]
 choke_enqueue.cold+0x18/0x3dd net/sched/sch_choke.c:221
 __dev_xmit_skb net/core/dev.c:3837 [inline]
 __dev_queue_xmit+0x1943/0x2e00 net/core/dev.c:4150
 neigh_hh_output include/net/neighbour.h:499 [inline]
 neigh_output include/net/neighbour.h:508 [inline]
 ip6_finish_output2+0x911/0x1700 net/ipv6/ip6_output.c:117
 __ip6_finish_output net/ipv6/ip6_output.c:182 [inline]
 __ip6_finish_output+0x4c1/0xe10 net/ipv6/ip6_output.c:161
 ip6_finish_output+0x35/0x200 net/ipv6/ip6_output.c:192
 NF_HOOK_COND include/linux/netfilter.h:290 [inline]
 ip6_output+0x1e4/0x530 net/ipv6/ip6_output.c:215
 dst_output include/net/dst.h:448 [inline]
 NF_HOOK include/linux/netfilter.h:301 [inline]
 NF_HOOK include/linux/netfilter.h:295 [inline]
 ip6_xmit+0x127e/0x1eb0 net/ipv6/ip6_output.c:320
 inet6_csk_xmit+0x358/0x630 net/ipv6/inet6_connection_sock.c:135
 dccp_transmit_skb+0x973/0x12c0 net/dccp/output.c:138
 dccp_send_reset+0x21b/0x2b0 net/dccp/output.c:535
 dccp_finish_passive_close net/dccp/proto.c:123 [inline]
 dccp_finish_passive_close+0xed/0x140 net/dccp/proto.c:118
 dccp_terminate_connection net/dccp/proto.c:958 [inline]
 dccp_close+0xb3c/0xe60 net/dccp/proto.c:1028
 inet_release+0x12e/0x280 net/ipv4/af_inet.c:431
 inet6_release+0x4c/0x70 net/ipv6/af_inet6.c:478
 __sock_release+0xcd/0x280 net/socket.c:599
 sock_close+0x18/0x20 net/socket.c:1258
 __fput+0x288/0x920 fs/file_table.c:280
 task_work_run+0xdd/0x1a0 kernel/task_work.c:140
 tracehook_notify_resume include/linux/tracehook.h:189 [inline]

Fixes: 8afa10cbe281 ("net_sched: red: Avoid illegal values")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-30 14:41:42 +02:00
..
act_api.c
net: avoid potential infinite loop in tc_ctl_action()
2019-10-29 09:15:12 +01:00
act_bpf.c
net/sched: fix NULL dereference in the error path of tcf_bpf_init()
2018-04-13 19:48:33 +02:00
act_connmark.c
act_connmark: avoid crashing on malformed nlattrs with null parms
2017-03-22 12:43:34 +01:00
act_csum.c
sched: act_csum: don't mangle TCP and UDP GSO packets
2018-03-22 09:17:42 +01:00
act_gact.c
net/sched: Fix update of lastuse in act modules implementing stats_update
2018-01-17 09:38:54 +01:00
act_ife.c
ife: error out when nla attributes are empty
2019-08-11 12:22:18 +02:00
act_ipt.c
net: sched: fix NULL pointer dereference when action calls some targets
2017-08-30 10:21:42 +02:00
act_meta_mark.c
…
act_meta_skbprio.c
Support to encoding decoding skb prio on IFE action
2016-03-01 17:15:23 -05:00
act_meta_skbtcindex.c
net sched ife action: Introduce skb tcindex metadata encap decap
2016-09-19 21:55:28 -04:00
act_mirred.c
act_mirred: Fix mirred_init_module error handling
2020-01-29 10:24:33 +01:00
act_nat.c
net_sched: move tc_action into tcf_common
2016-07-25 21:49:19 -07:00
act_pedit.c
net/sched: act_pedit: fix WARN() in the traffic path
2019-11-28 18:28:04 +01:00
act_police.c
net sched: stylistic cleanups
2016-09-19 22:04:14 -04:00
act_simple.c
net/sched: act_simple: fix parsing of TCA_DEF_DATA
2018-06-26 08:08:06 +08:00
act_skbedit.c
net_sched: move tc_action into tcf_common
2016-07-25 21:49:19 -07:00
act_skbmod.c
net/sched: fix NULL dereference on the error path of tcf_skbmod_init()
2018-04-13 19:48:35 +02:00
act_tunnel_key.c
net/sched: act_tunnel_key: fix NULL dereference when 'goto chain' is used
2018-08-24 13:12:37 +02:00
act_vlan.c
net/sched: act_vlan: Push skb->data to mac_header prior calling skb_vlan_*() functions
2016-10-03 21:40:50 -04:00
cls_api.c
net, sched: fix soft lockup in tc_classify
2017-01-15 13:42:53 +01:00
cls_basic.c
net, sched: respect rcu grace period on cls destruction
2016-11-28 10:47:35 -05:00
cls_bpf.c
net, sched: respect rcu grace period on cls destruction
2016-11-28 10:47:35 -05:00
cls_cgroup.c
net, sched: respect rcu grace period on cls destruction
2016-11-28 10:47:35 -05:00
cls_flow.c
net, sched: respect rcu grace period on cls destruction
2016-11-28 10:47:35 -05:00
cls_flower.c
net: sched: correct flower port blocking
2020-03-11 07:53:05 +01:00
cls_fw.c
net sched: stylistic cleanups
2016-09-19 22:04:14 -04:00
cls_matchall.c
net/sched: matchall: add missing validation of TCA_MATCHALL_FLAGS
2020-02-28 15:42:44 +01:00
cls_route.c
net_sched: cls_route: remove the right filter from hashtable
2020-04-02 17:20:29 +02:00
cls_rsvp6.c
…
cls_rsvp.c
…
cls_rsvp.h
cls_rsvp: fix rsvp_policy
2020-02-14 16:30:58 -05:00
cls_tcindex.c
net_sched: avoid shift-out-of-bounds in tcindex_set_parms()
2021-01-30 13:27:16 +01:00
cls_u32.c
net: sched: Fix memory exposure from short TCA_U32_SEL
2018-09-15 09:42:55 +02:00
em_canid.c
…
em_cmp.c
…
em_ipset.c
…
em_meta.c
qdisc: constify meta_type_ops structures
2016-04-14 00:35:30 -04:00
em_nbyte.c
…
em_text.c
…
em_u32.c
…
ematch.c
net_sched: ematch: reject invalid TCF_EM_SIMPLE
2020-02-05 13:05:42 +00:00
Kconfig
net sched ife action: Introduce skb tcindex metadata encap decap
2016-09-19 21:55:28 -04:00
Makefile
net sched ife action: Introduce skb tcindex metadata encap decap
2016-09-19 21:55:28 -04:00
sch_api.c
net: sched: avoid duplicates in classes dump
2021-03-17 16:10:14 +01:00
sch_atm.c
net_sched: drop packets after root qdisc lock is released
2016-06-25 12:19:35 -04:00
sch_blackhole.c
net_sched: blackhole: tell upper qdisc about dropped packets
2018-07-22 14:27:36 +02:00
sch_cbq.c
sch_cbq: validate TCA_CBQ_WRROPT to avoid crash
2019-10-07 18:53:24 +02:00
sch_choke.c
net: sched: validate stab values
2021-03-30 14:41:42 +02:00
sch_codel.c
net: sched: Fix a possible null-pointer dereference in dequeue_func()
2019-08-11 12:22:17 +02:00
sch_drr.c
net_sched: drop packets after root qdisc lock is released
2016-06-25 12:19:35 -04:00
sch_dsmark.c
sch_dsmark: fix potential NULL deref in dsmark_init()
2019-10-07 18:53:23 +02:00
sch_fifo.c
sched: don't use skb queue helpers
2016-09-19 01:47:18 -04:00
sch_fq_codel.c
fq_codel: fix TCA_FQ_CODEL_DROP_BATCH_SIZE sanity checks
2020-05-20 08:15:24 +02:00
sch_fq.c
net: fq: add missing attribute validation for orphan mask
2020-03-20 09:07:40 +01:00
sch_generic.c
net: sched: export __netdev_watchdog_up()
2020-06-30 15:38:37 -04:00
sch_gred.c
net: sched: validate stab values
2021-03-30 14:41:42 +02:00
sch_hfsc.c
net/sched/sch_hfsc.c: remove unused cl_myfadj
2016-08-08 16:06:47 -07:00
sch_hhf.c
net/flow_dissector: switch to siphash
2019-11-10 11:23:31 +01:00
sch_htb.c
sch_htb: fix crash on init failure
2018-09-15 09:43:02 +02:00
sch_ingress.c
net: sched: fix tc_should_offload for specific clsact classes
2016-06-07 16:59:53 -07:00
sch_mq.c
net: sched: fix tc -s class show no bstats on class with nolock subqueues
2019-12-05 15:35:30 +01:00
sch_mqprio.c
net: sched: fix tc -s class show no bstats on class with nolock subqueues
2019-12-05 15:35:30 +01:00
sch_multiq.c
net: sched: fix tc -s class show no bstats on class with nolock subqueues
2019-12-05 15:35:30 +01:00
sch_netem.c
net: netem: correct the parent's backlog when corrupted packet was dropped
2020-01-29 10:24:34 +01:00
sch_pie.c
sched: replace __skb_dequeue with __qdisc_dequeue_head
2016-09-19 01:47:18 -04:00
sch_plug.c
net_sched: drop packets after root qdisc lock is released
2016-06-25 12:19:35 -04:00
sch_prio.c
net: sch_prio: When ungrafting, replace with FIFO
2020-01-12 11:24:27 +01:00
sch_qfq.c
sch_qfq: keep backlog updated with qlen
2016-09-23 06:52:31 -04:00
sch_red.c
net: sched: validate stab values
2021-03-30 14:41:42 +02:00
sch_sfb.c
net/flow_dissector: switch to siphash
2019-11-10 11:23:31 +01:00
sch_sfq.c
net: sched: validate stab values
2021-03-30 14:41:42 +02:00
sch_tbf.c
net: create skb_gso_validate_mac_len()
2019-02-20 10:18:28 +01:00
sch_teql.c
net_sched: drop packets after root qdisc lock is released
2016-06-25 12:19:35 -04:00