Johan Hovold f6b3e679c7 i2c: robotfuzz-osif: fix control-request directions
commit 4ca070ef0dd885616ef294d269a9bf8e3b258e1a upstream.

The direction of the pipe argument must match the request-type direction
bit or control requests may fail depending on the host-controller-driver
implementation.

Control transfers without a data stage are treated as OUT requests by
the USB stack and should be using usb_sndctrlpipe(). Failing to do so
will now trigger a warning.

Fix the OSIFI2C_SET_BIT_RATE and OSIFI2C_STOP requests which erroneously
used the osif_usb_read() helper and set the IN direction bit.

Reported-by: syzbot+9d7dadd15b8819d73f41@syzkaller.appspotmail.com
Fixes: 83e53a8f120f ("i2c: Add bus driver for for OSIF USB i2c device.")
Cc: stable@vger.kernel.org      # 3.14
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-06-30 08:49:22 -04:00
..
2019-06-22 08:17:18 +02:00
2014-11-07 18:35:33 +01:00
2014-11-07 18:35:33 +01:00
2014-11-07 18:35:33 +01:00
2021-05-22 10:40:27 +02:00
2020-10-14 09:48:13 +02:00
2021-05-22 10:40:27 +02:00
2014-11-07 18:35:33 +01:00
2014-11-07 18:35:33 +01:00
2021-05-22 10:40:27 +02:00
2014-11-07 18:35:33 +01:00
2015-08-10 08:37:28 +02:00
2014-11-07 18:35:33 +01:00
2019-10-05 12:30:36 +02:00
2021-05-22 10:40:27 +02:00
2014-11-07 18:35:33 +01:00
2014-12-14 16:10:09 -08:00
2014-11-07 18:35:33 +01:00
2014-11-07 18:35:33 +01:00
2014-11-07 18:35:33 +01:00
2014-11-07 18:35:33 +01:00
2014-11-07 18:35:33 +01:00
2016-10-25 11:48:59 +02:00
2014-12-14 16:10:09 -08:00