iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/include/crypto
History
zhenwei pi a67d0cfe1a crypto: public_key: fix overflow during implicit conversion 
commit f985911b7bc75d5c98ed24d8aaa8b94c590f7c6a upstream.

Hit kernel warning like this, it can be reproduced by verifying 256
bytes datafile by keyctl command, run script:
RAWDATA=rawdata
SIGDATA=sigdata

modprobe pkcs8_key_parser

rm -rf *.der *.pem *.pfx
rm -rf $RAWDATA
dd if=/dev/random of=$RAWDATA bs=256 count=1

openssl req -nodes -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem \
  -subj "/C=CN/ST=GD/L=SZ/O=vihoo/OU=dev/CN=xx.com/emailAddress=yy@xx.com"

KEY_ID=`openssl pkcs8 -in key.pem -topk8 -nocrypt -outform DER | keyctl \
  padd asymmetric 123 @s`

keyctl pkey_sign $KEY_ID 0 $RAWDATA enc=pkcs1 hash=sha1 > $SIGDATA
keyctl pkey_verify $KEY_ID 0 $RAWDATA $SIGDATA enc=pkcs1 hash=sha1

Then the kernel reports:
 WARNING: CPU: 5 PID: 344556 at crypto/rsa-pkcs1pad.c:540
   pkcs1pad_verify+0x160/0x190
 ...
 Call Trace:
  public_key_verify_signature+0x282/0x380
  ? software_key_query+0x12d/0x180
  ? keyctl_pkey_params_get+0xd6/0x130
  asymmetric_key_verify_signature+0x66/0x80
  keyctl_pkey_verify+0xa5/0x100
  do_syscall_64+0x35/0xb0
  entry_SYSCALL_64_after_hwframe+0x44/0xae

The reason of this issue, in function 'asymmetric_key_verify_signature':
'.digest_size(u8) = params->in_len(u32)' leads overflow of an u8 value,
so use u32 instead of u8 for digest_size field. And reorder struct
public_key_signature, it saves 8 bytes on a 64-bit machine.

Cc: stable@vger.kernel.org
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-09-22 11:43:03 +02:00
..
internal
crypto: shash - avoid comparing pointers to exported functions under CFI
2021-07-20 16:20:59 +02:00
ablk_helper.h
crypto: create generic version of ablk_helper
2013-09-24 06:02:24 +10:00
aead.h
crypto: aead - Add chunk size
2016-07-18 17:35:38 +08:00
aes.h
…
akcipher.h
crypto: doc - add akcipher API
2016-02-17 04:07:53 +08:00
algapi.h
crypto: engine - move crypto engine to its own header
2016-09-07 21:08:26 +08:00
authenc.h
crypto: authenc - Export key parsing helper function
2013-10-16 20:56:25 +08:00
b128ops.h
…
blowfish.h
crypto: blowfish - split generic and common c code
2011-09-22 21:25:25 +10:00
cast5.h
crypto: cast5/cast6 - move lookup tables to shared module
2012-12-06 17:16:26 +08:00
cast6.h
crypto: cast5/cast6 - move lookup tables to shared module
2012-12-06 17:16:26 +08:00
cast_common.h
crypto: cast5/cast6 - move lookup tables to shared module
2012-12-06 17:16:26 +08:00
chacha20.h
random: replace non-blocking pool with a Chacha20-based CRNG
2016-07-03 00:57:23 -04:00
cryptd.h
crypto: cryptd - Add helpers to check whether a tfm is queued
2016-06-23 18:29:52 +08:00
crypto_wq.h
…
ctr.h
…
des.h
crypto: des_3des - add x86-64 assembly implementation
2014-06-20 21:27:58 +08:00
dh.h
crypto: dh - Add DH software implementation
2016-06-23 18:29:56 +08:00
drbg.h
crypto: drbg - prevent invalid SG mappings
2016-11-30 19:46:44 +08:00
ecdh.h
crypto: ecdh - Add ECDH software support
2016-06-23 18:29:57 +08:00
engine.h
crypto: engine - permit to enqueue ashash_request
2016-09-07 21:08:27 +08:00
gf128mul.h
…
ghash.h
crypto: ghash-generic - move common definitions to a new header file
2016-10-02 22:26:40 +08:00
hash_info.h
keys, trusted: select hash algorithm for TPM2 chips
2015-12-20 15:27:12 +02:00
hash.h
crypto: hash - prevent using keyed hashes without setting key
2018-02-25 11:05:44 +01:00
if_alg.h
crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock()
2020-07-09 09:35:55 +02:00
kpp.h
crypto: ecdh - Add ECDH software support
2016-06-23 18:29:57 +08:00
lrw.h
crypto: lrw - add interface for parallelized cipher implementions
2011-11-09 11:50:31 +08:00
mcryptd.h
crypto: mcryptd - protect the per-CPU queue with a lock
2017-12-29 17:42:58 +01:00
md5.h
crypto: hash - add zero length message hash for shax and md5
2015-12-22 20:43:35 +08:00
null.h
crypto: null - Remove default null blkcipher
2016-07-18 17:35:44 +08:00
padlock.h
…
pcrypt.h
…
pkcs7.h
PKCS#7: Make trust determination dependent on contents of trust keyring
2016-04-06 16:14:24 +01:00
poly1305.h
crypto: poly1305 - remove ->setkey() method
2018-02-17 13:21:15 +01:00
public_key.h
crypto: public_key: fix overflow during implicit conversion
2021-09-22 11:43:03 +02:00
rng.h
crypto: doc - Fix typo in crypto-API.xml
2015-06-04 15:05:08 +08:00
scatterwalk.h
crypto: scatterwalk - Inline start/map/done
2016-07-18 17:35:50 +08:00
serpent.h
crypto: serpent-sse2 - add lrw support
2011-11-21 16:13:24 +08:00
sha1_base.h
crypto: sha1 - implement base layer for SHA-1
2015-04-10 21:39:39 +08:00
sha3.h
crypto: sha3 - Add SHA-3 hash algorithm
2016-06-20 19:25:01 +08:00
sha256_base.h
crypto: sha256 - implement base layer for SHA-256
2015-04-10 21:39:39 +08:00
sha512_base.h
crypto: sha512 - implement base layer for SHA-512
2015-04-10 21:39:39 +08:00
sha.h
crypto: hash - add zero length message hash for shax and md5
2015-12-22 20:43:35 +08:00
skcipher.h
crypto: skcipher - Add comment for skcipher_alg->base
2016-07-19 15:42:42 +08:00
twofish.h
crypto: twofish-x86_64-3way - add lrw support
2011-11-09 11:53:32 +08:00
xts.h
crypto: xts - consolidate sanity check for keys
2016-02-17 04:07:51 +08:00