Yang Yingliang c68a92435a hwmon: Fix possible memleak in __hwmon_device_register() ...

[ Upstream commit ada61aa0b1184a8fda1a89a340c7d6cc4e59aee5 ]

I got memory leak as follows when doing fault injection test:

unreferenced object 0xffff888102740438 (size 8):
  comm "27", pid 859, jiffies 4295031351 (age 143.992s)
  hex dump (first 8 bytes):
    68 77 6d 6f 6e 30 00 00                          hwmon0..
  backtrace:
    [<00000000544b5996>] __kmalloc_track_caller+0x1a6/0x300
    [<00000000df0d62b9>] kvasprintf+0xad/0x140
    [<00000000d3d2a3da>] kvasprintf_const+0x62/0x190
    [<000000005f8f0f29>] kobject_set_name_vargs+0x56/0x140
    [<00000000b739e4b9>] dev_set_name+0xb0/0xe0
    [<0000000095b69c25>] __hwmon_device_register+0xf19/0x1e50 [hwmon]
    [<00000000a7e65b52>] hwmon_device_register_with_info+0xcb/0x110 [hwmon]
    [<000000006f181e86>] devm_hwmon_device_register_with_info+0x85/0x100 [hwmon]
    [<0000000081bdc567>] tmp421_probe+0x2d2/0x465 [tmp421]
    [<00000000502cc3f8>] i2c_device_probe+0x4e1/0xbb0
    [<00000000f90bda3b>] really_probe+0x285/0xc30
    [<000000007eac7b77>] __driver_probe_device+0x35f/0x4f0
    [<000000004953d43d>] driver_probe_device+0x4f/0x140
    [<000000002ada2d41>] __device_attach_driver+0x24c/0x330
    [<00000000b3977977>] bus_for_each_drv+0x15d/0x1e0
    [<000000005bf2a8e3>] __device_attach+0x267/0x410

When device_register() returns an error, the name allocated in
dev_set_name() will be leaked, the put_device() should be used
instead of calling hwmon_dev_release() to give up the device
reference, then the name will be freed in kobject_cleanup().

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: bab2243ce189 ("hwmon: Introduce hwmon_device_register_with_groups")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20211012112758.2681084-1-yangyingliang@huawei.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2021-11-26 11:48:34 +01:00

..

pmbus

hwmon: (pmbus/lm25066) Add offset coefficients

2021-11-26 11:48:21 +01:00

ab8500.c

hwmon: (ab8500) Call kernel_power_off instead of pm_power_off

2014-10-03 08:19:02 -07:00

abituguru3.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

abituguru.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

abx500.c

hwmon: (abx500) drop the use of IRQF_NO_SUSPEND

2015-10-14 07:57:14 -07:00

abx500.h

…

acpi_power_meter.c

hwmon: (acpi_power_meter) Fix potential memory leak in acpi_power_meter_add()

2020-07-09 09:35:56 +02:00

ad7314.c

hwmon: (ad7314) Convert to devm_hwmon_device_register_with_groups

2016-06-27 18:58:03 -07:00

ad7414.c

hwmon: (ad7414) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:35 -07:00

ad7418.c

hwmon: (ad7418) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:35 -07:00

adc128d818.c

hwmon: (adc128d818) Do proper sign extension

2015-01-25 21:24:00 -08:00

adcxx.c

spi: Drop owner assignment from spi_drivers

2015-10-28 10:30:17 +09:00

adm1021.c

hwmon: (adm1021) Avoid forward declaration

2014-08-04 07:01:36 -07:00

adm1025.c

hwmon: (adm1025) Fix vrm write operation

2014-08-05 19:44:36 -07:00

adm1026.c

hwmon: (adm1026) Fix vrm write operation

2014-08-05 19:44:36 -07:00

adm1029.c

hwmon: (adm1029) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:35 -07:00

adm1031.c

hwmon: (adm1031) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:37 -07:00

adm9240.c

hwmon: (adm9240) handle temperature readings below 0

2016-10-17 10:16:20 -07:00

ads1015.c

hwmon: (ads1015) Handle negative conversion values correctly

2016-02-18 19:14:04 -08:00

ads7828.c

hwmon: (ads7828) Enable internal reference

2016-04-19 06:30:28 -07:00

ads7871.c

hwmon: (ads7871) Convert to devm_hwmon_device_register_with_groups

2016-06-27 18:58:03 -07:00

adt7x10.c

…

adt7x10.h

…

adt7310.c

spi: Drop owner assignment from spi_drivers

2015-10-28 10:30:17 +09:00

adt7410.c

…

adt7411.c

hwmon: (adt7411) add external thermal diode support

2016-09-08 21:34:14 -07:00

adt7462.c

hwmon: (adt7462) Fix an error return in ADT7462_REG_VOLT()

2020-03-11 07:53:13 +01:00

adt7470.c

hwmon: (adt7470) No need for additional synchronization on kthread_stop()

2016-09-18 10:10:26 -07:00

adt7475.c

hwmon: (adt7475) Make volt2reg return same reg as reg2volt input

2020-01-29 10:24:37 +01:00

amc6821.c

hwmon: (amc6821) sign extension temperature

2017-01-12 11:39:25 +01:00

applesmc.c

hwmon: (applesmc) check status earlier.

2020-09-12 11:47:32 +02:00

asb100.c

hwmon: (asb100) Fix vrm write operation

2014-08-05 19:44:36 -07:00

asc7621.c

hwmon: (asc7621) Make map tables const

2014-08-04 07:01:38 -07:00

asus_atk0110.c

hwmon: (asus_atk0110) fix uninitialized data access

2017-12-25 14:23:40 +01:00

atxp1.c

hwmon: (atxp1) Drop auto-detection

2015-05-31 22:58:36 -07:00

coretemp.c

x86/cpu: Rename cpu_data.x86_mask to cpu_data.x86_stepping

2018-02-22 15:43:55 +01:00

da9052-hwmon.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

da9055-hwmon.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

dell-smm-hwmon.c

hwmon: Use smp_call_on_cpu() for dell-smm i8k

2016-09-05 13:52:41 +02:00

dme1737.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

ds620.c

hwmon: (ds620) Fix overflows seen when writing temperature limits

2017-01-12 11:39:25 +01:00

ds1621.c

hwmon: (ds1621) Update zbits after conversion rate change

2014-08-28 11:18:47 -07:00

emc6w201.c

hwmon: (emc6w201): trivial fix of spelling mistake "Unknwown" -> "Unknown"

2016-06-27 18:58:03 -07:00

emc1403.c

hwmon: Make regmap configs const

2014-08-04 07:01:35 -07:00

emc2103.c

hwmon: (emc2103) fix unable to change fan pwm1_enable attribute

2020-07-22 09:10:53 +02:00

f71805f.c

hwmon: (f71805f) Use request_muxed_region for Super-IO accesses

2019-05-31 06:48:24 -07:00

f71882fg.c

hwmon: (f71882fg) Add support for f81768d

2015-08-09 13:44:26 -07:00

f75375s.c

hwmon: (f75375s) Don't crash the kernel unnecessarily

2013-10-13 16:16:27 -07:00

fam15h_power.c

hwmon: (fam15h_power) Disable preemption when reading registers

2016-06-07 20:11:10 -07:00

fschmd.c

…

ftsteutates.c

hwmon: (ftsteutates) Add i2c detect functionality

2016-09-08 21:34:16 -07:00

g760a.c

hwmon: (g760a) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:37 -07:00

g762.c

hwmon: (g762) Fix overflows and crash seen when writing limit attributes

2017-01-12 11:39:26 +01:00

gl518sm.c

hwmon: (gl518sm) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:36 -07:00

gl520sm.c

hwmon: (gl520sm) Fix overflows and crash seen when writing into limit attributes

2017-10-08 10:26:04 +02:00

gpio-fan.c

hwmon: (gpio-fan) Remove un-necessary speed_index lookup for thermal hook

2016-02-19 17:14:25 -08:00

hih6130.c

hwmon: (hih6130) Fix missing hih6130->write_length setting

2014-08-05 19:40:27 -07:00

hwmon-vid.c

x86/cpu: Rename cpu_data.x86_mask to cpu_data.x86_stepping

2018-02-22 15:43:55 +01:00

hwmon.c

hwmon: Fix possible memleak in __hwmon_device_register()

2021-11-26 11:48:34 +01:00

i5k_amb.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

i5500_temp.c

hwmon: (i5500_temp) Convert to use ATTRIBUTE_GROUPS macro

2015-01-24 14:16:22 +01:00

ibmaem.c

hwmon: (ibmaem) constify aem_rw_sensor_template and aem_ro_sensor_template structures

2016-01-04 08:56:22 -08:00

ibmpex.c

hwmon: (ibmpex) Allow format string checking

2015-03-09 09:59:35 -07:00

ibmpowernv.c

hwmon: (ibmpowernv) Remove bogus __init annotations

2018-11-27 16:09:39 +01:00

iio_hwmon.c

hwmon: (iio_hwmon) defer probe when no channel is found

2016-09-08 21:34:17 -07:00

ina2xx.c

hwmon: (ina2xx) Fix current value calculation

2018-12-17 09:38:32 +01:00

ina209.c

hwmon: (ina209) Convert to use devm_hwmon_device_register_with_groups

2013-10-18 09:11:57 -07:00

ina3221.c

hwmon: (ina3221) Fix INA3221_CONFIG_MODE macros

2019-11-25 09:53:51 +01:00

it87.c

hwmon: (it87) Fix pwm4 detection for IT8620 and IT8628

2017-05-14 14:00:13 +02:00

jc42.c

hwmon: (jc42) Fix name to have no illegal characters

2020-05-02 17:23:18 +02:00

jz4740-hwmon.c

hwmon: (jz4740) Convert to devm_hwmon_device_register_with_groups

2016-06-27 18:58:03 -07:00

k8temp.c

x86/cpu: Rename cpu_data.x86_mask to cpu_data.x86_stepping

2018-02-22 15:43:55 +01:00

k10temp.c

x86/cpu: Rename cpu_data.x86_mask to cpu_data.x86_stepping

2018-02-22 15:43:55 +01:00

Kconfig

hwmon: (lm95245) Select REGMAP_I2C

2016-09-13 07:27:34 -07:00

lineage-pem.c

hwmon: (lineage-pem) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:37 -07:00

lm63.c

hwmon: (lm63) Fix smatch warnings

2014-08-04 07:01:36 -07:00

lm70.c

spi: Drop owner assignment from spi_drivers

2015-10-28 10:30:17 +09:00

lm73.c

hwmon: (lm73) Convert to use devm_hwmon_device_register_with_groups

2013-10-13 16:16:28 -07:00

lm75.c

hwmon: (lm75) Fix write operations for negative temperatures

2020-01-29 10:24:30 +01:00

lm75.h

…

lm77.c

hwmon: (lm77) Prevent overflow problem when writing large limits

2014-07-31 09:41:46 -07:00

lm78.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

lm80.c

Revert "hwmon: (lm80) fix a missing check of bus read in lm80 probe"

2021-05-26 11:29:07 +02:00

lm83.c

hwmon: (lm83) Convert to use devm_hwmon_device_register_with_groups

2014-05-21 16:02:26 -07:00

lm85.c

hwmon: (lm85) use find_closest() in x_TO_REG() functions

2015-04-17 09:03:55 -04:00

lm87.c

hwmon: (lm87) Fix vrm write operation

2014-08-05 19:44:42 -07:00

lm90.c

hwmon: (lm90) Fix max6658 sporadic wrong temperature reading

2021-03-17 16:10:18 +01:00

lm92.c

hwmon: (lm92) Prevent overflow problem when writing large limits

2014-08-05 17:48:52 -07:00

lm93.c

hwmon: (lm93) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:36 -07:00

lm95234.c

hwmon: (lm95234) Add support for LM95233

2014-12-02 06:11:53 -08:00

lm95241.c

hwmon: (lm95241) Update module description to include LM95231

2016-09-13 07:28:01 -07:00

lm95245.c

hwmon: (lm95245) Use new hwmon registration API

2016-09-08 21:34:18 -07:00

ltc2945.c

hwmon: Make regmap configs const

2014-08-04 07:01:35 -07:00

ltc2990.c

hwmon: Add LTC2990 sensor driver

2016-03-05 06:25:34 -08:00

ltc4151.c

hwmon: (ltc4151) Make shunt-resistor configurable

2016-09-08 21:34:16 -07:00

ltc4215.c

hwmon: (ltc4215) Convert to devm_hwmon_device_register_with_groups

2014-03-03 08:01:05 -08:00

ltc4222.c

hwmon: Make regmap configs const

2014-08-04 07:01:35 -07:00

ltc4245.c

hwmon: (ltc4245) Convert to use new hwmon registration API

2016-09-08 21:34:18 -07:00

ltc4260.c

hwmon: Make regmap configs const

2014-08-04 07:01:35 -07:00

ltc4261.c

hwmon: (ltc4261) fix coccinelle warnings

2013-10-18 09:12:00 -07:00

Makefile

hwmon: Add xgene hwmon driver

2016-09-08 21:34:16 -07:00

max197.c

hwmon: (max197) Constify platform_device_id

2015-05-31 22:58:36 -07:00

max1111.c

hwmon: (max1111) Return -ENODEV from max1111_read_channel if not instantiated

2016-03-27 10:37:48 -07:00

max1619.c

hwmon: (max1619) Convert to use devm_hwmon_device_register_with_groups

2014-05-21 16:02:25 -07:00

max1668.c

hwmon: (max1668) Make max1668_addr_list array const

2014-08-04 07:01:39 -07:00

max6639.c

hwmon: (max6639) Make normal_i2c array const

2014-08-04 07:01:39 -07:00

max6642.c

Update Jean Delvare's e-mail address

2014-01-29 20:40:08 +01:00

max6650.c

hwmon: (max6650) Allow fan shutdown and initial rpm target

2016-09-08 21:34:17 -07:00

max6697.c

hwmon: (max6697) Make sure the OVERT mask is set correctly

2020-07-09 09:35:56 +02:00

max16065.c

hwmon: (max16065) Use PTR_ERR_OR_ZERO

2014-08-04 07:01:38 -07:00

max31722.c

hwmon: (max31722) Remove non-standard ACPI device IDs

2021-07-20 16:21:01 +02:00

max31790.c

hwmon: (max31790) Fix fan speed reporting for fan7..12

2021-07-20 16:21:01 +02:00

mc13783-adc.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

mcp3021.c

hwmon: (mcp3021) Fix broken output scaling

2015-07-01 13:56:27 -07:00

menf21bmc_hwmon.c

Merge branch 'platform/remove_owner' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux into driver-core-next

2014-11-03 19:53:56 -08:00

nct6683.c

hwmon: (nct6683) Add basic support for NCT6683 on Mitac boards

2016-01-09 07:31:58 -08:00

nct6775.c

hwmon: (nct6775) Fix register address and added missed tolerance for nct6106

2019-08-25 10:51:24 +02:00

nct7802.c

hwmon: (nct7802) Fix voltage limits to wrong registers

2020-01-29 10:24:39 +01:00

nct7904.c

hwmon: (nct7904) Convert to use new hwmon registration API

2016-09-08 21:34:18 -07:00

nsa320-hwmon.c

hwmon: Create an NSA320 hardware monitoring driver

2016-03-08 18:40:49 -08:00

ntc_thermistor.c

hwmon: (ntc_thermistor) Use devm_hwmon_device_register_with_groups

2016-09-08 21:34:15 -07:00

pc87360.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

pc87427.c

hwmon: (pc87427) Use request_muxed_region for Super-IO accesses

2019-05-31 06:48:24 -07:00

pcf8591.c

Update Jean Delvare's e-mail address

2014-01-29 20:40:08 +01:00

powr1220.c

hwmon: Add support for Lattice's POWR1220 power manager IC

2014-08-04 07:01:33 -07:00

pwm-fan.c

hwmon: (pwm-fan) Silence error on probe deferral

2019-11-25 09:53:51 +01:00

s3c-hwmon.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

sch56xx-common.c

hwmon: (sch56xx) Drop watchdog driver data reference count callbacks

2015-12-29 20:36:04 +01:00

sch56xx-common.h

…

sch5627.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

sch5636.c

hwmon: (sch5636) trivial fix of spelling mistake on revision

2016-04-25 07:26:29 -07:00

scpi-hwmon.c

hwmon: (scpi) Fix module autoload

2017-01-12 11:39:25 +01:00

sht3x.c

hwmon: (sht3x) set initial jiffies to last_update

2016-07-31 14:56:36 -07:00

sht15.c

hwmon:change sht15_reverse()

2015-08-10 23:00:10 -07:00

sht21.c

hwmon: (sht21) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:38 -07:00

shtc1.c

hwmon: (shtc1) fix shtc1 and shtw1 id mask

2020-01-29 10:24:31 +01:00

sis5595.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

smm665.c

hwmon: (smm665) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:37 -07:00

smsc47b397.c

hwmon: (smsc47b397) Use request_muxed_region for Super-IO accesses

2019-05-31 06:48:24 -07:00

smsc47m1.c

hwmon: (smsc47m1) Use request_muxed_region for Super-IO accesses

2019-05-31 06:48:24 -07:00

smsc47m192.c

hwmon: (smsc47m192) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:39 -07:00

tc74.c

hwmon: add driver for Microchip TC74

2015-06-21 22:54:53 -07:00

thmc50.c

hwmon: (thmc50) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:39 -07:00

tmp102.c

hwmon: (tmp102) Convert to use new hwmon registration API

2016-09-08 21:34:17 -07:00

tmp103.c

hwmon: (tmp103) Fix resource leak bug in tmp103 temperature sensor driver

2014-09-22 11:11:48 -07:00

tmp401.c

hwmon: (tmp401) Add support for TI TMP461

2016-06-27 18:58:03 -07:00

tmp421.c

hwmon: (tmp421) fix rounding for negative values

2021-10-06 10:23:41 +02:00

twl4030-madc-hwmon.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

ultra45_env.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

vexpress-hwmon.c

hwmon: (vexpress) rename vexpress hwmon implementation

2016-03-05 06:25:33 -08:00

via686a.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

via-cputemp.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

vt1211.c

hwmon: (vt1211) Use request_muxed_region for Super-IO accesses

2019-05-31 06:48:23 -07:00

vt8231.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

w83l785ts.c

hwmon: Avoid initializing the same field twice

2014-04-04 18:01:34 +02:00

w83l786ng.c

hwmon: (w83l786ng) Convert to devm_hwmon_device_register_with_groups

2014-08-04 07:01:34 -07:00

w83627ehf.c

hwmon: (w83627ehf) Use swap() in w82627ehf_swap_tempreg()

2015-07-03 14:39:06 +02:00

w83627hf.c

hwmon: (w83627hf) Use request_muxed_region for Super-IO accesses

2020-01-29 10:24:21 +01:00

w83781d.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

w83791d.c

hwmon: (w83791d) Fix vrm write operation

2014-08-05 19:44:42 -07:00

w83792d.c

hwmon: (w83792d) Additional PWM outputs support

2015-07-03 14:39:05 +02:00

w83793.c

hwmon: (w83793) Fix vrm write operation

2014-08-05 19:44:42 -07:00

w83795.c

hwmon: (w83795) temp4_type has writable permission

2018-12-17 09:38:32 +01:00

wm831x-hwmon.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

wm8350-hwmon.c

hwmon: drop owner assignment from platform_drivers

2014-10-20 16:20:36 +02:00

xgene-hwmon.c

hwmon: (xgene) access mailbox as RAM

2016-09-09 14:54:53 -07:00