iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv4
History
Eric Dumazet 80c5293226 ipmr,ip6mr: acquire RTNL before calling ip[6]mr_free_table() on failure path 
[ Upstream commit 5611a00697c8ecc5aad04392bea629e9d6a20463 ]

ip[6]mr_free_table() can only be called under RTNL lock.

RTNL: assertion failed at net/core/dev.c (10367)
WARNING: CPU: 1 PID: 5890 at net/core/dev.c:10367 unregister_netdevice_many+0x1246/0x1850 net/core/dev.c:10367
Modules linked in:
CPU: 1 PID: 5890 Comm: syz-executor.2 Not tainted 5.16.0-syzkaller-11627-g422ee58dc0ef #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:unregister_netdevice_many+0x1246/0x1850 net/core/dev.c:10367
Code: 0f 85 9b ee ff ff e8 69 07 4b fa ba 7f 28 00 00 48 c7 c6 00 90 ae 8a 48 c7 c7 40 90 ae 8a c6 05 6d b1 51 06 01 e8 8c 90 d8 01 <0f> 0b e9 70 ee ff ff e8 3e 07 4b fa 4c 89 e7 e8 86 2a 59 fa e9 ee
RSP: 0018:ffffc900046ff6e0 EFLAGS: 00010286
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff888050f51d00 RSI: ffffffff815fa008 RDI: fffff520008dfece
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: ffffffff815f3d6e R11: 0000000000000000 R12: 00000000fffffff4
R13: dffffc0000000000 R14: ffffc900046ff750 R15: ffff88807b7dc000
FS:  00007f4ab736e700(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fee0b4f8990 CR3: 000000001e7d2000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 mroute_clean_tables+0x244/0xb40 net/ipv6/ip6mr.c:1509
 ip6mr_free_table net/ipv6/ip6mr.c:389 [inline]
 ip6mr_rules_init net/ipv6/ip6mr.c:246 [inline]
 ip6mr_net_init net/ipv6/ip6mr.c:1306 [inline]
 ip6mr_net_init+0x3f0/0x4e0 net/ipv6/ip6mr.c:1298
 ops_init+0xaf/0x470 net/core/net_namespace.c:140
 setup_net+0x54f/0xbb0 net/core/net_namespace.c:331
 copy_net_ns+0x318/0x760 net/core/net_namespace.c:475
 create_new_namespaces+0x3f6/0xb20 kernel/nsproxy.c:110
 copy_namespaces+0x391/0x450 kernel/nsproxy.c:178
 copy_process+0x2e0c/0x7300 kernel/fork.c:2167
 kernel_clone+0xe7/0xab0 kernel/fork.c:2555
 __do_sys_clone+0xc8/0x110 kernel/fork.c:2672
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f4ab89f9059
Code: Unable to access opcode bytes at RIP 0x7f4ab89f902f.
RSP: 002b:00007f4ab736e118 EFLAGS: 00000206 ORIG_RAX: 0000000000000038
RAX: ffffffffffffffda RBX: 00007f4ab8b0bf60 RCX: 00007f4ab89f9059
RDX: 0000000020000280 RSI: 0000000020000270 RDI: 0000000040200000
RBP: 00007f4ab8a5308d R08: 0000000020000300 R09: 0000000020000300
R10: 00000000200002c0 R11: 0000000000000206 R12: 0000000000000000
R13: 00007ffc3977cc1f R14: 00007f4ab736e300 R15: 0000000000022000
 </TASK>

Fixes: f243e5a7859a ("ipmr,ip6mr: call ip6mr_free_table() on failure path")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Cong Wang <cong.wang@bytedance.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Link: https://lore.kernel.org/r/20220208053451.2885398-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-02-16 12:43:53 +01:00
..
netfilter
netfilter: x_tables: fix compat match/target pad out-of-bound write
2021-04-16 11:59:12 +02:00
af_inet.c
net: fix use-after-free in tw_timer_handler
2022-01-05 12:31:25 +01:00
ah4.c
ipsec: check return value of skb_to_sgvec always
2018-04-13 19:48:31 +02:00
arp.c
arp: fix arp_filter on l3slave devices
2018-04-13 19:48:32 +02:00
cipso_ipv4.c
cipso,calipso: resolve a number of problems with the DOI refcounts
2022-01-27 08:47:42 +01:00
datagram.c
inet: stop leaking jiffies on the wire
2019-11-10 11:23:29 +01:00
devinet.c
net: return correct error code
2021-12-08 08:45:05 +01:00
esp4.c
ipsec: check return value of skb_to_sgvec always
2018-04-13 19:48:31 +02:00
fib_frontend.c
ipv4: Ignore ECN bits for fib lookups in fib_compute_spec_dst()
2021-01-12 19:49:02 +01:00
fib_lookup.h
…
fib_rules.c
switchdev: remove FIB offload infrastructure
2016-09-28 04:48:00 -04:00
fib_semantics.c
net: Fix the arp error in some cases
2020-06-30 15:38:39 -04:00
fib_trie.c
ipv4: Silence suspicious RCU usage warning
2020-08-21 11:01:55 +02:00
fou.c
net: fou: do not use guehdr after iptunnel_pull_offloads in gue_udp_recv
2019-04-27 09:34:40 +02:00
gre_demux.c
gre: fix uninit-value in __iptunnel_pull_header
2020-03-20 09:07:38 +01:00
gre_offload.c
gso: fix payload length when gso_size is zero
2017-11-18 11:22:20 +01:00
icmp.c
ipv4/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)
2021-09-22 11:42:57 +02:00
igmp.c
igmp: Add ip_mc_list lock in ip_check_mc_rcu
2021-09-22 11:42:56 +02:00
inet_connection_sock.c
net: refactor bind_bucket fastreuse into helper
2020-09-12 11:47:38 +02:00
inet_diag.c
inet_diag: Fix error path to cancel the meseage in inet_req_diag_fill()
2020-11-24 13:02:54 +01:00
inet_fragment.c
net: IP defrag: encapsulate rbtree defrag code into callable functions
2019-05-02 09:32:06 +02:00
inet_hashtables.c
net: initialize fastreuse on inet_inherit_port
2020-09-12 11:47:38 +02:00
inet_timewait_sock.c
soreuseport: initialise timewait reuseport field
2018-05-16 10:08:41 +02:00
inetpeer.c
net: ipv4: use a dedicated counter for icmp_v4 redirect packets
2019-02-23 09:05:59 +01:00
ip_forward.c
ipv4: allow local fragmentation in ip_finish_output_gso()
2016-11-03 16:10:26 -04:00
ip_fragment.c
net: IP defrag: encapsulate rbtree defrag code into callable functions
2019-05-02 09:32:06 +02:00
ip_gre.c
ip_gre: add validation for csum_start
2021-09-03 09:44:40 +02:00
ip_input.c
vrf: check accept_source_route on the original netdevice
2019-04-17 08:36:45 +02:00
ip_options.c
vrf: check accept_source_route on the original netdevice
2019-04-17 08:36:45 +02:00
ip_output.c
ipv4: tcp: send zero IPID in SYNACK messages
2022-02-08 18:15:28 +01:00
ip_sockglue.c
ip: on queued skb use skb_header_pointer instead of pskb_may_pull
2019-01-23 08:10:54 +01:00
ip_tunnel_core.c
ip_tunnel: don't force DF when MTU is locked
2018-11-23 08:20:34 +01:00
ip_tunnel.c
net: fix pmtu check in nopmtudisc mode
2021-01-17 13:57:53 +01:00
ip_vti.c
ip_vti: receive ipip packet by calling ip_tunnel_rcv
2020-06-03 08:16:45 +02:00
ipcomp.c
…
ipconfig.c
net: ipconfig: Don't override command-line hostnames or domains
2021-06-30 08:49:11 -04:00
ipip.c
net: ipip: fix wrong address family in init error path
2020-06-03 08:16:23 +02:00
ipmr.c
ipmr,ip6mr: acquire RTNL before calling ip[6]mr_free_table() on failure path
2022-02-16 12:43:53 +01:00
Kconfig
vti[6]: fix packet tx through bpf_redirect() in XinY cases
2020-04-02 17:20:34 +02:00
Makefile
tcp_bbr: add BBR congestion control
2016-09-21 00:23:01 -04:00
netfilter.c
netfilter: use skb_to_full_sk in ip_route_me_harder
2017-07-05 14:40:28 +02:00
ping.c
ping: Check return value of function 'ping_queue_rcv_skb'
2021-06-30 08:49:20 -04:00
proc.c
tcp: tcp_fragment() should apply sane memory limits
2019-06-17 19:53:32 +02:00
protocol.c
…
raw.c
ipv4: raw: lock the socket in raw_bind()
2022-02-08 18:15:28 +01:00
route.c
ipv4: make exception cache less predictible
2021-09-22 11:43:02 +02:00
syncookies.c
net: Update window_clamp if SOCK_RCVBUF is set
2020-11-18 18:26:29 +01:00
sysctl_net_ipv4.c
tcp: add tcp_min_snd_mss sysctl
2019-06-17 19:53:33 +02:00
tcp_bbr.c
tcp_bbr: fix u32 wrap bug in round logic if bbr_init() called after 2B packets
2021-08-26 08:37:23 -04:00
tcp_bic.c
tcp: replace cnt & rtt with struct in pkts_acked()
2016-05-11 14:43:19 -04:00
tcp_cdg.c
tcp: cdg: rename struct minmax in tcp_cdg.c to avoid a naming conflict
2016-09-21 00:22:59 -04:00
tcp_cong.c
tcp: make sure listeners don't initialize congestion-control state
2020-07-22 09:10:48 +02:00
tcp_cubic.c
tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows
2021-12-08 08:45:03 +01:00
tcp_dctcp.c
tcp: Ensure DCTCP reacts to losses
2019-04-17 08:36:45 +02:00
tcp_diag.c
net: diag: Fix refcnt leak in error path destroying socket
2016-08-23 23:11:36 -07:00
tcp_fastopen.c
tcp: initialize max window for a new fastopen socket
2017-02-04 09:47:10 +01:00
tcp_highspeed.c
…
tcp_htcp.c
tcp: replace cnt & rtt with struct in pkts_acked()
2016-05-11 14:43:19 -04:00
tcp_hybla.c
…
tcp_illinois.c
net/tcp/illinois: replace broken algorithm reference link
2018-05-30 07:50:33 +02:00
tcp_input.c
tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()
2021-09-22 11:43:09 +02:00
tcp_ipv4.c
tcp: seq_file: Avoid skipping sk during tcp_seek_last_pos
2021-09-22 11:43:00 +02:00
tcp_lp.c
tcp: fix wraparound issue in tcp_lp
2017-05-14 14:00:21 +02:00
tcp_metrics.c
tcp: make nla_policy const
2016-09-01 14:09:01 -07:00
tcp_minisocks.c
tcp: do not restart timewait timer on rst reception
2018-09-15 09:42:56 +02:00
tcp_nv.c
tcp_nv: fix potential integer overflow in tcpnv_acked
2018-05-30 07:50:22 +02:00
tcp_offload.c
gso: validate gso_type in GSO handlers
2018-01-31 12:55:55 +01:00
tcp_output.c
ipv6: tcp: drop silly ICMPv6 packet too big messages
2021-07-28 09:14:26 +02:00
tcp_probe.c
tcp: Revert "tcp: tcp_probe: use spin_lock_bh()"
2018-09-15 09:43:01 +02:00
tcp_rate.c
tcp: invalidate rate samples during SACK reneging
2018-01-02 20:35:13 +01:00
tcp_recovery.c
tcp: do not assume TCP code is non preemptible
2016-05-02 17:02:25 -04:00
tcp_scalable.c
…
tcp_timer.c
tcp: fix SNMP TCP timeout under-estimation
2019-12-21 10:41:17 +01:00
tcp_vegas.c
tcp: fix under-evaluated ssthresh in TCP Vegas
2017-12-25 14:23:45 +01:00
tcp_vegas.h
tcp: replace cnt & rtt with struct in pkts_acked()
2016-05-11 14:43:19 -04:00
tcp_veno.c
tcp: replace cnt & rtt with struct in pkts_acked()
2016-05-11 14:43:19 -04:00
tcp_westwood.c
tcp: replace cnt & rtt with struct in pkts_acked()
2016-05-11 14:43:19 -04:00
tcp_yeah.c
tcp: cwnd does not increase in TCP YeAH
2016-09-08 17:16:12 -07:00
tcp.c
tcp: md5: allow changing MD5 keys in all socket states
2020-07-22 09:10:48 +02:00
tunnel4.c
tunnels: correct conditional build of MPLS and IPv6
2016-07-11 13:27:06 -07:00
udp_diag.c
net: inet: diag: expose the socket mark to privileged processes.
2016-09-08 16:13:09 -07:00
udp_impl.h
udplite: call proper backlog handlers
2016-11-24 15:32:14 -05:00
udp_offload.c
net: Fix gro aggregation for udp encaps with zero csum
2021-03-17 16:10:13 +01:00
udp_tunnel.c
net: Remove deprecated tunnel specific UDP offload functions
2016-06-17 20:23:32 -07:00
udp.c
net: udp: fix alignment problem in udp4_seq_show()
2022-01-11 13:38:13 +01:00
udplite.c
udplite: call proper backlog handlers
2016-11-24 15:32:14 -05:00
xfrm4_input.c
…
xfrm4_mode_beet.c
…
xfrm4_mode_transport.c
…
xfrm4_mode_tunnel.c
…
xfrm4_output.c
xfrm: Always set XFRM_TRANSFORMED in xfrm{4,6}_output_finish
2020-05-02 17:23:09 +02:00
xfrm4_policy.c
xfrm4: Fix uninitialized memory read in _decode_session4
2019-05-25 18:26:55 +02:00
xfrm4_protocol.c
…
xfrm4_state.c
…
xfrm4_tunnel.c
…