John Meneghini
3a345198a7
scsi: bnx2fc: Make bnx2fc_recv_frame() mp safe ...
commit 936bd03405fc83ba039d42bc93ffd4b88418f1d3 upstream.
Running tests with a debug kernel shows that bnx2fc_recv_frame() is
modifying the per_cpu lport stats counters in a non-mpsafe way. Just boot
a debug kernel and run the bnx2fc driver with the hardware enabled.
[ 1391.699147] BUG: using smp_processor_id() in preemptible [00000000] code: bnx2fc_
[ 1391.699160] caller is bnx2fc_recv_frame+0xbf9/0x1760 [bnx2fc]
[ 1391.699174] CPU: 2 PID: 4355 Comm: bnx2fc_l2_threa Kdump: loaded Tainted: G B
[ 1391.699180] Hardware name: HP ProLiant DL120 G7, BIOS J01 07/01/2013
[ 1391.699183] Call Trace:
[ 1391.699188] dump_stack_lvl+0x57/0x7d
[ 1391.699198] check_preemption_disabled+0xc8/0xd0
[ 1391.699205] bnx2fc_recv_frame+0xbf9/0x1760 [bnx2fc]
[ 1391.699215] ? do_raw_spin_trylock+0xb5/0x180
[ 1391.699221] ? bnx2fc_npiv_create_vports.isra.0+0x4e0/0x4e0 [bnx2fc]
[ 1391.699229] ? bnx2fc_l2_rcv_thread+0xb7/0x3a0 [bnx2fc]
[ 1391.699240] bnx2fc_l2_rcv_thread+0x1af/0x3a0 [bnx2fc]
[ 1391.699250] ? bnx2fc_ulp_init+0xc0/0xc0 [bnx2fc]
[ 1391.699258] kthread+0x364/0x420
[ 1391.699263] ? _raw_spin_unlock_irq+0x24/0x50
[ 1391.699268] ? set_kthread_struct+0x100/0x100
[ 1391.699273] ret_from_fork+0x22/0x30
Restore the old get_cpu/put_cpu code with some modifications to reduce the
size of the critical section.
Link: https://lore.kernel.org/r/20220124145110.442335-1-jmeneghi@redhat.com
Fixes: d576a5e80cd0 ("bnx2fc: Improve stats update mechanism")
Tested-by: Guangwu Zhang <guazhang@redhat.com>
Acked-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: John Meneghini <jmeneghi@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-02-08 18:15:29 +01:00
2020-10-01 20:40:01 +02:00
2021-07-28 09:14:25 +02:00
2019-02-20 10:18:35 +01:00
2016-10-26 22:17:43 -04:00
2020-08-21 11:02:01 +02:00
2021-07-20 16:21:15 +02:00
2020-01-14 20:04:31 +01:00
2022-02-08 18:15:29 +01:00
2020-12-29 13:44:50 +01:00
2021-11-26 11:48:37 +01:00
2020-01-23 08:19:37 +01:00
2016-09-14 12:47:42 -04:00
2021-08-26 08:37:26 -04:00
2020-01-23 08:19:42 +01:00
2020-09-03 11:21:18 +02:00
2020-12-29 13:44:59 +01:00
2019-04-05 22:29:06 +02:00
2021-02-10 09:09:24 +01:00
2018-10-20 09:51:30 +02:00
2019-11-28 18:28:24 +01:00
2021-05-22 10:40:18 +02:00
2021-06-03 08:23:32 +02:00
2021-11-26 11:48:40 +01:00
2021-08-26 08:37:26 -04:00
2021-12-08 08:45:03 +01:00
2018-05-25 16:13:08 +02:00
2016-07-20 17:38:35 -06:00
2015-05-31 18:06:28 -07:00
2020-12-29 13:44:59 +01:00
2021-11-26 11:48:38 +01:00
2020-10-29 09:05:34 +01:00
2019-06-22 08:17:24 +02:00
2017-08-06 18:59:49 -07:00
2019-11-25 09:52:13 +01:00
2022-01-27 08:47:35 +01:00
2018-09-19 22:47:14 +02:00
2015-04-27 10:10:19 -07:00
2018-09-19 22:47:14 +02:00
2015-04-27 10:04:39 -07:00
2018-09-19 22:47:14 +02:00
2015-04-27 10:05:55 -07:00
2016-07-13 22:33:23 -04:00
2016-07-13 22:33:23 -04:00
2015-08-07 15:03:42 +02:00
2021-11-26 11:48:40 +01:00
2015-05-31 18:06:28 -07:00
2016-02-23 21:27:02 -05:00
2015-04-09 18:08:31 -07:00
2015-05-31 18:06:28 -07:00
2015-05-31 18:06:28 -07:00
2015-04-17 10:13:56 -07:00
2020-01-04 13:40:54 +01:00
2015-11-25 22:08:55 -05:00
2015-11-25 22:08:52 -05:00
2021-09-22 11:43:08 +02:00
2021-06-03 08:23:31 +02:00
2015-04-14 09:50:27 -07:00
2016-08-16 00:49:32 -04:00
2021-11-26 11:48:36 +01:00
2016-04-11 16:57:09 -04:00
2016-02-23 21:27:02 -05:00
2016-05-10 22:01:07 -04:00
2014-11-24 14:45:27 +01:00
2018-11-13 11:16:51 -08:00
2018-11-13 11:16:51 -08:00
2016-02-23 21:27:02 -05:00
2021-07-20 16:21:04 +02:00
2017-01-12 11:39:29 +01:00
2016-09-29 21:52:43 -04:00
2016-02-25 21:16:49 -05:00
2016-02-25 21:16:49 -05:00
2020-09-12 11:47:36 +02:00
2021-07-20 16:21:10 +02:00
2019-07-10 09:55:43 +02:00
2020-11-18 18:26:26 +01:00
2017-12-20 10:07:22 +01:00
2015-08-12 13:14:57 -07:00
2015-08-12 13:14:57 -07:00
2016-02-25 21:10:53 -05:00
2015-11-20 11:39:03 -05:00
2020-04-02 17:20:32 +02:00
2020-04-02 17:20:32 +02:00
2019-11-28 18:28:23 +01:00
2020-06-30 15:38:28 -04:00
2020-02-28 15:42:34 +01:00
2016-01-27 20:36:10 +08:00
2021-05-22 10:40:25 +02:00
2019-11-10 11:23:15 +01:00
2016-01-27 20:36:10 +08:00
2022-01-11 13:38:12 +01:00
2016-02-05 16:29:28 -06:00
2018-11-13 11:16:51 -08:00
2020-01-04 13:40:54 +01:00
2016-09-26 20:49:25 -04:00
2019-10-29 09:14:57 +01:00
2020-08-21 11:02:02 +02:00
2020-10-29 09:05:43 +01:00
2014-11-24 14:45:27 +01:00
2015-05-31 18:06:28 -07:00
2019-11-25 09:53:05 +01:00
2016-09-14 14:11:12 -04:00
2015-05-31 18:06:28 -07:00
2014-11-24 20:01:28 +01:00
2016-09-04 01:28:07 -04:00
2016-02-23 21:27:02 -05:00
2015-05-31 18:06:28 -07:00
2016-04-30 09:25:26 -07:00
2015-05-31 18:06:28 -07:00
2016-03-01 20:06:49 -05:00
2016-11-28 15:51:31 -05:00
2016-04-04 12:07:42 -04:00
2021-12-22 09:05:15 +01:00
2020-06-30 15:38:37 -04:00
2019-05-08 07:19:10 +02:00
2016-06-18 11:59:01 -07:00
2014-11-12 11:16:12 +01:00
2021-07-20 16:21:06 +02:00
2019-10-07 18:53:15 +02:00
2019-01-23 08:10:54 +01:00
2016-10-07 09:28:53 -07:00
2016-04-11 16:57:09 -04:00
2016-03-14 21:05:04 -04:00
2021-08-26 08:37:26 -04:00
2021-11-12 13:18:01 +01:00
2020-01-23 08:19:43 +01:00
2016-04-11 16:57:09 -04:00
2021-12-08 08:45:05 +01:00
2016-08-18 22:23:20 -04:00
2020-07-31 16:44:01 +02:00
2018-06-06 16:44:38 +02:00
2021-11-12 13:18:01 +01:00
2016-09-15 09:51:14 -04:00
2021-10-09 13:25:59 +02:00
2016-09-15 09:51:14 -04:00
2016-04-11 16:57:09 -04:00
2021-10-17 10:05:40 +02:00
2020-05-20 08:15:34 +02:00
2016-02-23 21:27:02 -05:00
2021-05-22 10:40:26 +02:00
2018-12-13 09:20:29 +01:00
2022-01-27 08:47:40 +01:00
2022-01-27 08:47:40 +01:00
2021-04-07 12:05:39 +02:00
2015-11-18 11:59:09 -05:00
2016-02-23 21:27:02 -05:00
2019-05-08 07:19:10 +02:00
2020-01-04 13:40:54 +01:00
2014-11-20 09:11:15 +01:00
2021-05-22 10:40:26 +02:00
2015-05-31 18:06:28 -07:00
2021-10-17 10:05:40 +02:00
2022-01-05 12:31:25 +01:00
2016-11-01 13:31:23 -04:00
2015-02-02 09:57:46 -08:00
2016-09-01 17:52:01 -07:00
2015-05-31 18:06:28 -07:00
2018-08-24 13:12:29 +02:00
3a345198a7