Kees Cook
9995aa5fe0
ARM: vexpress/spc: Avoid negative array index when !SMP ...
[ Upstream commit b3f1dd52c991d79118f35e6d1bf4d7cb09882e38 ]
When building multi_v7_defconfig+CONFIG_SMP=n, -Warray-bounds exposes
a couple negative array index accesses:
arch/arm/mach-vexpress/spc.c: In function 've_spc_clk_init':
arch/arm/mach-vexpress/spc.c:583:21: warning: array subscript -1 is below array bounds of 'bool[2]' {aka '_Bool[2]'} [-Warray-bounds]
583 | if (init_opp_table[cluster])
| ~~~~~~~~~~~~~~^~~~~~~~~
arch/arm/mach-vexpress/spc.c:556:7: note: while referencing 'init_opp_table'
556 | bool init_opp_table[MAX_CLUSTERS] = { false };
| ^~~~~~~~~~~~~~
arch/arm/mach-vexpress/spc.c:592:18: warning: array subscript -1 is below array bounds of 'bool[2]' {aka '_Bool[2]'} [-Warray-bounds]
592 | init_opp_table[cluster] = true;
| ~~~~~~~~~~~~~~^~~~~~~~~
arch/arm/mach-vexpress/spc.c:556:7: note: while referencing 'init_opp_table'
556 | bool init_opp_table[MAX_CLUSTERS] = { false };
| ^~~~~~~~~~~~~~
Skip this logic when built !SMP.
Link: https://lore.kernel.org/r/20220331190443.851661-1-keescook@chromium.org
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-04-27 13:14:10 +02:00
2022-04-20 09:06:41 +02:00
2020-01-29 10:24:18 +01:00
2019-10-17 13:42:26 -07:00
2019-05-21 18:49:00 +02:00
2018-12-05 19:42:41 +01:00
2022-04-12 07:52:17 +02:00
2022-03-16 12:49:01 +01:00
2022-04-12 07:52:17 +02:00
2020-03-20 09:07:58 +01:00
2020-08-21 11:01:57 +02:00
2018-03-22 09:17:39 +01:00
2019-02-06 17:33:28 +01:00
2022-04-20 09:06:46 +02:00
2019-06-22 08:17:17 +02:00
2021-02-10 09:09:26 +01:00
2018-09-26 08:36:38 +02:00
2021-10-17 10:05:39 +02:00
2020-06-30 15:38:20 -04:00
2019-05-08 07:19:11 +02:00
2019-02-15 08:07:38 +01:00
2021-04-28 12:07:15 +02:00
2019-12-05 15:34:18 +01:00
2022-04-20 09:06:40 +02:00
2018-10-03 17:01:47 -07:00
2019-12-21 10:41:13 +01:00
2021-06-30 08:49:10 -04:00
2018-05-30 07:50:32 +02:00
2019-02-12 19:44:55 +01:00
2018-09-15 09:43:00 +02:00
2020-01-29 10:24:24 +01:00
2022-04-20 09:06:41 +02:00
2021-12-08 08:45:03 +01:00
2017-10-08 10:26:11 +02:00
2019-02-15 08:07:38 +01:00
2020-06-20 10:24:21 +02:00
2017-01-26 08:24:43 +01:00
2022-04-27 13:14:10 +02:00
2019-10-05 12:30:33 +02:00
2022-03-11 10:03:32 +01:00
2019-08-25 10:51:40 +02:00
2019-05-08 07:19:11 +02:00
2018-05-30 07:50:29 +02:00
2019-05-08 07:19:11 +02:00
2020-01-29 10:24:21 +01:00
2020-11-10 10:24:00 +01:00
2021-11-02 17:39:22 +01:00
2019-05-31 06:48:14 -07:00
2019-02-20 10:18:26 +01:00
2021-03-07 11:25:58 +01:00
2021-10-27 09:34:01 +02:00
2017-10-08 10:26:04 +02:00
2022-01-29 10:15:58 +01:00
2021-11-26 11:48:39 +01:00
9995aa5fe0