Alexey Bayduraev 51e96061c6 perf data: Fix double free in perf_session__delete()
commit 69560e366fc4d5fca7bebb0e44edbfafc8bcaf05 upstream.

When perf_data__create_dir() fails, it calls close_dir(), but
perf_session__delete() also calls close_dir() and since dir.version and
dir.nr were initialized by perf_data__create_dir(), a double free occurs.

This patch moves the initialization of dir.version and dir.nr after
successful initialization of dir.files, that prevents double freeing.
This behavior is already implemented in perf_data__open_dir().

Fixes: 145520631130bd64 ("perf data: Add perf_data__(create_dir|close_dir) functions")
Signed-off-by: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Antonov <alexander.antonov@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexei Budankov <abudankov@huawei.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20220218152341.5197-2-alexey.v.bayduraev@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-03-02 11:42:48 +01:00
..
2020-01-14 12:02:19 -03:00
2021-12-08 09:03:20 +01:00
2019-02-19 16:11:56 -03:00
2019-02-19 16:11:56 -03:00
2021-05-19 10:13:13 +02:00
2020-10-14 13:34:26 -03:00
2020-10-14 13:34:26 -03:00
2020-06-22 16:28:09 -03:00
2020-07-30 07:01:49 -03:00
2021-07-28 14:35:35 +02:00
2019-01-25 15:12:09 +01:00
2020-09-28 09:07:08 -03:00
2020-10-14 13:34:26 -03:00
2020-10-14 13:34:26 -03:00
2020-04-18 09:05:01 -03:00
2020-04-18 09:05:01 -03:00