linux

iv/linux

History

Pierre-Louis Bossart fbd7b564f9 soundwire: bus_type: fix remove and shutdown support

[ Upstream commit df6407782964dc7e35ad84230abb38f46314b245 ]

The bus sdw_drv_remove() and sdw_drv_shutdown() helpers are used
conditionally, if the driver provides these routines.

These helpers already test if the driver provides a .remove or
.shutdown callback, so there's no harm in invoking the
sdw_drv_remove() and sdw_drv_shutdown() unconditionally.

In addition, the current code is imbalanced with
dev_pm_domain_attach() called from sdw_drv_probe(), but
dev_pm_domain_detach() called from sdw_drv_remove() only if the driver
provides a .remove callback.

Fixes: 9251345dca24b ("soundwire: Add SoundWire bus type")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20220610015105.25987-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2022-08-21 15:15:56 +02:00

bus_type.c

soundwire: bus_type: fix remove and shutdown support

2022-08-21 15:15:56 +02:00

bus.c

soundwire: bus: Fix device found flag correctly

2021-05-14 09:50:13 +02:00

bus.h

soundwire: bus: add enumerated Slave device to device list

2020-09-28 11:17:40 +05:30

cadence_master.c

soundwire: cadence: only prepare attached devices on clock stop