iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/nfs
History
Zhang Xiaoxu 45aea4fbf6 nfs4: Fix kmemleak when allocate slot failed 
[ Upstream commit 7e8436728e22181c3f12a5dbabd35ed3a8b8c593 ]

If one of the slot allocate failed, should cleanup all the other
allocated slots, otherwise, the allocated slots will leak:

  unreferenced object 0xffff8881115aa100 (size 64):
    comm ""mount.nfs"", pid 679, jiffies 4294744957 (age 115.037s)
    hex dump (first 32 bytes):
      00 cc 19 73 81 88 ff ff 00 a0 5a 11 81 88 ff ff  ...s......Z.....
      00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    backtrace:
      [<000000007a4c434a>] nfs4_find_or_create_slot+0x8e/0x130
      [<000000005472a39c>] nfs4_realloc_slot_table+0x23f/0x270
      [<00000000cd8ca0eb>] nfs40_init_client+0x4a/0x90
      [<00000000128486db>] nfs4_init_client+0xce/0x270
      [<000000008d2cacad>] nfs4_set_client+0x1a2/0x2b0
      [<000000000e593b52>] nfs4_create_server+0x300/0x5f0
      [<00000000e4425dd2>] nfs4_try_get_tree+0x65/0x110
      [<00000000d3a6176f>] vfs_get_tree+0x41/0xf0
      [<0000000016b5ad4c>] path_mount+0x9b3/0xdd0
      [<00000000494cae71>] __x64_sys_mount+0x190/0x1d0
      [<000000005d56bdec>] do_syscall_64+0x35/0x80
      [<00000000687c9ae4>] entry_SYSCALL_64_after_hwframe+0x46/0xb0

Fixes: abf79bb341bf ("NFS: Add a slot table to struct nfs_client for NFSv4.0 transport blocking")
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-11-10 18:14:16 +01:00
..
blocklayout
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
filelayout
NFS: fix an incorrect limit in filelayout_decode_layout()
2021-06-03 09:00:35 +02:00
flexfilelayout
pnfs/flexfiles: Fix misplaced barrier in nfs4_ff_layout_prepare_ds
2021-11-18 14:04:22 +01:00
cache_lib.c
…
cache_lib.h
…
callback_proc.c
pNFS: Avoid a live lock condition in pnfs_update_layout()
2022-06-22 14:13:16 +02:00
callback_xdr.c
NFS: remove unneeded check in decode_devicenotify_args()
2022-04-08 14:40:27 +02:00
callback.c
…
callback.h
NFSv4.1: Fix uninitialised variable in devicenotify
2022-02-16 12:54:18 +01:00
client.c
NFS: Fix initialisation of nfs_client cl_flags field
2022-02-16 12:54:17 +01:00
delegation.c
NFSv4: Fix a potential state reclaim deadlock
2022-11-10 18:14:16 +01:00
delegation.h
NFSv4: Fix delegation return in cases where we have to retry
2021-07-20 16:05:47 +02:00
dir.c
NFSv4: fix open failure with O_ACCMODE flag
2022-04-13 21:01:04 +02:00
direct.c
NFS: swap-out must always use STABLE writes.
2022-04-13 21:01:02 +02:00
dns_resolve.c
NFS: remove duplicate headers
2020-05-27 10:10:12 -04:00
dns_resolve.h
…
export.c
…
file.c
NFS: Do not report flush errors in nfs_write_end()
2022-06-09 10:21:19 +02:00
fs_context.c
nfs: fix broken handling of the softreval mount option
2022-05-18 10:23:43 +02:00
fscache-index.c
…
fscache.c
NFSv4: Fix fscache cookie aux_data to ensure change_attr is included
2020-05-08 22:20:24 +01:00
fscache.h
…
getroot.c
NFS: Ensure security label is set for root inode
2020-03-30 19:56:50 -04:00
inode.c
Revert "NFSv4: Handle the special Linux file open access mode"
2022-04-13 21:01:04 +02:00
internal.h
NFS: Memory allocation failures are not server fatal errors
2022-06-06 08:42:44 +02:00
io.c
…
iostat.h
…
Kconfig
nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default
2021-03-30 14:31:49 +02:00
Makefile
NFSv4.2: add client side xattr caching.
2020-07-13 17:52:46 -04:00
mount_clnt.c
NFSv3: fix rpc receive buffer size for MOUNT call
2020-05-14 18:42:44 -04:00
namespace.c
NFS: fix nfs_path in case of a rename retry
2020-10-06 10:21:18 -04:00
netns.h
…
nfs2super.c
…
nfs2xdr.c
NFS: Return valid errors from nfs2/3_decode_dirent()
2022-04-08 14:40:25 +02:00
nfs3_fs.h
…
nfs3acl.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
nfs3client.c
Revert "pNFS: nfs3_set_ds_client should set NFS_CS_NOPING"
2022-08-21 15:15:18 +02:00
nfs3proc.c
nfs: fix acl memory leak of posix_acl_create()
2021-07-20 16:05:51 +02:00
nfs3super.c
…
nfs3xdr.c
NFS: Return valid errors from nfs2/3_decode_dirent()
2022-04-08 14:40:25 +02:00
nfs4_fs.h
NFSv4 handle port presence in fs_location server string
2022-02-16 12:54:18 +01:00
nfs4client.c
nfs4: Fix kmemleak when allocate slot failed
2022-11-10 18:14:16 +01:00
nfs4file.c
NFSv4.2 fix problems with __nfs42_ssc_open
2022-08-31 17:15:15 +02:00
nfs4getroot.c
…
nfs4idmap.c
NFSv4: Fix races in the legacy idmapper upcall
2022-08-25 11:37:54 +02:00
nfs4idmap.h
…
nfs4namespace.c
NFSv4 handle port presence in fs_location server string
2022-02-16 12:54:18 +01:00
nfs4proc.c
NFSv4/pnfs: Fix a use-after-free bug in open
2022-08-25 11:37:54 +02:00
nfs4renewd.c
NFSv4.0: nfs4_do_fsinfo() should not do implicit lease renewals
2020-02-04 12:27:55 -05:00
nfs4session.c
…
nfs4session.h
…
nfs4state.c
NFSv4.1: We must always send RECLAIM_COMPLETE after a reboot
2022-11-10 18:14:16 +01:00
nfs4super.c
NFS: Adjust fs_context error logging
2021-01-19 18:27:30 +01:00
nfs4sysctl.c
…
nfs4trace.c
pNFS/flexfiles: Add tracing for layout errors
2020-01-15 10:54:33 -05:00
nfs4trace.h
NFSv4: Wait for stateid updates after CLOSE/OPEN_DOWNGRADE
2020-10-02 08:43:09 -04:00
nfs4xdr.c
NFSv4 remove zero number of fs_locations entries error check
2022-02-16 12:54:18 +01:00
nfs42.h
NFSv4.2: add the extended attribute proc functions.
2020-07-13 17:52:45 -04:00
nfs42proc.c
NFSv4.2: fix reference count leaks in _nfs42_proc_copy_notify()
2022-04-13 21:01:01 +02:00
nfs42xattr.c
NFSv4.2: fix failure to unregister shrinker
2020-11-12 10:40:02 -05:00
nfs42xdr.c
NFSv42: Don't fail clone() unless the OP_CLONE operation failed
2021-12-01 09:19:03 +01:00
nfs.h
…
nfsroot.c
nfsroot: Default mount option should ask for built-in NFS version
2020-11-02 10:29:03 -05:00
nfstrace.c
…
nfstrace.h
nfs: define and use the NFS_INO_INVALID_XATTR flag
2020-07-13 17:52:45 -04:00
pagelist.c
NFS: Avoid writeback threads getting stuck in mempool_alloc()
2022-04-13 21:01:03 +02:00
pnfs_dev.c
…
pnfs_nfs.c
NFS: nfsiod should not block forever in mempool_alloc()
2022-04-13 21:01:03 +02:00
pnfs.c
pNFS: Avoid a live lock condition in pnfs_update_layout()
2022-06-22 14:13:16 +02:00
pnfs.h
pNFS: Avoid a live lock condition in pnfs_update_layout()
2022-06-22 14:13:16 +02:00
proc.c
NFS: Add softreval behaviour to nfs_lookup_revalidate()
2020-01-24 16:51:13 -05:00
read.c
NFS: Trace short NFS READs
2020-06-11 13:33:48 -04:00
super.c
NFSv4: Turn off open-by-filehandle and NFS re-export for NFSv4.0
2022-09-23 14:16:57 +02:00
symlink.c
…
sysctl.c
…
sysfs.c
NFSv4: Fix up RCU annotations for struct nfs_netns_client
2020-10-15 13:31:08 -04:00
sysfs.h
NFSv4: Fix up RCU annotations for struct nfs_netns_client
2020-10-15 13:31:08 -04:00
unlink.c
NFS: Avoid referencing the cred twice in async rename/unlink
2020-03-16 08:34:29 -04:00
write.c
NFS: Don't report errors from nfs_pageio_complete() more than once
2022-06-09 10:21:19 +02:00