Alexander Potapenko
a033b86c7f
ipv6: addrlabel: fix infoleak when sending struct ifaddrlblmsg to network ...
[ Upstream commit c23fb2c82267638f9d206cb96bb93e1f93ad7828 ]
When copying a `struct ifaddrlblmsg` to the network, __ifal_reserved
remained uninitialized, resulting in a 1-byte infoleak:
BUG: KMSAN: kernel-network-infoleak in __netdev_start_xmit ./include/linux/netdevice.h:4841
__netdev_start_xmit ./include/linux/netdevice.h:4841
netdev_start_xmit ./include/linux/netdevice.h:4857
xmit_one net/core/dev.c:3590
dev_hard_start_xmit+0x1dc/0x800 net/core/dev.c:3606
__dev_queue_xmit+0x17e8/0x4350 net/core/dev.c:4256
dev_queue_xmit ./include/linux/netdevice.h:3009
__netlink_deliver_tap_skb net/netlink/af_netlink.c:307
__netlink_deliver_tap+0x728/0xad0 net/netlink/af_netlink.c:325
netlink_deliver_tap net/netlink/af_netlink.c:338
__netlink_sendskb net/netlink/af_netlink.c:1263
netlink_sendskb+0x1d9/0x200 net/netlink/af_netlink.c:1272
netlink_unicast+0x56d/0xf50 net/netlink/af_netlink.c:1360
nlmsg_unicast ./include/net/netlink.h:1061
rtnl_unicast+0x5a/0x80 net/core/rtnetlink.c:758
ip6addrlbl_get+0xfad/0x10f0 net/ipv6/addrlabel.c:628
rtnetlink_rcv_msg+0xb33/0x1570 net/core/rtnetlink.c:6082
...
Uninit was created at:
slab_post_alloc_hook+0x118/0xb00 mm/slab.h:742
slab_alloc_node mm/slub.c:3398
__kmem_cache_alloc_node+0x4f2/0x930 mm/slub.c:3437
__do_kmalloc_node mm/slab_common.c:954
__kmalloc_node_track_caller+0x117/0x3d0 mm/slab_common.c:975
kmalloc_reserve net/core/skbuff.c:437
__alloc_skb+0x27a/0xab0 net/core/skbuff.c:509
alloc_skb ./include/linux/skbuff.h:1267
nlmsg_new ./include/net/netlink.h:964
ip6addrlbl_get+0x490/0x10f0 net/ipv6/addrlabel.c:608
rtnetlink_rcv_msg+0xb33/0x1570 net/core/rtnetlink.c:6082
netlink_rcv_skb+0x299/0x550 net/netlink/af_netlink.c:2540
rtnetlink_rcv+0x26/0x30 net/core/rtnetlink.c:6109
netlink_unicast_kernel net/netlink/af_netlink.c:1319
netlink_unicast+0x9ab/0xf50 net/netlink/af_netlink.c:1345
netlink_sendmsg+0xebc/0x10f0 net/netlink/af_netlink.c:1921
...
This patch ensures that the reserved field is always initialized.
Reported-by: syzbot+3553517af6020c4f2813f1003fe76ef3cbffe98d@syzkaller.appspotmail.com
Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.")
Signed-off-by: Alexander Potapenko <glider@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-11-16 09:57:11 +01:00
2020-06-20 21:33:57 -07:00
2022-10-26 13:25:22 +02:00
2020-08-31 12:26:39 -07:00
2022-08-31 17:15:21 +02:00
2022-11-16 09:57:11 +01:00
2022-07-29 17:19:12 +02:00
2021-04-14 08:42:05 +02:00
2020-07-30 16:30:55 -07:00
2021-03-17 17:06:15 +01:00
2022-10-30 09:41:19 +01:00
2022-03-16 14:15:57 +01:00
2022-04-27 13:53:48 +02:00
2021-07-14 16:56:28 +02:00
2021-12-08 09:03:21 +01:00
2020-06-20 21:33:57 -07:00
2022-06-09 10:21:09 +02:00
2022-06-09 10:21:09 +02:00
2022-08-21 15:15:51 +02:00
2022-02-01 17:25:44 +01:00
2022-02-23 12:01:01 +01:00
2022-11-03 23:57:53 +09:00
2021-03-04 11:38:46 +01:00
2022-11-10 18:14:26 +01:00
2022-03-02 11:42:49 +01:00
2022-08-25 11:37:59 +02:00
2022-11-03 23:57:53 +09:00
2020-06-01 14:57:14 -07:00
2022-01-11 15:25:02 +01:00
2022-04-13 21:00:56 +02:00
2020-07-09 12:55:37 +02:00
2022-11-10 18:14:25 +01:00
2020-09-18 17:45:04 -07:00
2021-05-14 09:50:44 +02:00
2021-06-03 09:00:48 +02:00
2020-11-13 14:24:39 -08:00
2020-10-30 12:57:39 +01:00
2021-07-19 09:44:44 +02:00
2022-08-03 12:00:46 +02:00
2022-06-09 10:21:09 +02:00
2021-06-03 09:00:50 +02:00
2022-11-10 18:14:20 +01:00
2020-06-23 20:27:09 -07:00
2022-07-07 17:52:17 +02:00
2022-07-21 21:20:11 +02:00
2022-07-21 21:20:11 +02:00
2022-09-15 11:32:05 +02:00
2022-11-03 23:57:53 +09:00
2022-07-29 17:19:16 +02:00
2020-09-02 15:44:53 -07:00
2022-11-10 18:14:26 +01:00
2020-07-09 12:52:37 +02:00
2020-07-24 15:41:54 -07:00
2021-02-10 09:29:23 +01:00
2022-11-10 18:14:26 +01:00
2020-07-19 18:16:41 -07:00
2022-04-08 14:39:47 +02:00
2020-10-09 12:29:48 +02:00
a033b86c7f